From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A524EB64DD for ; Mon, 7 Aug 2023 06:00:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A1746B0072; Mon, 7 Aug 2023 02:00:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 851276B0074; Mon, 7 Aug 2023 02:00:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 719238D0001; Mon, 7 Aug 2023 02:00:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6150F6B0072 for ; Mon, 7 Aug 2023 02:00:18 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 074701C8C8B for ; Mon, 7 Aug 2023 06:00:18 +0000 (UTC) X-FDA: 81096258516.06.70D890D Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf09.hostedemail.com (Postfix) with ESMTP id 339E614002C for ; Mon, 7 Aug 2023 06:00:15 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ing8uEaE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of elver@google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691388016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vBFHuRwuyk/hnPCEfjgfoHOKPA/ytrkp+MGxY8mmrKo=; b=jUNane0odN/z2OYfVkayKAv5ofiW24jATJKkoN9rJRw7Ipj3H1ox5RL/DWoHWPDpUMtlqx CkM+FFzKJOuVbUWvcjfZmL8FZJU/1d5hQ3WrbkPHa6sXVlLPUQQq6sSSSPjwKJq9vzv7Mh oRVJEyujahWl80Pi+QJwl/xwGQr3Xq8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ing8uEaE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of elver@google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691388016; a=rsa-sha256; cv=none; b=kE3i5yCQImwDwbDW2k+o2pt0Ae7qX2rOpe0QGN4rmDsPr5eyomblJY75xNSHTFtrA4A7mI 3cFpjH4Yj1q+Mgvd8+yCsEHkG8iaUfrx9pB5wFksBho8/JuvbXB8BBdZycpA73YyJAq5Jh oNn4wJwo1VkdR8PUHVSXCK1vLCOjLbs= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-3fe12820bffso35033395e9.3 for ; Sun, 06 Aug 2023 23:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691388014; x=1691992814; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vBFHuRwuyk/hnPCEfjgfoHOKPA/ytrkp+MGxY8mmrKo=; b=ing8uEaEI6AyFRCS86oxZCzrhNFZrz8eWqmEwOAVETm0oEwqoMzRaZXtrUhyLmH3Ue g432XZJQAydL1L9hVsnpW3b/J1BEyU/z9K248mkSwpWkY1OTTS/k4ELkhyxrwu6vD65X f3ppPjIGcQq4lsq4p65kMnKCSLTsj24SMvEW06akzsasr1T2i6xPCOiV0vobRAon5XcF YAI1Ze+ANA8HZegTTarYMIwxlK2j3hTsPYgnSX3AFQ2Qo3TVh5tPWJDH2tA9MbW+eCnW 7HtnLl43Ld40ka3QcPe+iqMI9sA79z4emvVMdYCsMhPKb7BQDMFRlTpL2oL4q7lFc71+ kU4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691388014; x=1691992814; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vBFHuRwuyk/hnPCEfjgfoHOKPA/ytrkp+MGxY8mmrKo=; b=Pubp+RFkQdE0YgTKrbd2PAdGV9N7bwz+46IzqJw3f+qIDA0WEAO6BqvuKYEqdvfE00 BiXMlnUdZSF+b5WFMXOoA98GerevLF7jx7KfLysboXBu6NOz+OUwgaC1V+9E/gHI/PMt 04u3ZtUMK8DGMhv3E9dhgdvA2UatRrHlnaeS2vCcAWh41dLqeeZ5cLYvGNK7vW98VDe4 MiP80r3oTzX8j6AXf04Mm/5un3O7ujX2EK49FEHqXO2hu6oXuONBkMDHY+xqD/P9aZJ5 kTJcjpFhMVt8/Tnln2/5kUBHKi+ykc+YHyfOIl47akfadE8KBEpV1e4Tnw7IRHJZ0OM8 2VnA== X-Gm-Message-State: AOJu0YzAM4JtdF8RKfZRQGdlCSsmjPzyFOAidz9hyBLGFintr0p3LxWl p3hqLHxrO2JOfK5BlhsHo3gVj0jMbYAjEgw2NcEOkQ== X-Google-Smtp-Source: AGHT+IHDpKikMK162S/f6hlLKBlIolxb1nyfPLWImrljpKPeBJjZEK+kRSf/yDbSwFjsCHJRe15fR+4BgfkRl3Gf0qM= X-Received: by 2002:a1c:ed03:0:b0:3fb:a102:6d7a with SMTP id l3-20020a1ced03000000b003fba1026d7amr4975049wmh.28.1691388014380; Sun, 06 Aug 2023 23:00:14 -0700 (PDT) MIME-Version: 1.0 References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-4-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230805175027.50029-4-andriy.shevchenko@linux.intel.com> From: Marco Elver Date: Mon, 7 Aug 2023 08:00:00 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] lib/vsprintf: Declare no_hash_pointers in sprintf.h To: Andy Shevchenko Cc: Petr Mladek , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 339E614002C X-Stat-Signature: cwhqdk879yp46xnnaqn99efjroxi663t X-Rspam-User: X-HE-Tag: 1691388015-909587 X-HE-Meta: U2FsdGVkX19tDtJV+EsZLfrV4/jjK1a58YIDtEy7o9GjHTi8ZG+eIO/kq71N53XhexLGss4KtWqyUFBj/rHIBI+viyxxwXUVC7hAdZB8ISEbLnA7kHCXtBWQLdGen5e54RzLh1TxkOKd3k4ZUqItHr41O4PCRJFUPAecVVHzzOCR4SyoaZ/dPboACahtUQ1zqlShKVp7UyDytXTqd4MhtGSrUuzpAFpsl2fPsX5ffsy34Ft/VzVKH7QzE6ICke9ABRO4f7K1qS8eNMytu7LzAqJVIS/e/AY4b0tx/j8Q8RHrE1DUz7ivMhOMX+VXZWaH/Fgt95knHaj7H6petHkmqNLcf+EhIgOUkNcJ5L9UGM3zMmZoev4TpnMuRcxZnn3VL5yHt4E+4PlnrWCQTbR3KtBubdrXkFKgdOBWxrSms3nnLdMUt2sXpEOyfUmS/HbMpboTPASgq5+7NXbBeINPsVVYU1kLk7UO3XlO1tTwmzJ8JdIdNd7rOfzJcfDIalgMh95vUzFENae+MDqqi7JUohvw5jUgIgqdlBC2aabBzsKcMB6W4pkMLAodhHcZJFiWIfHGqt5JaE7wBJBphBDlgsmMnSoD2xbyhEXyOtQGdKeFnwHisxLf6VNOENzUyS45ri4yl2QprQbdXc26WYcIeIojzLjvmZyYiVPZPmadRKfBd5pfPL0J+aL3WvukCDErnUsP9t4/PgOe7oAJeH5ahgIK39mAj67+XLmaLu2C53WjcJ4JGuV1/QRLIiRmApV5PeJvxBsp3OZVeLzyVVLX/fEVsgUkt69K/a5B/43NE7ZriqfiTAeVTQK9FkVi1/12FUPsQ0W2NwijrHBDZygrE87hfOBmqN4XGb9Z6fB3cSapQY452fjj0pSNUjBmUF1miQP6n+VbRPa4pK+HpmbixEtf/W074cnoncawVRMOrMoFG4oxr6XYb5PKHtQ4MXMwR7BU8wpslWcZfXZQk+F NKNwkZ1y 9p1A+IV4iGJcsCOqG/Fsghhfg3p/rpc8xPEI0w5py7qr5j1xm2KtGM837hyRTSd7wcnL5FSoeTsHE/zOwy11qA8ag80BVKViNQhRYGHD4Qx2T4vOc8byJlYJ7yuruMIe701+j5lkvCrEekoANpDmvODiObZYowQM7fz8XldfD+1LwgSoPrAkPYOXnFbLrHWSjqN/vZyDFFTP9mRFVLX5pCo2nVFlHRHQ9M4BxP+1V4sSVzzKWtO/LVYhQIYxTY/zF1AJVzrViWN+zQq4vV3e+fTp76hSuWOAbBd0fnDWG0chQGEnxVwZ8gyTY4haeUJT5G3HI6tKi5LmSive7obeQn6gzTk8Is0HbAK6wWqDhC+TYzUBuA0Sz81r+VoPnoccm79t+fC3DqQp5Fd9XoQsq9M5kZwn4bdSNHw02Onj1JqvKzvKGF5dyunFdYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 5 Aug 2023 at 19:49, Andy Shevchenko wrote: > > Sparse is not happy to see non-static variable without declaration: > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static? > > Declare respective variable in the sprintf.h. With this, add a comment > to discourage its use if no real need. > > Signed-off-by: Andy Shevchenko Acked-by: Marco Elver > --- > include/linux/sprintf.h | 2 ++ > lib/test_printf.c | 2 -- > mm/kfence/report.c | 3 +-- > 3 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/include/linux/sprintf.h b/include/linux/sprintf.h > index 9ca23bcf9f42..33dcbec71925 100644 > --- a/include/linux/sprintf.h > +++ b/include/linux/sprintf.h > @@ -20,6 +20,8 @@ __printf(2, 0) const char *kvasprintf_const(gfp_t gfp, const char *fmt, va_list > __scanf(2, 3) int sscanf(const char *, const char *, ...); > __scanf(2, 0) int vsscanf(const char *, const char *, va_list); > > +/* These are for specific cases, do not use without real need */ > +extern bool no_hash_pointers; > int no_hash_pointers_enable(char *str); > > #endif /* _LINUX_KERNEL_SPRINTF_H */ > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 5adca19d34e2..cf861dc22169 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -39,8 +39,6 @@ KSTM_MODULE_GLOBALS(); > static char *test_buffer __initdata; > static char *alloced_buffer __initdata; > > -extern bool no_hash_pointers; > - > static int __printf(4, 0) __init > do_test(int bufsize, const char *expect, int elen, > const char *fmt, va_list ap) > diff --git a/mm/kfence/report.c b/mm/kfence/report.c > index 197430a5be4a..c509aed326ce 100644 > --- a/mm/kfence/report.c > +++ b/mm/kfence/report.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -26,8 +27,6 @@ > #define ARCH_FUNC_PREFIX "" > #endif > > -extern bool no_hash_pointers; > - > /* Helper function to either print to a seq_file or to console. */ > __printf(2, 3) > static void seq_con_printf(struct seq_file *seq, const char *fmt, ...) > -- > 2.40.0.1.gaa8946217a0b > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20230805175027.50029-4-andriy.shevchenko%40linux.intel.com.