From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3E3C433EF for ; Mon, 28 Mar 2022 12:49:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A56868D0002; Mon, 28 Mar 2022 08:49:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DECF8D0001; Mon, 28 Mar 2022 08:49:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857AB8D0002; Mon, 28 Mar 2022 08:49:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 6F5D58D0001 for ; Mon, 28 Mar 2022 08:49:53 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 20D0D182888A9 for ; Mon, 28 Mar 2022 12:49:53 +0000 (UTC) X-FDA: 79293777066.16.7AB42BA Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf11.hostedemail.com (Postfix) with ESMTP id 6B42C40019 for ; Mon, 28 Mar 2022 12:49:52 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id m67so25797988ybm.4 for ; Mon, 28 Mar 2022 05:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KUChceqjpLh79J1JQFAPdmmRt16+9BpF6Er6lqRNHnM=; b=maVnbV2w40X+zie6c69eqLTkE3mwOUCUKhLqXBM5TBtY9izg4Mq9EndXyXXEQDihlh ZkHfQxiXaMnhMMdwDip1XvXuXZ7ScmQWwvW/WZQeLwjDehz04SIA0Ts+EVjB4nTnD9zY 7qeGSbRUBvHUdRHrzr8HhPZS/KY/7z1Z4aJuEZk+h1bMGQI2ZfeNP62Tnf+mP1RdkNZI VYV4ZO4V7TaAtGhl6djHJPtYZdb1sPVykMZJnfQdgxzWJOnKYF2FqcxBzsvKOcBy6XT4 YATWrrE48W/6FFVW6LvoILUNa6ehaETUCpNtc9VYgS0vVTZ8K6cpbZ/zWsU59pvw5j67 zS8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KUChceqjpLh79J1JQFAPdmmRt16+9BpF6Er6lqRNHnM=; b=L5Tv5oLr6S18UzCrV7PkES4X9JRQbrB4z3gKBzDCIKqEwqxyKwah/lniljI877f+TS kM9X7n/YHoh08E73XFnHLuaKERyLcKnqfL1bgl6opJOIDoJaN9SOT0fYqVL5iXt45msk 7Em6uSfpmLg/GCP82o60OqixeB0iTUrUtIQocLz4WPVwgeZxFPGFx4b5oeJI591Xnt/k X9FLuWQdgJM8+zN9aPJUYYZYLkHDQCCSlX8QBQjQiJ+NZ8mqXV1rFMv5OEVVN+dZ6Efm EYrZMyj32LZnkvbHPYO2/EfFSkMK9lGEqtRPx0zmeNTsP57vZJB84E4t48aUgskFhR7m 17pw== X-Gm-Message-State: AOAM5339XBRR3gXRv36BG2vJa7KRfj13Gnn9tgjVKljnlvVyi61/ghOS jS5EVGTZUwQ2HpqGRmT5pi6kqALR+XGHq7e/U3zxfg== X-Google-Smtp-Source: ABdhPJz/nC8Q3dmMv0pTY0Bqml7jS4vWoZHU6q7UKQKSEbGR6IHs4zmkgJSlmMqGUOmtHm2Y9W1Xg3JOt85G5SRnmEo= X-Received: by 2002:a05:6902:24f:b0:62d:69d:c9fc with SMTP id k15-20020a056902024f00b0062d069dc9fcmr21590325ybs.87.1648471791406; Mon, 28 Mar 2022 05:49:51 -0700 (PDT) MIME-Version: 1.0 References: <7027b9b6b0cae2921ff65739582ae499bf61470c.1648049113.git.andreyknvl@google.com> In-Reply-To: <7027b9b6b0cae2921ff65739582ae499bf61470c.1648049113.git.andreyknvl@google.com> From: Marco Elver Date: Mon, 28 Mar 2022 14:49:15 +0200 Message-ID: Subject: Re: [PATCH v2 4/4] kasan: use stack_trace_save_shadow To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Catalin Marinas , Will Deacon , Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mark Rutland , Vincenzo Frascino , Sami Tolvanen , Peter Collingbourne , Evgenii Stepanov , Florian Mayer , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6B42C40019 X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=maVnbV2w; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of elver@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=elver@google.com X-Stat-Signature: cbpjyssw5ewmdugj3gm4x6i5zx5r4y8f X-HE-Tag: 1648471792-901290 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 23 Mar 2022 at 16:33, wrote: > > From: Andrey Konovalov > > Now that stack_trace_save_shadow() is implemented by arm64, use it > whenever CONFIG_HAVE_SHADOW_STACKTRACE is enabled. This improves the > boot time of a defconfig build by ~30% for all KASAN modes. > > Signed-off-by: Andrey Konovalov > --- > mm/kasan/common.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index d9079ec11f31..8d9d35c6562b 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -33,10 +33,13 @@ > depot_stack_handle_t kasan_save_stack(gfp_t flags, bool can_alloc) > { > unsigned long entries[KASAN_STACK_DEPTH]; > - unsigned int nr_entries; > + unsigned int size; Why did this variable name change? > - nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 0); > - return __stack_depot_save(entries, nr_entries, flags, can_alloc); > + if (IS_ENABLED(CONFIG_HAVE_SHADOW_STACKTRACE)) Would it be more reliable to check the return-code? I.e. do: int size; size = stack_trace_save_shadow(...) if (size < 0) size = stack_trace_save(...); > + size = stack_trace_save_shadow(entries, ARRAY_SIZE(entries), 0); > + else > + size = stack_trace_save(entries, ARRAY_SIZE(entries), 0); > + return __stack_depot_save(entries, size, flags, can_alloc); > } > > void kasan_set_track(struct kasan_track *track, gfp_t flags) > -- > 2.25.1