From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24BD7C433F5 for ; Thu, 5 May 2022 07:20:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 453AB6B0071; Thu, 5 May 2022 03:20:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 404B06B0073; Thu, 5 May 2022 03:20:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A55B6B0074; Thu, 5 May 2022 03:20:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1B7246B0071 for ; Thu, 5 May 2022 03:20:09 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E54352CBDF for ; Thu, 5 May 2022 07:20:08 +0000 (UTC) X-FDA: 79430840496.31.2D190BD Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf01.hostedemail.com (Postfix) with ESMTP id DC10C40096 for ; Thu, 5 May 2022 07:19:59 +0000 (UTC) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-2f7c57ee6feso39314817b3.2 for ; Thu, 05 May 2022 00:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+4pwyCdtrN8skjkL3vLrOUo2V3SJhrVEC+DpJFR51tI=; b=h8tmaFlRX8/Tss0bkURxHOUEOLsbjRHmcdCam7Byv5CvV5wpZ8uc0/lEegLvga7O9T srDENjfNKgZ2j+yUIyopyryfabK6A5EfpnumfHgGXN2Z7qldNA2Vl3ZeqC4SJwMAraWY QSycz28a/w7qlp20rcCFYmvS74J+z+uLzrmgvqEjPWmX/IfC58WXclVsIKpuz+p+lDWf U8Lx1iTi1GmC90VgOK3OGxXimXP6OpuPDsbjHiDbvD5lCjPiNxMK/kvMCEkqPg2o+Liz Ab57k+HBhCQKsaE9ESVF3Fl51tN2qsNlJMeq91Tw8XPIH4eQMNMa6nNSIghe7vmT+C+B /cbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+4pwyCdtrN8skjkL3vLrOUo2V3SJhrVEC+DpJFR51tI=; b=xPgqXSriKXr/H0czYFoELma6qg1s/L3643onmL110I8tHlM1cnT1cLlwDzOPOKJ7vl 2z3ZmKkW8cauyzLnKf/Ne3Pr+ObieIrybEnL2QGJPI8BoyLk62zU6pzZqSAB0YVa/2dR 9EpJ2A6mVoCTwa4MZHAuaRVKLiKQ+8Vx/cuGkw4dE2MLag6QNX4XkRiWLhMxWly7Z7/i ZENvutqDZP8UonlazqB7+kKr5sB4fEYo6R+tBiGeAi0oAQWXdMLoML0/Fh36Kkd4l37P JmsSZKaagQpmDTQIrRZzxgInohDfb8bJ+s7r65iC9+EfNLw2+09J8TpMhMPRxg2gbyTd 4L4g== X-Gm-Message-State: AOAM531+P7BxJg+/gonigk4mJNViC8L6tdINNWvTcDO5vqIwg30EGAPx 7x23kuPhGBaGsIInQN/4ifrc9Wug4dJeZ/J87VYHJQ== X-Google-Smtp-Source: ABdhPJywLXQgFtVLlJSm6LvNWhnseLHqOe2Yo9wmkm5Fl9mdjiJiLCR/gHb1szDME1GXMKPYqZArn7fCDBMHSqsjjXY= X-Received: by 2002:a81:4e83:0:b0:2f8:f7d3:2c71 with SMTP id c125-20020a814e83000000b002f8f7d32c71mr18383971ywb.264.1651735207601; Thu, 05 May 2022 00:20:07 -0700 (PDT) MIME-Version: 1.0 References: <20220505070105.1835745-1-42.hyeyoo@gmail.com> In-Reply-To: From: Marco Elver Date: Thu, 5 May 2022 09:19:31 +0200 Message-ID: Subject: Re: [PATCH] mm/kfence: reset PG_slab and memcg_data before freeing __kfence_pool To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Muchun Song Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=h8tmaFlR; spf=pass (imf01.hostedemail.com: domain of elver@google.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DC10C40096 X-Stat-Signature: uts1a9xx3nox8pbuihsjy83sh96648ni X-HE-Tag: 1651735199-755322 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 5 May 2022 at 09:12, Marco Elver wrote: > > On Thu, 5 May 2022 at 09:01, Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: > > > > When kfence fails to initialize kfence pool, it frees the pool. > > But it does not reset PG_slab flag and memcg_data of struct page. > > > > Below is a BUG because of this. Let's fix it by resetting PG_slab > > and memcg_data before free. > > > > [ 0.089149] BUG: Bad page state in process swapper/0 pfn:3d8e06 > > [ 0.089149] page:ffffea46cf638180 refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x3d8e06 > > [ 0.089150] memcg:ffffffff94a475d1 > > [ 0.089150] flags: 0x17ffffc0000200(slab|node=0|zone=2|lastcpupid=0x1fffff) > > [ 0.089151] raw: 0017ffffc0000200 ffffea46cf638188 ffffea46cf638188 0000000000000000 > > [ 0.089152] raw: 0000000000000000 0000000000000000 00000000ffffffff ffffffff94a475d1 > > [ 0.089152] page dumped because: page still charged to cgroup > > [ 0.089153] Modules linked in: > > [ 0.089153] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G B W 5.18.0-rc1+ #965 > > [ 0.089154] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014 > > [ 0.089154] Call Trace: > > [ 0.089155] > > [ 0.089155] dump_stack_lvl+0x49/0x5f > > [ 0.089157] dump_stack+0x10/0x12 > > [ 0.089158] bad_page.cold+0x63/0x94 > > [ 0.089159] check_free_page_bad+0x66/0x70 > > [ 0.089160] __free_pages_ok+0x423/0x530 > > [ 0.089161] __free_pages_core+0x8e/0xa0 > > [ 0.089162] memblock_free_pages+0x10/0x12 > > [ 0.089164] memblock_free_late+0x8f/0xb9 > > [ 0.089165] kfence_init+0x68/0x92 > > [ 0.089166] start_kernel+0x789/0x992 > > [ 0.089167] x86_64_start_reservations+0x24/0x26 > > [ 0.089168] x86_64_start_kernel+0xa9/0xaf > > [ 0.089170] secondary_startup_64_no_verify+0xd5/0xdb > > [ 0.089171] > > This is probably: > > Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure") Hmm, looking closer at the above BUG, I think it's Fixes: 8f0b36497303 ("mm: kfence: fix objcgs vector allocation") ? > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > --- > > mm/kfence/core.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > > index a203747ad2c0..2ab3d473321e 100644 > > --- a/mm/kfence/core.c > > +++ b/mm/kfence/core.c > > @@ -642,6 +642,13 @@ static bool __init kfence_init_pool_early(void) > > * fails for the first page, and therefore expect addr==__kfence_pool in > > * most failure cases. > > */ > > + for (char *p = (char *)addr; p < __kfence_pool + KFENCE_POOL_SIZE; p += PAGE_SIZE) { > > + struct page *page; > > + > > + page = virt_to_page(p); > > #ifdef CONFIG_MEMCG > > > + page->memcg_data = 0; > > #endif > > > + __ClearPageSlab(page); > > We're now using __folio_set_slab(), so I'm guessing this should be > __folio_clear_slab()? > > > + } > > memblock_free_late(__pa(addr), KFENCE_POOL_SIZE - (addr - (unsigned long)__kfence_pool)); > > __kfence_pool = NULL; > > return false; > > -- > > 2.32.0 > >