From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C68C433F5 for ; Tue, 21 Dec 2021 12:19:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F8AA6B0074; Tue, 21 Dec 2021 07:19:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A85F6B0075; Tue, 21 Dec 2021 07:19:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 449B66B0078; Tue, 21 Dec 2021 07:19:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 370CB6B0074 for ; Tue, 21 Dec 2021 07:19:58 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F3C4389078 for ; Tue, 21 Dec 2021 12:19:57 +0000 (UTC) X-FDA: 78941708034.31.B55AAD6 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf09.hostedemail.com (Postfix) with ESMTP id EB33B14002E for ; Tue, 21 Dec 2021 12:19:52 +0000 (UTC) Received: by mail-oi1-f170.google.com with SMTP id w64so20570392oif.10 for ; Tue, 21 Dec 2021 04:19:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BaXR+Sf/o4pHq2K7zFqOPHm0HQk54kBEfN6/GC5fgeM=; b=DOY8PDnOLcMR8fY8k4rMeFeCw7xBBFK3OPAE/n+xtb8qDFv9JkNk3LZbYjMxSp9Kr/ LN+Kgfkxy81v9dusGxkmzUFNm8E70Ly1GdWreagXAuCygdufarJbRI0BYaGpKjyNtKVm fcs6Nr4Dx4+k2Ft9cxJL8HkFmQSBrjkGt7mRlv+ODuxymPHHSAKkyo+d65Q5ur8dZtuR c5pim4OMXxIgsJJmBOFqJJe6VYugNfMHha7zuSla8xEq1khHiCctmEw6R2vpPUfoR/0z MLWB1XzrewUW/h8hIweXJDtWOqIalVXR+sc4Ky4KTcKSYKVVmRi3Oio8WbCCUpw3w2xb 5VRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BaXR+Sf/o4pHq2K7zFqOPHm0HQk54kBEfN6/GC5fgeM=; b=qZBIWb9Xx1IqyXHH9gheTPNlTa+cCCPUCS2xAV0TAPl1S3siWIz++9S+xcpG3f55r5 qB5wSIs0U1Qf/Vi9QUxnZmE8cujZM7nyJjoFRuo9+E7Hdp+e2sA56WYWYgd2XB/VjoRa 5xq29JaP8Ug7TdTKLlgGf5CfJsq5pDP5ZOr91bi15oznmgAaEDbjrX64Z5GBSn5cTzKn lFNI61njatv6Q3SvXMnXO7F72n+NSDYefagFuk7vm2EVt/1lXk2N/pdT3DPJIZyTN0yy /jhtBoLWSbzncEi5a7nCmvRCi1GUjkwqz0b1im57n/gK5GR0Dj2QrZFatJ4osv9g/DxP Haog== X-Gm-Message-State: AOAM5314NhvM7kOOU+ZpWZG7SZE46wLyoP2oS5AmjKMULBi/S3q8fKbZ c+DBfmO5E7hcnaAndbYV2PTBKBsUJ+fs+M/BiEG4kg== X-Google-Smtp-Source: ABdhPJxBX/Gkn5yNgs1quOEw+mGlZ7jRH4P8oW8i+xSqTHpBDQPz/PzlNjgclCi6wHGOYn03vA+wj3XaqwTIXkiJN/g= X-Received: by 2002:a05:6808:1903:: with SMTP id bf3mr2240565oib.7.1640089196762; Tue, 21 Dec 2021 04:19:56 -0800 (PST) MIME-Version: 1.0 References: <73a0b47ec72a9c29e0efc18a9941237b3b3ad736.1640036051.git.andreyknvl@google.com> In-Reply-To: From: Marco Elver Date: Tue, 21 Dec 2021 13:19:45 +0100 Message-ID: Subject: Re: [PATCH mm v4 28/39] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Peter Collingbourne , Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EB33B14002E X-Stat-Signature: yt3kf6atzxd83qwxrwo6mwx16onbyosn Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=DOY8PDnO; spf=pass (imf09.hostedemail.com: domain of elver@google.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam10 X-HE-Tag: 1640089192-898377 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 21 Dec 2021 at 13:14, Marco Elver wrote: > > On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote: > [...] > > +static inline bool should_skip_kasan_unpoison(gfp_t flags, bool init_tags) > > +{ > > + /* Don't skip if a software KASAN mode is enabled. */ > > + if (IS_ENABLED(CONFIG_KASAN_GENERIC) || > > + IS_ENABLED(CONFIG_KASAN_SW_TAGS)) > > + return false; > > + > > + /* Skip, if hardware tag-based KASAN is not enabled. */ > > + if (!kasan_hw_tags_enabled()) > > + return true; > > Same question here: why is IS_ENABLED(CONFIG_KASAN_{GENERIC,SW_TAGS}) > check required if kasan_hw_tags_enabled() is always false if one of > those is configured? Hmm, I pattern-matched too quickly. In this case there's probably no way around it because the return value is different, so not exactly like the should_skip_init().