From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4307BECAAD1 for ; Wed, 31 Aug 2022 07:36:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BDC48D0001; Wed, 31 Aug 2022 03:36:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5458D6B0072; Wed, 31 Aug 2022 03:36:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C0408D0001; Wed, 31 Aug 2022 03:36:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 275236B0071 for ; Wed, 31 Aug 2022 03:36:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E37B91A0B65 for ; Wed, 31 Aug 2022 07:36:36 +0000 (UTC) X-FDA: 79859080392.21.30DAECC Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 8697D40023 for ; Wed, 31 Aug 2022 07:36:36 +0000 (UTC) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-32a09b909f6so300188427b3.0 for ; Wed, 31 Aug 2022 00:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=CiwUOjsI8eLOGXg0PzvmS8sm5Q3oJ41Lwox9FPpug3M=; b=aVNtNvuFOVy6N3b8sJdleN1RdMaRP53HgZXTgItA0o/Zf0MWpSDVHN7VbgsZS3s9t8 my7Moqv+15aIRycxY725FQvci9HGMV9V44BF7dondknbLw3pFKSPCwYfAh4R0+1o8UWq f9RfEIgOw5RgZmGd+t7myvmD7ItZClQp0DTVSguKtWjihqDg5GfeoE3Ll3n86euJO39K Zu+q7KQZ1ZzAcZYQ5k1haVPMnIhbBBEYB0wHIsU8IbzEMJaS4gY1p2hs9CMJNn1PXzzi FKY+HmMJmsvhaFRUxRXW+btNwQX2/0ET2wRaB/rlK1nxFJDqSeaQ+wIr2o+Ezi0FzMDX LA9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=CiwUOjsI8eLOGXg0PzvmS8sm5Q3oJ41Lwox9FPpug3M=; b=fM4tcxUwKSk/A1vP8LaP/An5rHVDSSmaJbY7c0mJrQ4BQSwXfIH2BiMI0Thc759fN+ O1jqLjtSoKXzImk+OmT+qsk+FMbEi7JUSqTCOMfWdNJCa+uHrHXk+Y//lMhigi51m4e5 JqdlAUgLTVTm5wAQBhFgE0D0V5Jak7HC7D/s3oMFVEarZ7BHu9yp8zs4T7FATBJD6whE FYu071EF5GZKItI49+zPFIVmxxXjVbAOtSMzv9p088ueBzqHVPqaQqHAhNWId/NCDE+e mdWbjG3C75Mt47TrleJDWp63TQV7fpRr9nbByJJ5Wkso7dBbb+kGrHSc77u8FnBowRF+ IqFQ== X-Gm-Message-State: ACgBeo0Kw75uTSf8/X17zZ651jEl2WIULIWPHFkmT/0DFpp0uy9JPeLX 1nODtmAXw6QtWesJB3hLQloon3poeXGip/8YyH3loxH8hzE= X-Google-Smtp-Source: AA6agR6G+//JqvOdxE+rvJWBsqG+4mERL9g4bStF306N2P0NY4ZQrO4/+N/t7QSFDmIUcNsrs9ODL6M8mSNkdDRFBkM= X-Received: by 2002:a81:4a04:0:b0:33d:ad51:8efb with SMTP id x4-20020a814a04000000b0033dad518efbmr17956723ywa.86.1661931395663; Wed, 31 Aug 2022 00:36:35 -0700 (PDT) MIME-Version: 1.0 References: <20220831073051.3032-1-feng.tang@intel.com> In-Reply-To: <20220831073051.3032-1-feng.tang@intel.com> From: Marco Elver Date: Wed, 31 Aug 2022 09:35:59 +0200 Message-ID: Subject: Re: [PATCH -next] mm: kence: add __kmem_cache_free to function skip list To: Feng Tang Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661931396; a=rsa-sha256; cv=none; b=gn8MixHdV5QK3Ud0o6rNZPgLSKdSqXUvV4ocj3eoX7FRVzZxgAmZMa3P/qh9EGLsCwi9Ls 1mKhINZ9NimN8j/uyy/paZ9gfTnWKwaEB+9CoD8RJzaooKdYk9MPqmBzwbHQIKlQSN1aeK obyt7y9cYMZrNS16Zee0pbizrQKMrbQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aVNtNvuF; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of elver@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661931396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CiwUOjsI8eLOGXg0PzvmS8sm5Q3oJ41Lwox9FPpug3M=; b=laMNSUjqDpU51n5K9yGVI9s4l7/8eNhGc6o6+AzrwN5v5kQf/l3SzzYaXF0c1Y1IHFG/tF AI8NX5R4cj5Fe8/KdCbxqZRLjm7VGk93yWvEcFd3B1kK4zLKrWPn7ulul4z568+W0yjjmB 8EVpEhCc8qj/F/R8nHi4fWVTtOqX9Cc= Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aVNtNvuF; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of elver@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=elver@google.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8697D40023 X-Stat-Signature: sbm3heeu5157hrtjuq6x4qy4edjaij1i X-Rspam-User: X-HE-Tag: 1661931396-249475 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 31 Aug 2022 at 09:30, Feng Tang wrote: > > When testing the linux-next kernel, kfence's kunit test reported some > errors: > > [ 12.812412] not ok 7 - test_double_free > [ 13.011968] not ok 9 - test_invalid_addr_free > [ 13.438947] not ok 11 - test_corruption > [ 18.635647] not ok 18 - test_kmalloc_aligned_oob_write > > Further check shows there is the "common kmalloc" patchset from > Hyeonggon Yoo, which cleanup the kmalloc code and make a better > sharing of slab/slub. There is some function name change around it, > which was not recognized by current kfence function name handling > code, and interpreted as error. > > Add new function name "__kmem_cache_free" to make it known to kfence. > > Signed-off-by: Feng Tang Reviewed-by: Marco Elver Thank you for catching this. > --- > mm/kfence/report.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/kfence/report.c b/mm/kfence/report.c > index f5a6d8ba3e21..7e496856c2eb 100644 > --- a/mm/kfence/report.c > +++ b/mm/kfence/report.c > @@ -86,6 +86,7 @@ static int get_stack_skipnr(const unsigned long stack_entries[], int num_entries > /* Also the *_bulk() variants by only checking prefixes. */ > if (str_has_prefix(buf, ARCH_FUNC_PREFIX "kfree") || > str_has_prefix(buf, ARCH_FUNC_PREFIX "kmem_cache_free") || > + str_has_prefix(buf, ARCH_FUNC_PREFIX "__kmem_cache_free") || > str_has_prefix(buf, ARCH_FUNC_PREFIX "__kmalloc") || > str_has_prefix(buf, ARCH_FUNC_PREFIX "kmem_cache_alloc")) > goto found; > -- > 2.27.0 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20220831073051.3032-1-feng.tang%40intel.com.