From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE30C678D4 for ; Fri, 3 Mar 2023 15:01:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BBB76B0075; Fri, 3 Mar 2023 10:01:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 344F26B0078; Fri, 3 Mar 2023 10:01:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E64B6B007B; Fri, 3 Mar 2023 10:01:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 072666B0075 for ; Fri, 3 Mar 2023 10:01:08 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C012B4120E for ; Fri, 3 Mar 2023 15:01:07 +0000 (UTC) X-FDA: 80527899774.11.C8FCA3B Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by imf14.hostedemail.com (Postfix) with ESMTP id BECD810003C for ; Fri, 3 Mar 2023 15:01:05 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bnJsE3al; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677855665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/aydHlOGXKxNYbYaenvW8HmCoQRPXb5oRnbMkROWhOQ=; b=15Oa9A5FBGDCJpWlbgand6gxeFVPQMO5MFJIfkA/Oo2xEd0CLEn+8BNwt0Wj4uEPyV9Sdi 3hgrdm10zwDU29SKDtlxIFiuQSwIDPxXaHoOmb2GIn+jNIvtbBPx3ah6Vjx0rkfER6fIUZ C/E5oDPTUowm6LeTpAVqsDEPPy2TumM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bnJsE3al; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677855665; a=rsa-sha256; cv=none; b=w2sYndPW+KuxtzPw9bCnUGdKSXpiF0Nv9d0fecb5bS0EopC6xcDJT717NavFeAB6UxCVbT 1pUXnz1BXOiDlVX1Cl6ymMJminnA8HHownVOWWxiEhVAcgPNE8oav24EuqKQuodwq2A0Fv u7mfryJzvma5Avj/3RsCpIUxi67wOUQ= Received: by mail-vs1-f54.google.com with SMTP id d7so2641067vsj.2 for ; Fri, 03 Mar 2023 07:01:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677855665; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/aydHlOGXKxNYbYaenvW8HmCoQRPXb5oRnbMkROWhOQ=; b=bnJsE3al7F/RO9m51MPgi2ERltvgIHmY3BwnOpTMfY8okcF+CuyqyoOGVgeMv0E01h HXpdUM2aeqqCi1Vbkh8+g7Fr8BM8dLYuuFaUoT21xoq/nSPjMAPV9YjIyQbO2/ipcZji tZEwk3QzrA0BWGSofmiip0gUnJqLgUr7ddsPMG6KhBe7ExO1z9FIrDyEER4HkpL5Blx5 pMwQHBD+Fje/n64jMGXBo4rCOorK+FwanBW6qivMWH4CGBLQ4KtI6XUC0PLI2QpdFNzp biSQIXpAPbJwe6UWiMKTk7/uj3AzMgDwq7Sr9jgtP1dECB9i7miICAeuG+DAod09GLYB iYOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677855665; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/aydHlOGXKxNYbYaenvW8HmCoQRPXb5oRnbMkROWhOQ=; b=DRohxISA3Hom9JQ037yN/VJIyhlxJMlab5mTUk1buKR+vGhCh6trBFC9zN1Ssrfuii nOMYPkTcKUh2M1XYGXfwReg6kEjbsQ2akJDKE41I1PAiPGO2mXsUNE+rYRuzH6nQoBkV q9CTVUIGqN2vT3eb+56q//w7FuVQSYZAVq4/rVUnn5e0+FgwzEca7GB6yq1N9ZRU379f HuwyAS3XLjYVbY+UPyVcJ3hfdGC/sqb/zXk/IXpSRtMHFSXLDqluBAd35UM3sOJxfAcg noBbAygqm2J6C+HE2E/hL4GZRzPpXKty7xI5OiwsvqK0aEZd8K2sN7wig75iFvo+YCT+ 4K8w== X-Gm-Message-State: AO0yUKXKf9vSmCIG3HEM0VArsbGQFvC7nnblP128D8NqmTniTSkkyZ13 pWNq0pZ/SyUvVpqKxsNES47j2yoJaXY/cufWLN/ZHw== X-Google-Smtp-Source: AK7set/RkZE52X8hXrT87mL7tsH8Ud2NJPTAIssq3Zbq99pa0twgioMqqdfGMF7xbJEDXUOP/f22VTcdwXuLy5dfT88= X-Received: by 2002:a05:6102:243:b0:415:82c8:8753 with SMTP id a3-20020a056102024300b0041582c88753mr1347560vsq.1.1677855664805; Fri, 03 Mar 2023 07:01:04 -0800 (PST) MIME-Version: 1.0 References: <20230303141433.3422671-1-glider@google.com> <20230303141433.3422671-4-glider@google.com> In-Reply-To: <20230303141433.3422671-4-glider@google.com> From: Marco Elver Date: Fri, 3 Mar 2023 16:00:28 +0100 Message-ID: Subject: Re: [PATCH 4/4] kmsan: add memsetXX tests To: Alexander Potapenko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, akpm@linux-foundation.org, dvyukov@google.com, nathan@kernel.org, ndesaulniers@google.com, kasan-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: BECD810003C X-Stat-Signature: 3wrkf5o755b8w6fi81pat6d3fqehmg67 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677855665-745715 X-HE-Meta: U2FsdGVkX1/sHpkxTQl2OK4yT1EziQCsH6cX+NNyzDyEId++CvTOEFr+PDBcRWhdG6vNxArFTgCpLz3f1cLtMF9bvcqJ7xWQEbJWSFQ7cZrGTX0SLlKf3HfV8sQ8JPrYafcIL1pKB49sjXR+ijJUlcrHtByBKCxRgAfDOwYUsvmPvaeZUZJRxgqXbBDcAkBhPC67Lhn0Vgpo+DIjnkxc/3bO5ivfcB5aReYBHgCHN+v/8QgHJwZ1HTRhd8bwGM3BZ92nGd8TuupdbaNJfYDR4Y2aNtmcOZiRp/KHVHeGKoPTT4Oq3wm6N7Baswbh8xSA5AU1/F37u10n1Oew39nOtlFf8eovR08GopMhtit/h0JO6mStoRZ/tJFGTPy8ZQ5jh9bHSnCiwMsgGz9iCvFEm3N7HUb0eopEs3PwHTGcKE+4J6Q/DJdleZFm3t/cv9SBO4szN0VTF479ajiDLPWciEb3jCzi9tYuqdf9OOswL1DkLPg/S1p1xDs+d7BKP2INKz1Gj1t9ykNusccNBmv4Qz5xnYVh8mXHJrkbQpLGcJQJYDZAKun0sP3k0wt0HDAhTZmDXkiytmjDgVEgwT8NZBKZTdQ2dX//tGpl3oqgBoxfIuKF/Zf71KVATDQ2oilRBJ9Z0mMaeGE9Ddyz4OOdloieWd2w/hUbtnSWZmDUCc5GG/12q2TVHJMpe6/dwHQmmL0sPQSuGdmsInibRNaKQzL3ZZ9fsp3/fYXZW0VF4/lMpPJY1cBl2LSzMZ0nssjPe7XtLOGxW9hiSzdbEU0x6CAeblnCuiao/7I6aE0RGVZdFHtoR70W1Pc9nZFPmBTOM6dpqpcX8Q3EovC7KRuzbUe1RIWRiycfQ8gnMeONEggCYuQ0/+kAnt/2QYC1baTC9VBSP8xVYN5XjpJVMCP7z8Zn0DgxWMbJNtZQBbAFdCfdxCGZCsLVMT1xjeTdsK2fPf3Gq/HVqYAb7/ZYi2o 9/pOG8g8 jKhZ6uhs7DQn/0aCL98MIqUrz0Q6gzFHNtEWkHEdO1FUMvALZbHPHzZv00Q2EMqYGGG9RfTu4z8+HPRC/FUC2zfqgqX8m6UxGd8uXqqrrklsxwaEzPV6L1qpsFVX6jhSvFWsDGXoxw6yYsQ/HkNSt4bmFCVkcA2AYpBbSEHR0iOPrBFJS2/kPbTqU+4hATBVWiNhmVl3y6N19+l4UaGo+owRrPn3gupfAa+VoTQQv3ut3wNDC9DKtNcpzhjESA9rpfO4o72FJcg1xKXCt4X8T/WxB8Bk3am9iWGNTZ1YW3XjQr2D7W/v1Ft/mdGg2Ln6Qy19s/BsY7egnVmPVeTBrUt5F5xvalbDOKH2rFqvR4b8ev/mfpRCwd4RhgqFmgAvnW/Pc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Mar 2023 at 15:14, 'Alexander Potapenko' via kasan-dev wrote: > > Add tests ensuring that memset16()/memset32()/memset64() are > instrumented by KMSAN and correctly initialize the memory. > > Signed-off-by: Alexander Potapenko > --- > v2: > - drop a redundant parameter of DEFINE_TEST_MEMSETXX() Reviewed-by: Marco Elver > --- > mm/kmsan/kmsan_test.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/mm/kmsan/kmsan_test.c b/mm/kmsan/kmsan_test.c > index aeddfdd4f679f..7095d3fbb23ac 100644 > --- a/mm/kmsan/kmsan_test.c > +++ b/mm/kmsan/kmsan_test.c > @@ -504,6 +504,25 @@ static void test_memcpy_aligned_to_unaligned2(struct kunit *test) > KUNIT_EXPECT_TRUE(test, report_matches(&expect)); > } > > +/* Generate test cases for memset16(), memset32(), memset64(). */ > +#define DEFINE_TEST_MEMSETXX(size) \ > + static void test_memset##size(struct kunit *test) \ > + { \ > + EXPECTATION_NO_REPORT(expect); \ > + volatile uint##size##_t uninit; \ > + \ > + kunit_info(test, \ > + "memset" #size "() should initialize memory\n"); \ > + DO_NOT_OPTIMIZE(uninit); \ > + memset##size((uint##size##_t *)&uninit, 0, 1); \ > + kmsan_check_memory((void *)&uninit, sizeof(uninit)); \ > + KUNIT_EXPECT_TRUE(test, report_matches(&expect)); \ > + } > + > +DEFINE_TEST_MEMSETXX(16) > +DEFINE_TEST_MEMSETXX(32) > +DEFINE_TEST_MEMSETXX(64) > + > static noinline void fibonacci(int *array, int size, int start) > { > if (start < 2 || (start == size)) > @@ -550,6 +569,9 @@ static struct kunit_case kmsan_test_cases[] = { > KUNIT_CASE(test_memcpy_aligned_to_aligned), > KUNIT_CASE(test_memcpy_aligned_to_unaligned), > KUNIT_CASE(test_memcpy_aligned_to_unaligned2), > + KUNIT_CASE(test_memset16), > + KUNIT_CASE(test_memset32), > + KUNIT_CASE(test_memset64), > KUNIT_CASE(test_long_origin_chain), > {}, > }; > -- > 2.40.0.rc0.216.gc4246ad0f0-goog > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20230303141433.3422671-4-glider%40google.com.