From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71AD5C433EF for ; Wed, 30 Mar 2022 06:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E71BF8D0003; Wed, 30 Mar 2022 02:00:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF54B8D0001; Wed, 30 Mar 2022 02:00:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAB0D8D0003; Wed, 30 Mar 2022 02:00:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id AE4A78D0001 for ; Wed, 30 Mar 2022 02:00:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 66AF81828AE54 for ; Wed, 30 Mar 2022 06:00:43 +0000 (UTC) X-FDA: 79300003566.27.3DEAF7E Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf19.hostedemail.com (Postfix) with ESMTP id DCB951A0009 for ; Wed, 30 Mar 2022 06:00:42 +0000 (UTC) Received: by mail-yb1-f172.google.com with SMTP id t11so35284072ybi.6 for ; Tue, 29 Mar 2022 23:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l4H/jXM2Rm5a65oviYgvwa+04XGLXLD2DF5i6wOLQLk=; b=Vuks7XErLEhcNi2ye01c54I5fu+jCmDSOakCCznT+E5592ZGQeCDVgDLAC1Oe1j8Hc arjQm/015wC9O7r8EUYvWo1JdfnwHgit9pya3K0qKVHC8n1PrzsjO/1ililAl1IjhfQk hleVis9Kr1Qyf0mw+RYN0MImDkC2drk+l5C4qAnRAQdi2lixVi0nJFGc7a2kn+A8U/dS zFaSQ9GlIpLuif/J2hksClNYZAcORcG79/LOxU/aqKbHvarX2eDKn9oon1LeDe7mq9S6 r9U7iAxmkiKOU586S5VakC690uQgl7swxVVhVIBZJflz9IirG0tQWmocB2Fd88MovWNQ j5sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l4H/jXM2Rm5a65oviYgvwa+04XGLXLD2DF5i6wOLQLk=; b=eZ8DpQUcboMAVj4AMkFgTmZjU6q8yfuiHW+yD8oLlgaOwuhV5ejDCyyXjSWJI4vxNw HW7ucF/ecrIRRCPzS/v4CRcMfL7jZqp/KyiIFLHMYuRPEl3M1LmtMG5xHz6dTK06BiWd IJ9a9r9W7rdYBFXyllNsBWuyi77qyBNXPdFI1NqZy/bZoLL2kFw3vIWDAovo/cWtVg2/ naNs/ocpUBlNR5ZbOhfyFcIHwq346p95OO/tu6rBeUX0rdW/PmrO7xDJqm+ahC7rQqoH sKi7cPjEqfuD48t0HYztNgZUk6WVttzpDVrPO8RTIrqV5r7Y7rROIbiPma1/lsH3p672 GK5Q== X-Gm-Message-State: AOAM533o83+4UgFzDuK1qIrxmpTGVzoInTryDETMFeDVr4Bl05vq6Jzi 4VOMtrPIAtvIwTL1P7RuHWj0eCdlt8Nif53WQ5L24g== X-Google-Smtp-Source: ABdhPJz5J5Vu63dqmmJtsEsyg5gp4hpxm11sB9Wij7Lc+9+3maHYDp7YZQF7jyhRhcglPFanYfN+0YeuhYyzXVsUg9Q= X-Received: by 2002:a25:8251:0:b0:63d:662:4fcf with SMTP id d17-20020a258251000000b0063d06624fcfmr2942147ybn.533.1648620041949; Tue, 29 Mar 2022 23:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20220329124017.737571-1-glider@google.com> <20220329124017.737571-13-glider@google.com> In-Reply-To: <20220329124017.737571-13-glider@google.com> From: Marco Elver Date: Wed, 30 Mar 2022 08:00:00 +0200 Message-ID: Subject: Re: [PATCH v2 12/48] kcsan: clang: retire CONFIG_KCSAN_KCOV_BROKEN To: Alexander Potapenko Cc: Alexander Viro , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Vuks7XEr; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: sw7rcrzdpnmoxxmh4idqcgebsy6ic9hp X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DCB951A0009 X-HE-Tag: 1648620042-618954 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 29 Mar 2022 at 14:41, Alexander Potapenko wrote: > > kcov used to be broken prior to Clang 11, but right now that version is > already the minimum required to build with KCSAN, because no prior > compiler has "-tsan-distinguish-volatile=1". > > Therefore KCSAN_KCOV_BROKEN is not needed anymore. > > Suggested-by: Marco Elver > Signed-off-by: Alexander Potapenko FYI, this is superseded by https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b027471adaf955efde6153d67f391fe1604b7292 > --- > Link: https://linux-review.googlesource.com/id/Ida287421577f37de337139b5b5b9e977e4a6fee2 > --- > lib/Kconfig.kcsan | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan > index 63b70b8c55519..de022445fbba5 100644 > --- a/lib/Kconfig.kcsan > +++ b/lib/Kconfig.kcsan > @@ -10,21 +10,10 @@ config HAVE_KCSAN_COMPILER > For the list of compilers that support KCSAN, please see > . > > -config KCSAN_KCOV_BROKEN > - def_bool KCOV && CC_HAS_SANCOV_TRACE_PC > - depends on CC_IS_CLANG > - depends on !$(cc-option,-Werror=unused-command-line-argument -fsanitize=thread -fsanitize-coverage=trace-pc) > - help > - Some versions of clang support either KCSAN and KCOV but not the > - combination of the two. > - See https://bugs.llvm.org/show_bug.cgi?id=45831 for the status > - in newer releases. > - > menuconfig KCSAN > bool "KCSAN: dynamic data race detector" > depends on HAVE_ARCH_KCSAN && HAVE_KCSAN_COMPILER > depends on DEBUG_KERNEL && !KASAN > - depends on !KCSAN_KCOV_BROKEN > select STACKTRACE > help > The Kernel Concurrency Sanitizer (KCSAN) is a dynamic > -- > 2.35.1.1021.g381101b075-goog >