From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92F6CC05027 for ; Wed, 8 Feb 2023 17:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E70A6B0072; Wed, 8 Feb 2023 12:02:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 295056B0074; Wed, 8 Feb 2023 12:02:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15D766B0075; Wed, 8 Feb 2023 12:02:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 04BD96B0072 for ; Wed, 8 Feb 2023 12:02:19 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C904FA0EE5 for ; Wed, 8 Feb 2023 17:02:18 +0000 (UTC) X-FDA: 80444742756.24.CE82F0D Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf22.hostedemail.com (Postfix) with ESMTP id C8CA1C0021 for ; Wed, 8 Feb 2023 17:02:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qkdR5pkq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675875736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J6GQ6k0SpXRf+NY/XuyN7DEx4advOeWO/TlcuNhkMx0=; b=r4KrXrDO9k1hhhsqgq2ah/y16jNbPITMYaYHZGSH0fQ8+ZzF3e6WJRaM0Pz9WFaVz3DToI laW2qvtNAgIpgABDqms1Mrmov1ZdLaoY10mu8uVE2VmTENyLaxivbk2bjMiE0Z/j3xM8id aD3xdDjXo+rtr2W8bNtvVSyvM144XwI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qkdR5pkq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675875736; a=rsa-sha256; cv=none; b=ipNLHRxTmBD7UdDZZArJiwrCsd8F8E2IfBUavAXuRMLfAzFV8G4sdiIH7VTDJP9mFQPtmm c1iYjeH0bGiVQqeMzyGglBbd1RZzVs0tQ4upNIrEymigxyU6Vt83gfES89MwSeHRI0FEIL ozJgIU8WpLg7W1tbjU1dPmpa5ZyIi5U= Received: by mail-yb1-f175.google.com with SMTP id q9so1822683ybk.2 for ; Wed, 08 Feb 2023 09:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=J6GQ6k0SpXRf+NY/XuyN7DEx4advOeWO/TlcuNhkMx0=; b=qkdR5pkq6sV8hNH3YDKJ8++iTClWqw++RrBXApfqLOYQgMe4S7SF6Q5gm6WlcUFqAy EcDtnNS2/nJgxMlDyNNCpWyL4L3Y7dyQVuQycGPcFZk3C8t3IlY7aaV9uHzszL9FOrlS YVhdSnXGCHv3enJtHbWv6Hs5JMeWL4q2vi/c62FadmqIvBF+s6uDOs1h6ypjgyUks0yH dxiM7QbyvZdmqyphgiW8HEdHkt0+yTgSWPnjIIeT+4UTHy2iwuqQTQ2upvprvgDXufCh AgR72rVEXTs3X/7jqSTKT2qB1px+ihMQa7Izpe1ISycqiE4TCFxq+smYn5Ifli5ibYcv 10mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J6GQ6k0SpXRf+NY/XuyN7DEx4advOeWO/TlcuNhkMx0=; b=V3XhjIUEg0Wt434HZkh2Sskv+ZrUOQujs9Mxf0FI/cd4IO/dGDgqQjZOBPBBdJgBGj HXwib30IkVSLoUMQF2Tjcpwbrpm/eSdD1KFRfzUn8mQI/i8KngK2Q9vTC1k0MoklQotR I9RlBA4GEMu4buR4eFm+vXN+wKJ7g+H76zDv6nPKxnRlZQrpEeftXvwf+BVH91+2Kd1h ZXCY/X4ffX9rFQf/+SrLO7e5ndTHWFHGnQhqcriDFf7wtwoJiUPEj73hcuIN4ewHJHX1 ruxj2EJHRiKDwHjQRtTqsxHePgFi3C3SGxC0CAvG1n/Dqn+MVqskTddnVV1DAfv4GukQ 7Zpw== X-Gm-Message-State: AO0yUKU3AZoOnsEfnkvgSOj1YJ55wuRiElAihlGhRbjhZ3LKXy9zlF9P 2ZMkDGt0HhvxonwEWF+JnH4n0iTTD2kqFafv2rWkcw== X-Google-Smtp-Source: AK7set8Afj6wAQvyLOzq7FCZwVWe6hcVYmC9OxxsiADkYMOvQvPBxVg623zz/LBUOZi51jIrZeS2oVdFwi8z8nOy5/g= X-Received: by 2002:a05:6902:6:b0:82b:1e20:3ae6 with SMTP id l6-20020a056902000600b0082b1e203ae6mr599159ybh.364.1675875735798; Wed, 08 Feb 2023 09:02:15 -0800 (PST) MIME-Version: 1.0 References: <20230208164011.2287122-1-arnd@kernel.org> In-Reply-To: <20230208164011.2287122-1-arnd@kernel.org> From: Marco Elver Date: Wed, 8 Feb 2023 18:01:39 +0100 Message-ID: Subject: Re: [PATCH 1/4] kasan: mark addr_has_metadata __always_inline To: Arnd Bergmann Cc: Josh Poimboeuf , Peter Zijlstra , Andrey Ryabinin , Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Vincenzo Frascino , Andrey Konovalov , Arnd Bergmann , Kuan-Ying Lee , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C8CA1C0021 X-Stat-Signature: w8zeu14bnfbou393xpuijmjn93ro8m7q X-HE-Tag: 1675875736-29804 X-HE-Meta: U2FsdGVkX19PUfnk7uwaxDvvymA3/GusSB75zXNggqxcCwcDa7Gi0uv8Ob7e+zUv6b/atJNp7gCDpOE4wjMget1K08l6OuxZ84sRNmYZo8HopWcGO84ZGcggvQNPf5AO+Cesz51Hw6IJggc6R72E0ee2an0b8+tAlgkhuYJQMyAWFo/TY3z0ezhVLrZpjfbtUAk1Rv4Ur0oAKlfdeuVVSympAkOrQ1EoDkJ9kFqOawpdW3AIfLR7Rcyr3lBuIF4tfpv2zp5Ro6RhwRZItWbJOMUGRkbixii4D/XEFeKG357OBBBmag+hjraIpkTDEbUUuRP8kA+C42/Tu6kdF3hcLXgEeG3xHNcxBOk+bjsU6quu6kd2QhpIpWYC92Uvaw01ugISC61Nd+/kAx/IpPT/MS05PlCKbLv1fxQpPHCkHncxZNNVOlwqyUVnCrM0qrJgcgEhz9FD/Q7cJ3SnbfE8/ZAtq7GXc6DUbdwxxDT6YtAHdC/YLyA8skA2yNbYQnguzHn7+wMoIzk5bpOM/83SkjPQedpiMEnvpFKrbvlEiD0/8FDQ2j1zGOJllGbMCsrxRWHUeKcxAmSQhtpVhU9GZFO7YGf7jGUPPh2PTLJPWAG79Q23zYaT/2m/7njQnW3WXTmXsHNYxUvRdigsUBDFpZAXloNOv+Go6v/4tAh4Y09ULClzO5fk6A/5zbf8y7+qqtNIm01EKxUiy86CcS06tX+mu0Q9zsy0PVwcE9QFjvryrHkVeZ+gm9GKSqwNzH+I922iEkR+7MLfvshPNB3U2Q3Tq9FMgXGuq1zqGxL9zwFhCccNg4WTjsSFJ03dR0EErvHO0goPDaMvYqkpB00PFdoS3oB5DpUc2oHoZdU4Hf1S2zQFlpsDmQQwDM4Quuf89+tcxGdvdizbE3nEmsGoWyjaeB5QHzZTqS3AmhJ9iE0njNUjPz52MoxUhu/b331fuCEOLlafFoCZVfbJ6Uq sKgNgXB4 pz3unS6skgQJ4fYIjYq4bh0CvBK/1GXDO0OhbeLYQuHPkQwYVn8RrEXGIlYQT5FGBxCUcBLIUdctR4Eh87qHazfbUEwrxN8y3C6GRuba3Y0jB8gJP6lFZL7t5qO4pP1wO3FR6WolgYEchR/eDFFMHcE8vULQiCjS+hFoqNTbVcANXdBA1AnLCYNX6pSeKLz3UhCugz77hU1wpgINKBkV977lZdYi5e8ALnZmUberIIfGBIYaarFnXIArZ4CvF1RbBmQ4SUUF9n9+guDS06LBrJgwC0nEJ3XE+UFF6sUQJCeFXx9Sngbqp9fbhl2px4PbvCXreQEVatN0JQxlWsBzSgAlmmO24ObRK23d55qwewfT/LAXP9GejSwleYNAROOOW3XPIbMeVQFj9gD9jQvc5X+Z5FjBGIavtr9gvtJ65CK+wmbPn7Z63yENTsf8iWp8r5k2V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 8 Feb 2023 at 17:40, Arnd Bergmann wrote: > > From: Arnd Bergmann > > When the compiler decides not to inline this function, objdump > complains about incorrect UACCESS state: > > mm/kasan/generic.o: warning: objtool: __asan_load2+0x11: call to addr_has_metadata() with UACCESS enabled > > Signed-off-by: Arnd Bergmann Reviewed-by: Marco Elver > --- > mm/kasan/kasan.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 3231314e071f..9377b0789edc 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -297,7 +297,7 @@ static inline const void *kasan_shadow_to_mem(const void *shadow_addr) > << KASAN_SHADOW_SCALE_SHIFT); > } > > -static inline bool addr_has_metadata(const void *addr) > +static __always_inline bool addr_has_metadata(const void *addr) > { > return (kasan_reset_tag(addr) >= > kasan_shadow_to_mem((void *)KASAN_SHADOW_START)); > @@ -316,7 +316,7 @@ bool kasan_check_range(unsigned long addr, size_t size, bool write, > > #else /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > > -static inline bool addr_has_metadata(const void *addr) > +static __always_inline bool addr_has_metadata(const void *addr) > { > return (is_vmalloc_addr(addr) || virt_addr_valid(addr)); > } > -- > 2.39.1 >