From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6578C41513 for ; Tue, 9 Jul 2024 21:03:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 495276B00A0; Tue, 9 Jul 2024 17:03:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4466E6B00A2; Tue, 9 Jul 2024 17:03:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E5946B00A3; Tue, 9 Jul 2024 17:03:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0F92C6B00A0 for ; Tue, 9 Jul 2024 17:03:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7E069A1A36 for ; Tue, 9 Jul 2024 21:03:37 +0000 (UTC) X-FDA: 82321440474.23.7EBB941 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 96A8FC0017 for ; Tue, 9 Jul 2024 21:03:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QCGbQs1+; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.221.172 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720558999; a=rsa-sha256; cv=none; b=Pa9LWbwGNSDYdl7U0VfDbcd+FSdMpZVAeW42CYkLFsGOos1PR2dP4eJ6zyk7Ponuda7jdM 1NfcSKd4ARpWyQtMaEIweznx4vNhJmphBOn/3dsKRc53oqmQEZAQmUthGnn1zs47me5a+B a3QoAOwQ7jNTkqKL1aHgEZE61ZX9/3c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QCGbQs1+; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.221.172 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720558999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uEEVtKYtkpBGMMntNLgt1VflFU8iMiYE2mInhS30FFw=; b=twvZPAts3CrbDcGkiKyU45tDTSqoUAecm+CEXRi3VrArBhJdoP2033PGPKyqzxI3GIUAIL 1jIdN29+FXnJKJnaQRrWJjLWOM/vJD1uBDalt0gT29a0VEGPqG5wwed32OHehKTuv6qwoZ /opYldAf+GGt+GXs35K9NBH22rGf0QU= Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-4f2ee99e2d0so1622607e0c.0 for ; Tue, 09 Jul 2024 14:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720559015; x=1721163815; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uEEVtKYtkpBGMMntNLgt1VflFU8iMiYE2mInhS30FFw=; b=QCGbQs1+srEN0Fvft1kSrmbxlFZ+lX/KZQpcoJpgXLJ9pm0VO1IXKQJQD/ROjGvLSD ykpebHAl8xFtLH8Hf61b7+EDIeTrbs4BbIKg0HPCQ2/6n6Pal9X+vFWUVCl6TwTNL4r5 Tj4f1X0NEWRLYsm09gdGKC3LTCEIGTa+YJMPTdQQZli4cKeW0wnAJeIa0ycRg4fJPVyA a9ANGIDs9E1cn2FqIQo8X6xT+6QdE2C29+b46x2PQCV9scBSvHRITXCI01JyD2hBUG0p eSKFHOoYNvGTyRoMAWB/QrcPW8xWTUzKbGvQzEzD6AZ40NF4LiPrtRNJbh1sSctm2c6T rImA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720559015; x=1721163815; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uEEVtKYtkpBGMMntNLgt1VflFU8iMiYE2mInhS30FFw=; b=xPHd4nWerfuOYpUeU08BBppf89qUz54FPFu/VTsIcTRyfTEIT3vq6cY128z1iUF5VA HSgTyy5DuoeMjmeMMfilCLoGSBxvVErc1pW+gKokfw3144NPKHsMgm8itmmexk2jb9Lc XDslhiz7PMEvfnWUehtmKQZ3bshn+f+MIeUKpIrjHaTyTveGfUxWK6yKzOsIR4hUI1yk wkDySd0fSAabr1SunC1nRQafgcrOGgrlX0yShFi7UiYovfsgXj7rP++Pkae3WdKbGkQ6 f6qBDXdWqVzpO4ZYurqZFhVC5qz092QuHLM1U4rapJFwjd/0O44eP4lOUjXXLXqo3sjE pEDQ== X-Forwarded-Encrypted: i=1; AJvYcCXJGqwtnf23+Dk50bpSFiRWoScMq977uwoiY5TEoWkyvTbDUx8lR6GYiFN9xTBVcb2LSoXS68a2UtmCo/qkAfovVkU= X-Gm-Message-State: AOJu0YzOnNMO9pBFM4PlBytKXyfNsMsm21yzcs/MC85tO3EC3V+YWlyM KlzTXVT3EN2u2udvDWEg6jKWJ7ae8PUmXhYKJ4MCnBDLNSHfRmiuOOdH/8dqI7S1NZ9QhWdEZYY erg30nLcoxJKyRVS5DT5aERmLnATPTFqhxXNs X-Google-Smtp-Source: AGHT+IHU1E8fzuJxDgkkRa8V51Zp91URQNvMI7d/QwIPp6TAjb2CXGR3nGBcdKh6trunZV3PhvoQJWHyJO0iWBgRnhg= X-Received: by 2002:a05:6122:d13:b0:4f2:ea44:fd2b with SMTP id 71dfb90a1353d-4f33ef758a0mr4208200e0c.0.1720559014412; Tue, 09 Jul 2024 14:03:34 -0700 (PDT) MIME-Version: 1.0 References: <20240708190924.work.846-kees@kernel.org> <202407091327.AEF6C020D@keescook> In-Reply-To: <202407091327.AEF6C020D@keescook> From: Marco Elver Date: Tue, 9 Jul 2024 23:02:55 +0200 Message-ID: Subject: Re: [RFC][PATCH 0/4] slab: Allow for type introspection during allocation To: Kees Cook Cc: "Christoph Lameter (Ampere)" , Vlastimil Babka , Jann Horn , Tony Luck , Nick Desaulniers , Miguel Ojeda , Nathan Chancellor , Hao Luo , Przemek Kitszel , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Guilherme G. Piccoli" , Mark Rutland , Jakub Kicinski , Petr Pavlu , Alexander Lobakin , Tony Ambardar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 3ipiefbme7zpr99c79m54jfihs3px6y1 X-Rspamd-Queue-Id: 96A8FC0017 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720559015-194208 X-HE-Meta: U2FsdGVkX18z+oDIlFu5OODsHpb0IC1tmcSO/V/c8W+N+8W5RRGYujC7x1scfVrRwHj6oaTCBEaGevJlGW6NPmXTZbkVcqkvLcmH2go41rAgRc6sNiqPSwdiqPZjCRiASyjN0GssHYz/DjdigOg9mGP6SDHsCcwI0R4qSxMLRJSzyW91BDAQiJJRmYtDlLwYsVUEARGll6vYhtcBE8BItWEENIHsdiGzSr1jAnLX7fTzAuqyCGbhcR3MmV0gRSBPRge49ydV8xnAdDu0c95g2agkGLm9xS71YZOmLLCGMSOh6HdDjCQOdhRXnqt5bQM2xxzYl49LzFBe8LKpVKL/cdtb90YUWATJd/Qep9nqaSDl8NmlStLO0PQTo0PWFPI1rsbxxrNfrAcrMDmh5EQiArHh7eqyntk70eNhHDGuqjUPS5DS/7II3CbpFvbBUE/EM0aidwlG1WzzQZJ9f3VZVKBpy6JD8ef5/DRfOHAqO70yrd/IsUSYOrCuFn4l/3k3jrY90B9QTTlXF35gothQrePZfEbLGYDWPirgTNgYa3kyhK6PeNBxZHuLXVsZk97ndy0chZMW1I3XLTt0L3ygMK2Ea5mohRN7+F8jKHfTDZffFcHTu3o8aIoY2HlfEs5anHX7jcF4NPs8eEr0ICOk2/6CiY/lOxjoWDpBtNwc6wdcz35tzF23ztm3DwEvPvRXcrvhHkaDniPi9JG3xyVzZVfcsKkIKYsGMsq33oK0LmXKJLAFhrforANoiY/75xqOefvyOfYpXTd51sRR3IzkcjVo/FPtpbJd0eBC0O9UfLqK7j+P1gzIC+u+gBPbk+g3efT7ciZizCD9zEhokplIIPx5cBSdE264xzC0l68J8tSRVnKd++zie4+vAjdFxwjwLNStjDf/nH/UcNkgvUBdDlW9I/VEnT3X8RTse9uC+Rg7mAqbAjiRbXmbCo1JwHkU4YPBnTiX91srvaYSrUi nen2aDIf MHOOTUeuCInnArgyLLUfUju2pbEpHLJlsuybS5D0wnv6fmJEgG2zamJNG7jl1eqeMuHnItjTPIkLJIbcThZKxKNum5VgQfd2cFj19nvBSq1aqfBuE2VdUBpV0VCqzE5wMB/JbY/PMD+NMPFv4Rp0dcSQ71m+aIpl81JbIdkhf7kzt97cXGdv9WPgUcMwIXCKzZrPSVbrjXyERoMt9ZxUmSyf7NvZNUjNS9bW6DJQ5wV0LBSdrNdrhvexQc1BCsXzdYtOov2rk0Poq1awrlRJ+ZoNfhygvRxrxienW8KBfdUf7juu1xOa2WBaDMopR2w+to9AheY/X/HlCmXs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 9 Jul 2024 at 22:28, Kees Cook wrote: > > On Tue, Jul 09, 2024 at 10:26:32AM -0700, Christoph Lameter (Ampere) wrote: > > On Mon, 8 Jul 2024, Kees Cook wrote: > > > > > > > > obj = kmalloc(obj, gfp); > > > > Could we avoid repeating "obj" in this pattern? > > > > F.e. > > > > KMALLOC(obj, gfp); > > This appears to be the common feedback, which is good! :) And we can > still have it return "obj" as well, so it could still be used in > "return" statements, etc. I will work up a new RFC... More macros like this only obfuscate the code further. The name would become something that makes it really clear there's an assignment. assign_kmalloc(obj, gfp) There may be better options. Also ALLCAPS could be avoided here, as we have done with other language-like features (vs. pure constants).