From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640BDC433F5 for ; Thu, 7 Apr 2022 09:49:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 006416B0071; Thu, 7 Apr 2022 05:49:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED1706B0073; Thu, 7 Apr 2022 05:49:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D724E6B0074; Thu, 7 Apr 2022 05:49:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id C622F6B0071 for ; Thu, 7 Apr 2022 05:49:04 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 86B9324FAD for ; Thu, 7 Apr 2022 09:48:54 +0000 (UTC) X-FDA: 79329608988.11.7C7BEC4 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf14.hostedemail.com (Postfix) with ESMTP id 10125100003 for ; Thu, 7 Apr 2022 09:48:53 +0000 (UTC) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-2eb680211d9so55392357b3.9 for ; Thu, 07 Apr 2022 02:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RZbNz+SpGjPMORTCOnUHEEDjbgkpN3TzZ8t3nm7Vc+A=; b=fJfbpG72F15dzw6yJPdCMqtaaVUiPKONl/VQIBClr4m5Z7qF+ov7M6ksi8z80qWLIp aJFiZ9G7SpNwwB8tTNpeNZ9BnGK1uOpeJALMiNdQyn1NWSygi8d4SHj0ufg+WM0Z/eFI lzIMu4YP+OKwBUAQ5GMiWreq61vF6Ti81I9H2UgblPQnSqCp8JgepZ0jV4BLuKS+74kS sXWwX8cepfr0aPgqGvclG1m1o93On+ITCtZsMiZ6vO+toWKOrPqMcS3HONbihefKFvnS +L/4wOvQZG6SyjQVsUBTlJNa1NfhwFpV55wN+Y5a6eYKRggLsmKH+nEWasaQt17tAVjy 666w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RZbNz+SpGjPMORTCOnUHEEDjbgkpN3TzZ8t3nm7Vc+A=; b=nYInPZgvH/om4qfvqts+fGi1WTOA2VYSXzw7jj9DyUf26EJd/tiASwoHCuYBhAdo5x 5d/57B3SRL3UxcnyKVViVcMs6IB28txqV0mHw8p0Ano28WeBVmmXPwfofmjPa9vCxIEj zmU7ogujdHE05JrDJPpe6wcGWBm/KQnik9iNSa4UrBE2tbvA+MetZ/W/GEmFufXkobNq C4md7LCvgCpduwYaTVs4vveHnUg6yLK71GwxOrdq8p9bU8OxZdzzJ/4nAH4qfq5Ho8We 7dWFm33X0SEyDJ4Sin/OP3aI9cXZTAhkXA/uYbkX6LB+LOYip83qZh7sV/kTEnE1C9/7 ESAQ== X-Gm-Message-State: AOAM531rugFN0wRBlo5Jc2klhEWIm/0POQZdcbxQs003Fg5zr+Jv+c06 NSb9ABZY8ISLteywCU0HVkBpJSD82y0G4n4JdwhdCQ== X-Google-Smtp-Source: ABdhPJwRwYaeYGw4ImLQSlQVlGj4Lgux/eZhTZEthnfJccgUmtDEEr4gywZL4rNhwbkSNiGlHyomepDkDH8pGxwLaj8= X-Received: by 2002:a0d:c306:0:b0:2e5:96ab:592e with SMTP id f6-20020a0dc306000000b002e596ab592emr10782019ywd.316.1649324933050; Thu, 07 Apr 2022 02:48:53 -0700 (PDT) MIME-Version: 1.0 References: <20220406131558.3558585-1-elver@google.com> <4b592848-ef06-ea8a-180a-3efc22b1bb0e@suse.cz> In-Reply-To: <4b592848-ef06-ea8a-180a-3efc22b1bb0e@suse.cz> From: Marco Elver Date: Thu, 7 Apr 2022 11:48:16 +0200 Message-ID: Subject: Re: [PATCH] mm, kfence: support kmem_dump_obj() for KFENCE objects To: Vlastimil Babka Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot , Hyeonggon Yoo <42.hyeyoo@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 4fofujghup346r9ekbiakk4fip1y3zn6 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=fJfbpG72; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 10125100003 X-HE-Tag: 1649324933-320011 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 7 Apr 2022 at 11:43, Vlastimil Babka wrote: > > On 4/6/22 15:15, Marco Elver wrote: > > Calling kmem_obj_info() via kmem_dump_obj() on KFENCE objects has been > > producing garbage data due to the object not actually being maintained > > by SLAB or SLUB. > > > > Fix this by implementing __kfence_obj_info() that copies relevant > > information to struct kmem_obj_info when the object was allocated by > > KFENCE; this is called by a common kmem_obj_info(), which also calls the > > slab/slub/slob specific variant now called __kmem_obj_info(). > > > > For completeness, kmem_dump_obj() now displays if the object was > > allocated by KFENCE. > > > > Link: https://lore.kernel.org/all/20220323090520.GG16885@xsang-OptiPlex-9020/ > > Fixes: b89fb5ef0ce6 ("mm, kfence: insert KFENCE hooks for SLUB") > > Fixes: d3fb45f370d9 ("mm, kfence: insert KFENCE hooks for SLAB") > > Reported-by: kernel test robot > > Signed-off-by: Marco Elver > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Thanks. > Given the impact on slab, and my series exposing the bug, I will add this to > slab tree. It's already in Andrew's tree: https://lore.kernel.org/all/20220406192351.2E115C385A5@smtp.kernel.org/T/#u Does your series and this patch merge cleanly? If so, maybe leaving in -mm is fine. Of course I don't mind either way and it's up to you and Andrew. Thanks, -- Marco