From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71EA9C6FD1C for ; Thu, 23 Mar 2023 08:28:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C80E56B0072; Thu, 23 Mar 2023 04:28:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2FC96B0074; Thu, 23 Mar 2023 04:28:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF8826B0075; Thu, 23 Mar 2023 04:28:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A0BAD6B0072 for ; Thu, 23 Mar 2023 04:28:40 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 703AC1403B6 for ; Thu, 23 Mar 2023 08:28:40 +0000 (UTC) X-FDA: 80599486800.12.4183C0E Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf10.hostedemail.com (Postfix) with ESMTP id AEF71C001E for ; Thu, 23 Mar 2023 08:28:38 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kGBFE0Oc; spf=pass (imf10.hostedemail.com: domain of elver@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679560118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OOYn20tiv4eFu0Zo7pcx9dFPpDzH/yyBBrbi1uHVeEQ=; b=iuTxVe8r32u8ZZkiiEMPbBOMfFL61qWCTBxqyl7rnWPG62ukRcBPA9K9klmqUH+lanH2m+ fsCxhdi8jzBvftwz4eB5/T3bYsbFwg69ZaTKj6t8kY0+4ywIptRHhCzxMU+JLtdd7thbNf BwXTrtF/mPPhDDScUYDeQwbFUjd4+T4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kGBFE0Oc; spf=pass (imf10.hostedemail.com: domain of elver@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679560118; a=rsa-sha256; cv=none; b=v80i5BbsNsHoc2pMuDoewGT9IOGXbwk5u+2pAxw8kxXCu2j/pBk/mGlscSVxqj/F6o5z4J 2+vFlPcMws5x9+EhkUPn6yEl4FQJuWj1EwJygBB9cXJmf7O0Qv4kjageKZm0oMw+Ie3L0L u/Z8p+BfaB/fT7VPacRFRuuki5JJaAM= Received: by mail-yb1-f171.google.com with SMTP id b18so4824363ybp.1 for ; Thu, 23 Mar 2023 01:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679560118; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OOYn20tiv4eFu0Zo7pcx9dFPpDzH/yyBBrbi1uHVeEQ=; b=kGBFE0OcsNVnZV308/d8pqLJw67m161QBjI+II3xw8adyZdwxXxS0p7W7LdC135V+v gVM+KzidBZmB68wArIHRWYEX4KO1T0uvxbe1nRLABZtcyksaDoWYjyaRd6KPedxAO+Xi 6w6n2qb6GF0RuuY8foKjmT0j1oNIUJSB3IV/gjuMo4QAMluwtzCB3/mKDOWMg+sCRwmA O3cVWR9vgl8Woy5ZOPGry0KPPl57KWo+tcH8gLSugts046ym+Hi1LJdJnCdS06VVSP89 OjRqpNEWGxjPKKk227RuxrLDCH2zr8mriw5xBYMfnAFNhw4JbDB5ULD5jzg/OASqaTC8 3Jpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679560118; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OOYn20tiv4eFu0Zo7pcx9dFPpDzH/yyBBrbi1uHVeEQ=; b=BcU8fUrXmVM1x1gvAU/iSBqNRAnmUl4JmocmK6Ru5BYGr0LaEt/Rbc7VlRkYBblzK+ YyOP23Ge0FIzMA2qabKGmlfGKwxKiGV+tkwJEmnIxHMXFCS3fsnd7gaZ19WEaQVQpmc0 vODTV8tOubNA6SBvYhRlr2RUeL3emX55soiiZlMosWfGO1rmjS5VaebghSd5/a19JOAT V1w1hZqRFobB+WfH+ktEshKtNyOUTg7IWVQzBE0LH+3fl+tDqDU1cXN8Fym1NoxfwnpX DPoPkV0S+Bd6XyApVNFiJPsbB0ELgrwREz3qzDsXdLYwh3ZFPhfVmwS2n5fT+6W/d5bG c90Q== X-Gm-Message-State: AAQBX9eWuKfNkBx5UqmjebCORCPbIalKupuUzAT7rZFhAT7iXqrPd7Pm uJ4R4/Euhoj27GJLC5ldIy9XQDcmXYcR/XCwWKCxqQ== X-Google-Smtp-Source: AKy350YYHC7uwCbjENv3/g6/oHc8hZCRZS/al+XHOovK9BGvOXAjJkB87T26I+IR59hrCZyKA67OR/aCzqEFmxJM0aQ= X-Received: by 2002:a25:6dc1:0:b0:b67:4774:7a3e with SMTP id i184-20020a256dc1000000b00b6747747a3emr2279910ybc.62.1679560117717; Thu, 23 Mar 2023 01:28:37 -0700 (PDT) MIME-Version: 1.0 References: <20230323025003.94447-1-songmuchun@bytedance.com> In-Reply-To: <20230323025003.94447-1-songmuchun@bytedance.com> From: Marco Elver Date: Thu, 23 Mar 2023 09:28:01 +0100 Message-ID: Subject: Re: [PATCH] mm: kfence: fix handling discontiguous page To: Muchun Song Cc: glider@google.com, dvyukov@google.com, akpm@linux-foundation.org, jannh@google.com, sjpark@amazon.de, muchun.song@linux.dev, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AEF71C001E X-Rspam-User: X-Stat-Signature: pr61hcc9jwyn3ox5myp55chu75q4mh6r X-HE-Tag: 1679560118-839978 X-HE-Meta: U2FsdGVkX1+JDJvqRDmCwCWUESGXw1SoDNgmCNHBU0xzpR3iNCW4AC0ImApbq7yaenRo2ANsg0ebvLI4sAGbJbEMKvHY9nCHNrIqAZPIBPx3Zh9AU3jbU39wKYtl46FnVZv2w6ZMSBOwMRPK9fe5nrPBJfE7buNxlgqTevstoSgWLyGTo6LZrtTl834agfIrz6I4gp2o6RJzhZZlqWDnTKZYkC5l+PkoQ0oGHO4GQEmj80Flv+CkjgcWV+S5bDegJM9xy2yTEIE33eqeY4OQc9aPkh0Oj3XDblksGmsYFnfhF+GlTDMP1Ltzzj2qLLoba3TckVi+seAQFv88ICj3vbAD3xz9MjLX28OFq23PFamU/8YiKxC1rr4Y44uTup7Z3TFVbxiFXlXpNtldobxfTMPJh1Q/K9p2leXdRialx+vXTcrRMZxzVspOcWjRzPGXx1I2XgTJlPTM4tFaVgYxanVyULTY2z7flhbowM+Xfwwid1Xhr+nl+vI9Hwqac/sol1Qali9Omnn2aQDjX31eiGsougnJ3BEWJm2yITOlHZOMgfut9Jsz7HLkIFSdTUqzXCiMY4k3dr/BkxUoOQgKdv9CkZYy5ydh0he/8q10NrViHMwpgoK4qskDZIWWK7XJ7vz6gU+AnALzhsIzPTxnbZj3z2+G1tgdZvVF+UdGmzy4oqEXDO1JP22cOG0tTyR76fcz23ST4MTjZfDD7dntwAtDdfWFffA1xymAJjW50wb4YbWJsFSNBd+jPO2t7fsILh4QJTis+2Mt/BkhbNlMwxghbrERBWzugCFRwMPC5LHAYzkOnVtQ/8LPrv78KksjUyGCSB1zh50ryZRHLnTbnWfb6G0dZ2nLffBCziC6EMygr/EsRax0Urzj6e8xsk3P0Vo+D+lJs9llo//qQONFdapGnl0q8QnQMG7PF00B1pdOPsqSAp6jnEywe57ewYbxmKiDrE6+yCMxaWkNo0H /XSKS93V nLGa/nFUk4geWpFkBUarQFYZ8kSTRncArA2G5k2a+Tv3tiTKkDSCjkHcUavSbEwv2aZY0Wp9c8OPODZ3pEWd18zazermO+G+2tmbEiv7Ri+11fEiQI1RPSCf0y2sYgM9aD7VuzhBkd4jduEqXyEg2w+Mi5s9OLbIzRR7JaTSaKg4PyLdvvPbsAkYS7TBEX7TE3qZJs8YcBU6VPYAjXed/UmKVIdphUccRyQ80rOrV3h8r3Quuuxgkzt+rGJMKOm9hMyuDyTsUFZ2bI0CPxL6zEk5aBKDyYvGkelmMw1pX9LZmgPAh4Vk/Zh8m0nezSyI53bUuDFkz/f2/R3MRQYQpBQoPCvDFiuIY8jIDuzOTIxyIXOMD3C8itZJF9p288K2iVAhapyw1kEbXkhktEn+5djQB/MBLKC3JtnVV5diVkY0Phud/1qwTvKVMTg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 23 Mar 2023 at 03:50, 'Muchun Song' via kasan-dev wrote: > > The struct pages could be discontiguous when the kfence pool is allocated > via alloc_contig_pages() with CONFIG_SPARSEMEM and !CONFIG_SPARSEMEM_VMEMMAP. > So, the iteration should use nth_page(). > > Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure") > Signed-off-by: Muchun Song Reviewed-by: Marco Elver > --- > mm/kfence/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index d66092dd187c..1065e0568d05 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -556,7 +556,7 @@ static unsigned long kfence_init_pool(void) > * enters __slab_free() slow-path. > */ > for (i = 0; i < KFENCE_POOL_SIZE / PAGE_SIZE; i++) { > - struct slab *slab = page_slab(&pages[i]); > + struct slab *slab = page_slab(nth_page(pages, i)); > > if (!i || (i % 2)) > continue; > @@ -602,7 +602,7 @@ static unsigned long kfence_init_pool(void) > > reset_slab: > for (i = 0; i < KFENCE_POOL_SIZE / PAGE_SIZE; i++) { > - struct slab *slab = page_slab(&pages[i]); > + struct slab *slab = page_slab(nth_page(pages, i)); > > if (!i || (i % 2)) > continue; > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20230323025003.94447-1-songmuchun%40bytedance.com.