From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1365C4332F for ; Tue, 14 Nov 2023 07:46:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E45D6B02A0; Tue, 14 Nov 2023 02:46:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 393966B02B2; Tue, 14 Nov 2023 02:46:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25B076B02BA; Tue, 14 Nov 2023 02:46:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 16ECF6B02A0 for ; Tue, 14 Nov 2023 02:46:45 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B1878C0A20 for ; Tue, 14 Nov 2023 07:46:44 +0000 (UTC) X-FDA: 81455777928.04.77C3248 Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf16.hostedemail.com (Postfix) with ESMTP id EF51A18000F for ; Tue, 14 Nov 2023 07:46:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TI4qOYWJ; spf=pass (imf16.hostedemail.com: domain of elver@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699948002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sX2ZDi+R3Ev6T5LlvMfvdN7qFs7PkFHPelflvttGDD4=; b=wfZ0fEVMi3XguIrh13p39hxVNps3zr8Fh2yujYuGXvP+B+16Gd7N5u4D3z9dRMObmZ6Ych DQ47rBZJooxOD3MIyhZze3iOf7UOoaL4uF1w3IEZ7INwkTshIXb30H/NTZwRPtFNIWjZqo bZmt2kaHNk1+KfZVBwscNqzovxH0HWM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699948002; a=rsa-sha256; cv=none; b=1c61Z99RP5TKuUbs830HShu+RHFM4pZ/YQ45t0hWeCWX9hEN11SWQRNfm8/oQdnTBbtkkC MLQJVzVLSb04nDHO8o26x5jDJnaYVRxemfWUl579xBo61uZ0rfU0rakHlkvQWkXKh6xDHY +/aJwTYPsBrScH0Kc7iVvz2u5wRjJV8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TI4qOYWJ; spf=pass (imf16.hostedemail.com: domain of elver@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7bb3e55c120so2119367241.0 for ; Mon, 13 Nov 2023 23:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699948001; x=1700552801; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sX2ZDi+R3Ev6T5LlvMfvdN7qFs7PkFHPelflvttGDD4=; b=TI4qOYWJecemABr2r2Se3ivLy+lIMkci2YB1REk7XysTzn/OCtru1s2tCD9Ughisfi jAy4+lfwwWoisJOkf0JMx/war5jY2SBffYV0CPO4woZgjwylUzixu3/KR6LLjaPpAdUr siLLLCjgKnyp4Lp9yknYJzZrXcSlC1jbrVIGwsruUII8DkV/+XBcAAxmEwBd3fqG9Ets 4pjTSeCtMJ34pDDp5diq/cdSyCA1mUUeBmRgfeJ8gsakePnW3RA4xcZ5iBuaiiz0E2L0 xCvqOOWxfKEOKxprVBtj7lZGzmNR43k4FGQip7ts3UBRSPnDxE2FByZomRhpSyK6DgZv caJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699948001; x=1700552801; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sX2ZDi+R3Ev6T5LlvMfvdN7qFs7PkFHPelflvttGDD4=; b=j0U4fa5G4M+/wFqroXOGrjBYYv6Bax7dvGUcR8y8A0nbdGf/aXBKstrKjorbh3uzbA jTeDVC9ub05VAWU6xM5dCkD/Yt+Aghr+6cS8EoD2LZpiMznIshvN90plwxnzKYb+7ERk U7Yc5qmCdStGukGtif7xm08R3sz+83Q/rBLvSvQapmaWUhNYItNNOx2rI2pp7Dncb5QH OkZc5SftBFq+EVAG+YV6DTMybBhX/sGmMmxiM3qBP/yic20hPrfUUko/OsvzZwYRRZj7 ZerpZm9S3/+jDnJ+pi3HVnujs1CRzIAWzeD5v32AEnNfbmTLAgC6KypEGmmWtgzok3CI PMRw== X-Gm-Message-State: AOJu0YzcIHjN4UviFwPPQueu24TdLNDq0yVDGzgMxzrAM9S9AoBUazzE clY/UJTUVCN4Rd4gBQadIp263A2RMtIZMUPLPM+AoA== X-Google-Smtp-Source: AGHT+IEkx9qpi9PxginlouXMsLXjDm4AhflR5GKJMwuObn7dBWpabAiTtV5tdjgAPRBqG6d0RnyHF3wv2N9uz3bxx2o= X-Received: by 2002:a05:6102:2908:b0:460:621c:d14b with SMTP id cz8-20020a056102290800b00460621cd14bmr9815342vsb.20.1699948000802; Mon, 13 Nov 2023 23:46:40 -0800 (PST) MIME-Version: 1.0 References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-25-vbabka@suse.cz> In-Reply-To: <20231113191340.17482-25-vbabka@suse.cz> From: Marco Elver Date: Tue, 14 Nov 2023 08:46:04 +0100 Message-ID: Subject: Re: [PATCH 03/20] KFENCE: cleanup kfence_guarded_alloc() after CONFIG_SLAB removal To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 1tk8n5yhwemjxmwimncbud3o6ajd7oa4 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EF51A18000F X-Rspam-User: X-HE-Tag: 1699948001-924216 X-HE-Meta: U2FsdGVkX1/Cq65tUMfqFcFG+dWxfqJU+sQSeEQ+nBPHRdheqkYmz2r1lzm+kSuPd65ExEVgBC1t94X2NVUsE4uc7Wl3oiLl9d0oOixxiNt5UJjP7RVisdUS7UIRmctbM4Z+mJ7HootCfcLEuxP9ejrNAF8baE0luTpQaFxw0SCvbMGvs2TBIl/kF2wK30/JTirB/Y1HXXcBaSVN5k75JZ2rbigo53Dv0stUTQfF06hN8jS/dn0ZOqpj1wCP72Zu5OynY3fX2RB+Mv+KkIHYrrVJg5pJt6HJU12Y78Yws8flePQz6+fD4VS3apqz7qMZ7k0pmc68nenOQ1Sb6Z3ptvCY8tk+KXCoKLDw/7g2oveSVRGIANHkDTlFOLaflEj06ahq1/sy5lZzSvQ9VsBkDlGVTWsGvLdGvGlcxcqN7KqS4g84GYRE2bDhZ3QJ9fNab7tDrtyuzHAdWmmc680AiBZqTbspcxr0+UdQTFZDp/gxAUSy27jOMoOaIX0pGxKYtXC+nUM8DnwINoMbKxI6hKBUMMiDNIqgi8uVuzbWIhLzIp1UlK46g+29FTT03KDE2fMrGzQol82CeXnsV/qrjPYGVDXS+sqAlJQBeI3fB6MBLfmoz2Pxf01OnXTwxsyYeGKHvdKouENbdiR6itKhppKOwYsIdJ2hfiYFR1UG5rS3jaSofONQczpjsAlxBkCAAqSUVhhqsbMyFpTELbAz/pfGLLna2xxn9tcn+67YyRa95iB4aM56plZuljTM4irc/ETU6JBbnkZO9I1IrPR0YC3zkHF9uZOl4Icf8a1b6h83HcteX3AYuzx9K5NGffCzjASo/mLV8fHIaEw84ABa+9802Nn55pUITGgkNNgxhg8BHTsD4FD5yUyO0ZTqQDOpDRqZROvmGJrZuBPtdH534CpmkSWboZsKQdSPlWQ6ugpbNmG/bOOidG5JeSiKs82P4aWkrGZjpku/tvJXaBI OcOxtMK7 80wSw6U9oqDuoqH7ZekYCeO2oYdwDEdG0lAZ/dvYfPFPNxx0udl/d6GvbV15uDeKCuuaocdTd0JMss+3n0N1+/aGGIg5Iy48AffAslfY9wLG++vt7uXEAUL9q4cWVe5DAHemG6x/XR4Jk5RsWQ9EByc5uhNHtLiqZ9COTiQShbC+H/MLw3WcpV/dqbr/XZYelA7B+idtI5uH6C5REwL3E5IOnK4mOpcRIIBA8JGex/D327Gc6XL020q0ih7qBzkoSYTEfq4+qb4TPYBJ/8b1iz0yub3Dm+DOkNC1Odvjju2V6HH22d/gfAo/20+A1o6BcauEZ++zcplkuAmStcuJW7bsUc+vhvscIXHOwSQmhQZ+O8HQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 13 Nov 2023 at 20:14, Vlastimil Babka wrote: > > Some struct slab fields are initialized differently for SLAB and SLUB so > we can simplify with SLUB being the only remaining allocator. > > Signed-off-by: Vlastimil Babka Reviewed-by: Marco Elver > --- > mm/kfence/core.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 3872528d0963..8350f5c06f2e 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -463,11 +463,7 @@ static void *kfence_guarded_alloc(struct kmem_cache *cache, size_t size, gfp_t g > /* Set required slab fields. */ > slab = virt_to_slab((void *)meta->addr); > slab->slab_cache = cache; > -#if defined(CONFIG_SLUB) > slab->objects = 1; > -#elif defined(CONFIG_SLAB) > - slab->s_mem = addr; > -#endif > > /* Memory initialization. */ > set_canary(meta); > -- > 2.42.1 >