From: Marco Elver <elver@google.com>
To: "qiwu.chen" <qiwuchen55@gmail.com>
Cc: glider@google.com, dvyukov@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, "qiwu.chen" <qiwu.chen@transsion.com>
Subject: Re: [PATCH] mm: kfence: fix elapsed time for allocated/freed track
Date: Tue, 24 Sep 2024 11:01:10 +0200 [thread overview]
Message-ID: <CANpmjNOpA=Aa_Vhjv1MoZdy+PoEQiUDtVi3jjFLf-BpeoJ48Ow@mail.gmail.com> (raw)
In-Reply-To: <20240924085004.75401-1-qiwu.chen@transsion.com>
On Tue, 24 Sept 2024 at 10:50, qiwu.chen <qiwuchen55@gmail.com> wrote:
>
> Fix elapsed time for the allocated/freed track introduced
> by commit 62e73fd85d7bf.
>
> Fixes: 62e73fd85d7bf ("mm: kfence: print the elapsed time for allocated/freed track")
> Signed-off-by: qiwu.chen <qiwu.chen@transsion.com>
Good catch...
Reviewed-by: Marco Elver <elver@google.com>
> ---
> mm/kfence/report.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kfence/report.c b/mm/kfence/report.c
> index 451991a3a8f2..6370c5207d1a 100644
> --- a/mm/kfence/report.c
> +++ b/mm/kfence/report.c
> @@ -109,7 +109,7 @@ static void kfence_print_stack(struct seq_file *seq, const struct kfence_metadat
> const struct kfence_track *track = show_alloc ? &meta->alloc_track : &meta->free_track;
> u64 ts_sec = track->ts_nsec;
> unsigned long rem_nsec = do_div(ts_sec, NSEC_PER_SEC);
> - u64 interval_nsec = local_clock() - meta->alloc_track.ts_nsec;
> + u64 interval_nsec = local_clock() - track->ts_nsec;
> unsigned long rem_interval_nsec = do_div(interval_nsec, NSEC_PER_SEC);
>
> /* Timestamp matches printk timestamp format. */
> --
> 2.25.1
>
prev parent reply other threads:[~2024-09-24 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 8:50 qiwu.chen
2024-09-24 9:01 ` Marco Elver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANpmjNOpA=Aa_Vhjv1MoZdy+PoEQiUDtVi3jjFLf-BpeoJ48Ow@mail.gmail.com' \
--to=elver@google.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=linux-mm@kvack.org \
--cc=qiwu.chen@transsion.com \
--cc=qiwuchen55@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox