From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7607C6FD1F for ; Tue, 2 Apr 2024 07:09:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71B536B0098; Tue, 2 Apr 2024 03:09:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CD2B6B0099; Tue, 2 Apr 2024 03:09:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 594AF6B009A; Tue, 2 Apr 2024 03:09:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 397D56B0098 for ; Tue, 2 Apr 2024 03:09:12 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 97A4B1409D1 for ; Tue, 2 Apr 2024 07:09:11 +0000 (UTC) X-FDA: 81963715302.29.A97445B Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by imf14.hostedemail.com (Postfix) with ESMTP id C4698100004 for ; Tue, 2 Apr 2024 07:09:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L08aIt6w; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712041749; a=rsa-sha256; cv=none; b=zSjYB0+xOuzQYYuIHjkeAVCBjxKtzM+enhPuLhUxYGjILpJocDf/2EUxM6zSllXHI1CHdd jqp1NdglOLrFYd4eVeBHgAENA0KYXTqokSJoqS8Ge01QWGuNO8f36cfN5QoKkbQnlC1qUJ M7qPf9Ia2nVeEsEI+GY+l6qvBTcd86M= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=L08aIt6w; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712041749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=haQJ60gcyfzT0PPIcpufheaE0XM4vQtB9WG6Oc5rEk0=; b=yj7JLjTeztSHfl1MLSLzvrHJbdd88/e6ZPyBEaMMB4ehS6RP3RSXZEgPgXY+jlYejcCC6Y sFRB6HTJv9Ffharq26M6u3hO8tqv6YlccvoXJ0J5HUfaQtfyDaCRWB2OXJcta24g7Cae68 JZNlxPXUTNN3g4AN7FxqVcuwJOHQD4Y= Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-7e128b1ba75so1322790241.3 for ; Tue, 02 Apr 2024 00:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712041749; x=1712646549; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=haQJ60gcyfzT0PPIcpufheaE0XM4vQtB9WG6Oc5rEk0=; b=L08aIt6wUzxZr4pqzFptC1ACEw6K6weB/3taPuje1wd4vdicWhi6DjzwnYYUSb5Veo ZbCXZQP7D/zEjoz6JaiGk4t3DfWlMkRB7b4mpYmFjHIHZFn6N05JXXuSqgVn7OtxB/nW jR9TMqUHZOc93M8uZPJykM9+zhvJk6RPIHnSrmR0bZzGE8Z4HyS2DtpZzGSeIpC8WmqX xcw0Gbm6xLNQtly36ksLfuTWRKonY3o2FTRcbVPU75fbAnoVDxKjgALgXuSMGP/V9Dy6 ZgDqHduAwUBsaxx5YOwguB7QSpxyeIq5bBCFELTAl4woCtm2tT+rhvkfTtRqnH2OKgGh aCtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712041749; x=1712646549; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=haQJ60gcyfzT0PPIcpufheaE0XM4vQtB9WG6Oc5rEk0=; b=SlWqcI/BiSCpoHxN0tixwz5Bxueic2g8SNtvP8seEx8ZwW55ACLGdLyS7J3NX4CEfF GXlcE6Qi5+wgF38ChvgZ0ExPWg4a+AdwuzamlTYaqi9hKyXUN9jFtiwDH1/AWj3nliNo BXUNSHWd2VpAX022CdBczkJ3u4cMQ1lmgta9b+v9gyeZ00gS4E94lUtSSOBlJOrFjrkm MrBxFRZXl5VrVuGofuikYfEzPkMa82EJdXvcIk+aGOtbY8UMpbE4zdJY52hEJfqR0Anf zlgw1/LLcNCjolHDmRSEtTDPty2zXvlz4herEJAR02/hJrbzcA/IZ0RFsMjO01iEsieY UZEA== X-Forwarded-Encrypted: i=1; AJvYcCUtYckbIlqY4u37kgvJ7RAHsNoNUF05LLXBZo0y20JpULscCwbWbPJf0W4s+99/EMfIN0cUdWPGLUKFdd/8MQ+i7sE= X-Gm-Message-State: AOJu0YymqSMWT4GCw0n452Jf3GbkVW4SlrJJcXttbBetbH4DDZZQasfq 0iaFmUDdzAzlCaLk4VidlnuG3oncEz22oKNXYNiHXQXAGFUV0Flh4hIPULQ2InZUWtI6gMD0tmV eH/uMgaN1P7TCLDnUDYc8UbZstLUKbg3uw9iu X-Google-Smtp-Source: AGHT+IE2XWNUQP5fyiz0lDixSxBA7dWCXgQaoBsbs3BFpiwhXmOCEUELRrpL2YEHmRxtWGfATq8KbUE+fHeXzNF/yC0= X-Received: by 2002:a05:6102:4a11:b0:478:52cc:fc42 with SMTP id jw17-20020a0561024a1100b0047852ccfc42mr9301382vsb.10.1712041748682; Tue, 02 Apr 2024 00:09:08 -0700 (PDT) MIME-Version: 1.0 References: <20240402001500.53533-1-pcc@google.com> In-Reply-To: From: Marco Elver Date: Tue, 2 Apr 2024 09:08:29 +0200 Message-ID: Subject: Re: [PATCH] stackdepot: Rename pool_index to pool_index_plus_1 To: Alexander Potapenko Cc: Vlastimil Babka , Peter Collingbourne , Andrey Konovalov , Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Omar Sandoval Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C4698100004 X-Stat-Signature: 8bfuygqt7xq59q4wacwmd8iz1gj6ax4m X-Rspam-User: X-HE-Tag: 1712041749-403429 X-HE-Meta: U2FsdGVkX1+/OXKT0EpwXwcCec+0nLemHjKf3LITh8crsXWnQEi6WD7qROjOZfhlCENj/1FQGb3mCelEh60smdLxxYE910aezBxP8xI4b+iwaTvTD6eexYxHCpdkMPftqlT/Jtc3q56qrBCYKU+1r1ZKLphsWhDafVuDHScQMJG89vplLt+joGR6G39kEjrJKV3HQm7yY1twSfqqoeQnrIR9XSCbt8GfC+Or566FoU85iHrctxl0yH+CcwDEBvMl9p+YLwb1B43ynK5sByrDn1SjBxA1IDOZ/oTvJ1z03x1c/3UYZmknCyWDfu9G8nMohaQbQ/RshlfjAHZOdDbjm9shuicASZgQ4Z1Vw5VBm1Crjw4RbJhJkxbpcVjIkCQN1I4KIjnXO1+Ja2wjgKkhJ/nyChQ2EGbu5gMh5iJqKzWSZgpXqUhbsUbuR8UPC3h0RO0L3sRxX9ZMr+T+WJDgX0+unELzKMEttCoeVpv4DTtjKa4hGRL1wzRaCbeDmqGfNiKpdOKZMLDt6OKKCvKl/oF00cg+L4FDSGTWhZWMQRFoQrIdpF8P3D8q4di8pPcybDV6uuMwqm9oWULKq6ewt/uzt0z/srsezpISN0n8El6Y5VBsaBMkXMGcVQQVS7MnJf78Z/aUKNUwy6ZuktdAWuTyl7GQ6unkDvZ2KnFTiIGEnotH2l5L9hqSWXoa6WkXGTXWEAh0I0cf4AsHRBZt0ipqT3yPnNAoTZU/dKUBMB60SCQ+D13HL7rqy2PYVYY9BC9Mpwct7Yj8OKOvqEPSTZujI+yNpwJlXvmBb7p8XtwYXJx0BkJx14beAPFPw0I9LyhlIi+mHOFv3w7jGw6fWtG/GKTG2xKhNMuVI/vW5wLX6zHirDg5KtYbouRt0qLtMRlNS2VfBw8kJdJ3f/0VuPMALd/CtZyE5LjCk1kOJObkNFLpena6BEWscTsmGy+dIl/9qdcy6wY5mG3/ym5 AIi924d9 8FnGSn7qGQMlggAHsKBjlaqvSwUolmeDkJn4UC/62BnolOaBeQcwLSfM9gLppqcHElNE8GQKgomytKrh5Gf3673Qt5gO/OYXY8dCaLFLtG5JQwMI3bo8PydFO1e5ydjBqd1Z0r5Ed0sDRVMSdUa41dlwcJbQke4qwiC/XRh63m5qsVdsbDzibXVKFmW1Ol7Atb0usUr6JI8dO6o2o38uI3hdhzPzDXKbsXVEBxrMjr60ZGJ5FTU2TDWDRAopsnobnsHbPlzwoVPGMoPFnusv4bQBl+VGV5ZzXq2CbH6whbxY41Gm7NQjbhaQao8Mc6l7kgDf8AxLvIwFcE5am1uNed3bPj7t5bhJj6IVd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2 Apr 2024 at 09:04, Alexander Potapenko wrote: > > On Tue, Apr 2, 2024 at 8:54=E2=80=AFAM Vlastimil Babka w= rote: > > > > On 4/2/24 2:14 AM, Peter Collingbourne wrote: > > > Commit 3ee34eabac2a ("lib/stackdepot: fix first entry having a > > > 0-handle") changed the meaning of the pool_index field to mean "the > > > pool index plus 1". This made the code accessing this field less > > > self-documenting, as well as causing debuggers such as drgn to not > > > be able to easily remain compatible with both old and new kernels, > > > because they typically do that by testing for presence of the new > > > field. Because stackdepot is a debugging tool, we should make sure > > > that it is debugger friendly. Therefore, give the field a different > > > name to improve readability as well as enabling debugger backwards > > > compatibility. > > > > > > Signed-off-by: Peter Collingbourne > > > Link: https://linux-review.googlesource.com/id/Ib3e70c36c1d230dd0a118= dc22649b33e768b9f88 > > > > Acked-by: Vlastimil Babka > Reviewed-by: Alexander Potapenko Acked-by: Marco Elver