From: Marco Elver <elver@google.com>
To: Alexander Potapenko <glider@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Peter Collingbourne <pcc@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@suse.com>, Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH] stackdepot: Rename pool_index to pool_index_plus_1
Date: Tue, 2 Apr 2024 09:08:29 +0200 [thread overview]
Message-ID: <CANpmjNOonPXC9JzMJ2spmTU+80pYJJzW90omy2pvF7=0qNJU3Q@mail.gmail.com> (raw)
In-Reply-To: <CAG_fn=XL7tSuCuBXKf1YDiETkFMte7JyLrSE+saDthtJj==hUQ@mail.gmail.com>
On Tue, 2 Apr 2024 at 09:04, Alexander Potapenko <glider@google.com> wrote:
>
> On Tue, Apr 2, 2024 at 8:54 AM Vlastimil Babka <vbabka@suse.cz> wrote:
> >
> > On 4/2/24 2:14 AM, Peter Collingbourne wrote:
> > > Commit 3ee34eabac2a ("lib/stackdepot: fix first entry having a
> > > 0-handle") changed the meaning of the pool_index field to mean "the
> > > pool index plus 1". This made the code accessing this field less
> > > self-documenting, as well as causing debuggers such as drgn to not
> > > be able to easily remain compatible with both old and new kernels,
> > > because they typically do that by testing for presence of the new
> > > field. Because stackdepot is a debugging tool, we should make sure
> > > that it is debugger friendly. Therefore, give the field a different
> > > name to improve readability as well as enabling debugger backwards
> > > compatibility.
> > >
> > > Signed-off-by: Peter Collingbourne <pcc@google.com>
> > > Link: https://linux-review.googlesource.com/id/Ib3e70c36c1d230dd0a118dc22649b33e768b9f88
> >
> > Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: Alexander Potapenko <glider@google.com>
Acked-by: Marco Elver <elver@google.com>
next prev parent reply other threads:[~2024-04-02 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 0:14 Peter Collingbourne
2024-04-02 6:54 ` Vlastimil Babka
2024-04-02 7:04 ` Alexander Potapenko
2024-04-02 7:08 ` Marco Elver [this message]
2024-04-02 8:01 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANpmjNOonPXC9JzMJ2spmTU+80pYJJzW90omy2pvF7=0qNJU3Q@mail.gmail.com' \
--to=elver@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=osandov@fb.com \
--cc=pcc@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox