From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B666C433F5 for ; Tue, 22 Feb 2022 17:50:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E0C28D0002; Tue, 22 Feb 2022 12:50:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98FCE8D0001; Tue, 22 Feb 2022 12:50:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 831588D0002; Tue, 22 Feb 2022 12:50:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 743DD8D0001 for ; Tue, 22 Feb 2022 12:50:53 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 08B468249980 for ; Tue, 22 Feb 2022 17:50:53 +0000 (UTC) X-FDA: 79171156386.22.18D008D Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf05.hostedemail.com (Postfix) with ESMTP id 8FDC7100006 for ; Tue, 22 Feb 2022 17:50:52 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-2d07ae0b1bfso183272087b3.6 for ; Tue, 22 Feb 2022 09:50:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n9xVaMbyiCTyGVqLYvVRvUgZYTi80RFry9SG8JbTIuM=; b=E7oEHcm+ntyxOhoqbMu+HSBjq0dpxawKzssjfQF1nJrK/A7c8zAU4F1uFDmbT6cmSl RJDJWlz3bXfYH9pxdVKWEF10fZFGfTDqUUVwR3P3I0iXOaRcUueIPJLRKaGW+pJmO30n vBmqwJWmUIJ09UVSQ270yISMqFCxdOslp1quL9cgbsVXdDGbECPdHsZSOjlOuxHtLWyH cZIz/PXqfF3sST4Sn6uJVNgfoK/6BP1zCnIaQMz3xBwgJxRJOtwgKG2a3iaAKjTs1WxO 8TfUqEHXnx85HRX5dXNvAd468gci2yERMHCZbeDMtk/+1Anr3FYyb4bcu6ac8uMOz2J/ 7dfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n9xVaMbyiCTyGVqLYvVRvUgZYTi80RFry9SG8JbTIuM=; b=5/rGbOCK9Q5X0iHg9epUxSJAFJ+DoG/HawCmx5CGsiX6YI/nStUijMGjabADuw5jOq UCz/0aclV2bUY63PxFc9omXll/7NR+FoewkbO4htkuppFF/wAaACmXZYJvQW67rioF+k fU61dznFYk9gM/fCGv8qPC5SzzvqbzLNfqqYTEcqaJhKXv7vYR4rysrl9Gqw2n47+wUC qLd3KlyVqKz9nB2eAM6NK855YCvuQCWPmibFFPoupQ8yWtzzLN7/H39X9BoEvtw8oHHA rQkbOnOJHr1mhOptgfw0m+aVSlx5OZ06nFUG3BZiRV/Do7BHX7LM84aTfzYt9/a2J9wX EbfQ== X-Gm-Message-State: AOAM531SIDAWxHIYIp4qSxo1Nj1wu40jtzjyGyw9WK/ZVwK/nKxeGuNt 9yVnnvgjyz+Oj8A82kCo7g22EPw4bTVO/p/5Xz0wPA== X-Google-Smtp-Source: ABdhPJx10vs403agr7Ha9dQrnJxuqut368Zs9E6OP/cT8QB4W05q1e1Ho91pZzmrt8lFJt9MKq3jtwau3zHsctXBbdg= X-Received: by 2002:a81:743:0:b0:2ca:287c:6ca2 with SMTP id 64-20020a810743000000b002ca287c6ca2mr24456433ywh.327.1645552251533; Tue, 22 Feb 2022 09:50:51 -0800 (PST) MIME-Version: 1.0 References: <2d44632c4067be35491b58b147a4d1329fdfcf16.1645549750.git.andreyknvl@google.com> In-Reply-To: <2d44632c4067be35491b58b147a4d1329fdfcf16.1645549750.git.andreyknvl@google.com> From: Marco Elver Date: Tue, 22 Feb 2022 18:50:40 +0100 Message-ID: Subject: Re: [PATCH mm] another fix for "kasan: improve vmalloc tests" To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=E7oEHcm+; spf=pass (imf05.hostedemail.com: domain of elver@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8FDC7100006 X-Stat-Signature: 84ps1pxeomxyxqa17o184nq633mnrx46 X-HE-Tag: 1645552252-628050 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 22 Feb 2022 at 18:10, wrote: > > From: Andrey Konovalov > > set_memory_rw/ro() are not exported to be used in modules and thus > cannot be used in KUnit-compatible KASAN tests. > > Drop the checks that rely on these functions. > > Reported-by: kernel test robot > Signed-off-by: Andrey Konovalov > --- > lib/test_kasan.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index ef99d81fe8b3..448194bbc41d 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -1083,12 +1083,6 @@ static void vmalloc_helpers_tags(struct kunit *test) > KUNIT_ASSERT_TRUE(test, is_vmalloc_addr(ptr)); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, vmalloc_to_page(ptr)); > > - /* Make sure vmalloc'ed memory permissions can be changed. */ > - rv = set_memory_ro((unsigned long)ptr, 1); > - KUNIT_ASSERT_GE(test, rv, 0); > - rv = set_memory_rw((unsigned long)ptr, 1); > - KUNIT_ASSERT_GE(test, rv, 0); You can still test it by checking 'ifdef MODULE'. You could add a separate test which is skipped if MODULE is defined. Does that work?