From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE142C433E0 for ; Tue, 2 Feb 2021 18:41:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 641B164F88 for ; Tue, 2 Feb 2021 18:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 641B164F88 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CE5A36B0005; Tue, 2 Feb 2021 13:41:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6FC56B0006; Tue, 2 Feb 2021 13:41:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B37686B006C; Tue, 2 Feb 2021 13:41:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 9A7E96B0005 for ; Tue, 2 Feb 2021 13:41:09 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 636598249980 for ; Tue, 2 Feb 2021 18:41:09 +0000 (UTC) X-FDA: 77774195058.10.team27_38104e0275cd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 29DD816A069 for ; Tue, 2 Feb 2021 18:41:09 +0000 (UTC) X-HE-Tag: team27_38104e0275cd X-Filterd-Recvd-Size: 4266 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 18:41:08 +0000 (UTC) Received: by mail-ot1-f49.google.com with SMTP id s107so208332otb.8 for ; Tue, 02 Feb 2021 10:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AM9+VMIDUzwgmsYBk9umRY0HUzM3XXRBDO1nka7d3og=; b=s9rHW2e0Nrv0tmYo6Fias3UCwRvC3sycwUaSoUl5TmWaf7y8UPYAxbNoId0ZKFyV0G EZRTqAviAAx5h3M44XGhYBG7ijYHRbr+315nDi089h86Yj5vloULaaOOAK2KH28RQOrB GaTXje2AzkUQdSI+viwvcwTy2ZZgWhjXVHK/cy89VtqVx5fFo2pFcC/a7OWRANkca9NF OowcE6XVOkVJWncAxyUJn3c2Cy2PkqvUo/+P2u7G1aA4mrsmYIrt6Ul+WCARvBon8jtn pw00h/M4Wu+7kjmIC+9lQNtnS0ZY2UtNEuGr2pWq971W/PdOnHLz0XELsnqBX1sjt+2Z J33w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AM9+VMIDUzwgmsYBk9umRY0HUzM3XXRBDO1nka7d3og=; b=VD8uudF5WLouONbW2KZCTsFj66i2xvQ7G/VOF7LuxwBhfKYrXCrsz9+p5qlDOQI7K/ v1Q8ldK9fFpycdn3fzKU7VoS8lFs1AMj21uRed1T8C9SwF00GjqKwy2SW25wZEL9h0N3 UeGa9HMooPjq0E/pW9m2efb3Bw8Gp1xQz6JMH+/oE2zZd+KIBKYXUPwc0ImdPQLJJYz/ BCsftU/wnDbe1WoxvB2ZRIR7Njyk+41FFT2c0tiV2ZHj7E76rbWjuohYzkFeIBd2QQp/ SgMeFjpxs8SXQcbVCQu2TvPXJKdCFyhw6NPwKFNqK5QUHGiXKyVglKogwb5io+iqeoce ZMmA== X-Gm-Message-State: AOAM532gHy+7t4PC3Sz0G6tgrgjWScvA2E0JAXRSQQI/T+sQz/krZk94 9sadwW3f1GBvArn+rz/E1fQ4SPVdH5rF0denW2rYaA== X-Google-Smtp-Source: ABdhPJyszm0Fovxs8Faqw0izV1peYSHPFf1e4UR8/ubU5Sy4IxlghvFKxy0dDX0vNZO/byxceLA6nptlOzBLctRSooA= X-Received: by 2002:a05:6830:1d79:: with SMTP id l25mr15633121oti.17.1612291267706; Tue, 02 Feb 2021 10:41:07 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Tue, 2 Feb 2021 19:40:56 +0100 Message-ID: Subject: Re: [PATCH 01/12] kasan, mm: don't save alloc stacks twice To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2 Feb 2021 at 19:01, 'Andrey Konovalov' via kasan-dev wrote: [...] > > > @@ -83,6 +83,7 @@ static inline void kasan_disable_current(void) {} > > > struct kasan_cache { > > > int alloc_meta_offset; > > > int free_meta_offset; > > > + bool is_kmalloc; [...] > > > if (kasan_stack_collection_enabled()) > > > - set_alloc_info(cache, (void *)object, flags); > > > + set_alloc_info(cache, (void *)object, flags, kmalloc); > > > > It doesn't bother me too much, but: 'bool kmalloc' shadows function > > 'kmalloc' so this is technically fine, but using 'kmalloc' as the > > variable name here might be confusing and there is a small chance it > > might cause problems in a future refactor. > > Good point. Does "is_kmalloc" sound good? Sure, that's also consistent with the new struct field. Thanks, -- Marco