From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B99CFA3728 for ; Wed, 16 Oct 2019 17:04:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C442B20663 for ; Wed, 16 Oct 2019 17:04:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SnV6duwi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C442B20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6A0638E0005; Wed, 16 Oct 2019 13:04:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62A278E0001; Wed, 16 Oct 2019 13:04:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F0E28E0005; Wed, 16 Oct 2019 13:04:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 2D0E18E0001 for ; Wed, 16 Oct 2019 13:04:18 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id CBFD48376963 for ; Wed, 16 Oct 2019 17:04:17 +0000 (UTC) X-FDA: 76050270954.26.snow10_428eb0d230836 X-HE-Tag: snow10_428eb0d230836 X-Filterd-Recvd-Size: 4798 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Oct 2019 17:04:17 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id k25so20646532oiw.13 for ; Wed, 16 Oct 2019 10:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BSGWH28HRKXwBsAljxNnBMneVoGGH/xuNYpExPGbSaY=; b=SnV6duwiaal+yGD3AuPhlJcCXxUGyQLB+r75PKs+qHRyI/QWizQJVUfcvWk9X9i2OQ zJImBN8zyWaB/wS3UnRh5d9ZrP0JQce4Es6JbeJB5vbTkPcSiZ52CcoL8YCe4TglWK8o 186yTn3eE3xJXnC+4uUIwEmwTtnTl4kooRUrgqgOXhI+gzk/Spuvr6zuBj97NDv8o1UC nSBDhRyZEEVSGLN0cVa3qVKmVWV2EOOWtc4T7Zgw7d3GypYKUZ54HRZw1lO1/hl1fzN1 hGggQEji+g3hrpoN+TsUs+Ye9Z0ut6eQ0vJlg9n8BuPfAGiF3nIIKgIDjEopKsAyv5Vb XJtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BSGWH28HRKXwBsAljxNnBMneVoGGH/xuNYpExPGbSaY=; b=ZwX7t70ISkAVXD4PMHrG4rQmuxlkdZBU8noSYdTOkKDaTgZmPbrvXgobaXEd1TPIkZ kAkxT4F32OJx9UlZOZSafq8yxtpj/Nxazu9Xig+E+uvVEzhZa7A8KGpEU11D5Hn0tVeH YHl6EPTgxzp/26z0ka/S9xOWY/KCr/jn2XrvA/vNeIzk/SSJ7O9tg1J+/Iqkz9S21TFX 73pXdig9Jr3dMANC3py5Jyg74OWB/aacdKATtlRhKJ4tayD2Nq8Uv4tYZN8LTpsvv6ya fJJf/uhiyDYcvfm73j/wS2+TBMI2b3a5ydHq2WZ3GKg3ThZsvwBRsmARGW88CtQTsbAT Jn4Q== X-Gm-Message-State: APjAAAV+eqO7ftF3uzW70riZSh2rCl7pGp0AnMVzou9665+KGVYhseYr YG2P2q8EKnarbPG+HwjgzJW9THePdA2vF9kvrK06xg== X-Google-Smtp-Source: APXvYqyJf907NHVLtjRanj3dokhHHBREfhg/3ZadjyyyP26vVviAVhDiWn+UNwp7oYMNCmFsgbDqBfpdl+UYkHN8IG4= X-Received: by 2002:aca:5015:: with SMTP id e21mr4471718oib.121.1571245456250; Wed, 16 Oct 2019 10:04:16 -0700 (PDT) MIME-Version: 1.0 References: <20191016083959.186860-1-elver@google.com> <20191016083959.186860-9-elver@google.com> In-Reply-To: From: Marco Elver Date: Wed, 16 Oct 2019 19:04:05 +0200 Message-ID: Subject: Re: [PATCH 8/8] x86, kcsan: Enable KCSAN for x86 To: Dave Hansen Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , dave.hansen@linux.intel.com, David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Mark Rutland , Nicholas Piggin , "Paul E. McKenney" , Peter Zijlstra , Thomas Gleixner , Will Deacon , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, Linux Kbuild mailing list , LKML , Linux Memory Management List , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 16 Oct 2019 at 18:14, Dave Hansen wrote: > > On 10/16/19 1:39 AM, Marco Elver wrote: > > This patch enables KCSAN for x86, with updates to build rules to not use > > KCSAN for several incompatible compilation units. > > First of all KCSAN looks really interesting! > > For the x86 code, though, I'd really appreciate some specific notes on > why individual compilation units are incompatible. There might be some > that were missed, and we have to figure out what we do for any future > work. Knowing the logic used on these would be really helpful in the > future. Thanks! I will add comments where I can for v2. For most of them, I followed the examples of KASAN and co, and will try to reevaluate each one. -- Marco