From: Marco Elver <elver@google.com>
To: andrey.konovalov@linux.dev
Cc: Alexander Potapenko <glider@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
Peter Collingbourne <pcc@google.com>,
Evgenii Stepanov <eugenis@google.com>,
linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH mm v4 00/39] kasan, vmalloc, arm64: add vmalloc tagging support for SW/HW_TAGS
Date: Wed, 22 Dec 2021 08:00:00 +0100 [thread overview]
Message-ID: <CANpmjNOj-jYo=yaffBi5w=esyHYo=CEqDJce7cb-KmQ1P6BEMQ@mail.gmail.com> (raw)
In-Reply-To: <cover.1640036051.git.andreyknvl@google.com>
On Mon, 20 Dec 2021 at 22:58, <andrey.konovalov@linux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@google.com>
>
> Hi,
>
> This patchset adds vmalloc tagging support for SW_TAGS and HW_TAGS
> KASAN modes.
>
> The tree with patches is available here:
>
> https://github.com/xairy/linux/tree/up-kasan-vmalloc-tags-v4-akpm
>
> About half of patches are cleanups I went for along the way. None of
> them seem to be important enough to go through stable, so I decided
> not to split them out into separate patches/series.
>
> The patchset is partially based on an early version of the HW_TAGS
> patchset by Vincenzo that had vmalloc support. Thus, I added a
> Co-developed-by tag into a few patches.
>
> SW_TAGS vmalloc tagging support is straightforward. It reuses all of
> the generic KASAN machinery, but uses shadow memory to store tags
> instead of magic values. Naturally, vmalloc tagging requires adding
> a few kasan_reset_tag() annotations to the vmalloc code.
>
> HW_TAGS vmalloc tagging support stands out. HW_TAGS KASAN is based on
> Arm MTE, which can only assigns tags to physical memory. As a result,
> HW_TAGS KASAN only tags vmalloc() allocations, which are backed by
> page_alloc memory. It ignores vmap() and others.
>
> Changes in v3->v4:
[...]
> Andrey Konovalov (39):
> kasan, page_alloc: deduplicate should_skip_kasan_poison
> kasan, page_alloc: move tag_clear_highpage out of
> kernel_init_free_pages
> kasan, page_alloc: merge kasan_free_pages into free_pages_prepare
> kasan, page_alloc: simplify kasan_poison_pages call site
> kasan, page_alloc: init memory of skipped pages on free
> kasan: drop skip_kasan_poison variable in free_pages_prepare
> mm: clarify __GFP_ZEROTAGS comment
> kasan: only apply __GFP_ZEROTAGS when memory is zeroed
> kasan, page_alloc: refactor init checks in post_alloc_hook
> kasan, page_alloc: merge kasan_alloc_pages into post_alloc_hook
> kasan, page_alloc: combine tag_clear_highpage calls in post_alloc_hook
> kasan, page_alloc: move SetPageSkipKASanPoison in post_alloc_hook
> kasan, page_alloc: move kernel_init_free_pages in post_alloc_hook
> kasan, page_alloc: rework kasan_unpoison_pages call site
> kasan: clean up metadata byte definitions
> kasan: define KASAN_VMALLOC_INVALID for SW_TAGS
> kasan, x86, arm64, s390: rename functions for modules shadow
> kasan, vmalloc: drop outdated VM_KASAN comment
> kasan: reorder vmalloc hooks
> kasan: add wrappers for vmalloc hooks
> kasan, vmalloc: reset tags in vmalloc functions
> kasan, fork: reset pointer tags of vmapped stacks
> kasan, arm64: reset pointer tags of vmapped stacks
> kasan, vmalloc: add vmalloc tagging for SW_TAGS
> kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged
> kasan, vmalloc: unpoison VM_ALLOC pages after mapping
> kasan, mm: only define ___GFP_SKIP_KASAN_POISON with HW_TAGS
> kasan, page_alloc: allow skipping unpoisoning for HW_TAGS
> kasan, page_alloc: allow skipping memory init for HW_TAGS
> kasan, vmalloc: add vmalloc tagging for HW_TAGS
> kasan, vmalloc: only tag normal vmalloc allocations
> kasan, arm64: don't tag executable vmalloc allocations
> kasan: mark kasan_arg_stacktrace as __initdata
> kasan: simplify kasan_init_hw_tags
> kasan: add kasan.vmalloc command line flag
> kasan: allow enabling KASAN_VMALLOC and SW/HW_TAGS
> arm64: select KASAN_VMALLOC for SW/HW_TAGS modes
> kasan: documentation updates
> kasan: improve vmalloc tests
Functionally it all looks good. So rather than acking every patch, for
the whole series:
Acked-by: Marco Elver <elver@google.com>
... and in case you do a v5, I've left some minor comments.
Happy holidays!
Thanks,
-- Marco
next prev parent reply other threads:[~2021-12-22 7:01 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 21:58 andrey.konovalov
2021-12-20 21:58 ` [PATCH mm v4 01/39] kasan, page_alloc: deduplicate should_skip_kasan_poison andrey.konovalov
2021-12-20 21:58 ` [PATCH mm v4 02/39] kasan, page_alloc: move tag_clear_highpage out of kernel_init_free_pages andrey.konovalov
2021-12-20 21:58 ` [PATCH mm v4 03/39] kasan, page_alloc: merge kasan_free_pages into free_pages_prepare andrey.konovalov
2021-12-20 21:58 ` [PATCH mm v4 04/39] kasan, page_alloc: simplify kasan_poison_pages call site andrey.konovalov
2021-12-20 21:58 ` [PATCH mm v4 05/39] kasan, page_alloc: init memory of skipped pages on free andrey.konovalov
2021-12-20 21:58 ` [PATCH mm v4 06/39] kasan: drop skip_kasan_poison variable in free_pages_prepare andrey.konovalov
2021-12-20 21:58 ` [PATCH mm v4 07/39] mm: clarify __GFP_ZEROTAGS comment andrey.konovalov
2021-12-21 9:16 ` Alexander Potapenko
2021-12-30 19:11 ` Andrey Konovalov
2021-12-20 21:58 ` [PATCH mm v4 08/39] kasan: only apply __GFP_ZEROTAGS when memory is zeroed andrey.konovalov
2021-12-20 21:58 ` [PATCH mm v4 09/39] kasan, page_alloc: refactor init checks in post_alloc_hook andrey.konovalov
2021-12-20 21:58 ` [PATCH mm v4 10/39] kasan, page_alloc: merge kasan_alloc_pages into post_alloc_hook andrey.konovalov
2021-12-20 21:59 ` [PATCH mm v4 11/39] kasan, page_alloc: combine tag_clear_highpage calls in post_alloc_hook andrey.konovalov
2021-12-20 21:59 ` [PATCH mm v4 12/39] kasan, page_alloc: move SetPageSkipKASanPoison " andrey.konovalov
2021-12-20 21:59 ` [PATCH mm v4 13/39] kasan, page_alloc: move kernel_init_free_pages " andrey.konovalov
2021-12-20 21:59 ` [PATCH mm v4 14/39] kasan, page_alloc: rework kasan_unpoison_pages call site andrey.konovalov
2021-12-20 21:59 ` [PATCH mm v4 15/39] kasan: clean up metadata byte definitions andrey.konovalov
2021-12-20 21:59 ` [PATCH mm v4 16/39] kasan: define KASAN_VMALLOC_INVALID for SW_TAGS andrey.konovalov
2021-12-21 9:23 ` Alexander Potapenko
2021-12-20 21:59 ` [PATCH mm v4 17/39] kasan, x86, arm64, s390: rename functions for modules shadow andrey.konovalov
2021-12-20 21:59 ` [PATCH mm v4 18/39] kasan, vmalloc: drop outdated VM_KASAN comment andrey.konovalov
2021-12-20 21:59 ` [PATCH mm v4 19/39] kasan: reorder vmalloc hooks andrey.konovalov
2021-12-20 21:59 ` [PATCH mm v4 20/39] kasan: add wrappers for " andrey.konovalov
2021-12-21 14:21 ` Alexander Potapenko
2021-12-20 21:59 ` [PATCH mm v4 21/39] kasan, vmalloc: reset tags in vmalloc functions andrey.konovalov
2021-12-20 22:01 ` [PATCH mm v4 22/39] kasan, fork: reset pointer tags of vmapped stacks andrey.konovalov
2021-12-21 15:11 ` Alexander Potapenko
2021-12-20 22:01 ` [PATCH mm v4 23/39] kasan, arm64: " andrey.konovalov
2021-12-20 22:01 ` [PATCH mm v4 24/39] kasan, vmalloc: add vmalloc tagging for SW_TAGS andrey.konovalov
2021-12-20 22:01 ` [PATCH mm v4 25/39] kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged andrey.konovalov
2021-12-20 22:01 ` [PATCH mm v4 26/39] kasan, vmalloc: unpoison VM_ALLOC pages after mapping andrey.konovalov
2021-12-21 11:50 ` Alexander Potapenko
2021-12-20 22:01 ` [PATCH mm v4 27/39] kasan, mm: only define ___GFP_SKIP_KASAN_POISON with HW_TAGS andrey.konovalov
2021-12-20 22:02 ` [PATCH mm v4 28/39] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS andrey.konovalov
2021-12-21 12:04 ` Marco Elver
2021-12-30 19:11 ` Andrey Konovalov
2021-12-21 12:14 ` Marco Elver
2021-12-21 12:19 ` Marco Elver
2021-12-20 22:02 ` [PATCH mm v4 29/39] kasan, page_alloc: allow skipping memory init " andrey.konovalov
2021-12-21 12:11 ` Marco Elver
2021-12-30 19:11 ` Andrey Konovalov
2021-12-21 12:30 ` Marco Elver
2021-12-30 19:11 ` Andrey Konovalov
2021-12-20 22:02 ` [PATCH mm v4 30/39] kasan, vmalloc: add vmalloc tagging " andrey.konovalov
2021-12-20 22:02 ` [PATCH mm v4 31/39] kasan, vmalloc: only tag normal vmalloc allocations andrey.konovalov
2021-12-20 22:02 ` [PATCH mm v4 32/39] kasan, arm64: don't tag executable " andrey.konovalov
2021-12-20 22:05 ` Andrey Konovalov
2021-12-22 11:11 ` Catalin Marinas
2021-12-20 22:02 ` [PATCH mm v4 33/39] kasan: mark kasan_arg_stacktrace as __initdata andrey.konovalov
2021-12-20 22:02 ` [PATCH mm v4 34/39] kasan: simplify kasan_init_hw_tags andrey.konovalov
2021-12-20 22:02 ` [PATCH mm v4 35/39] kasan: add kasan.vmalloc command line flag andrey.konovalov
2021-12-21 14:43 ` Alexander Potapenko
2021-12-30 19:11 ` Andrey Konovalov
2021-12-20 22:03 ` [PATCH mm v4 36/39] kasan: allow enabling KASAN_VMALLOC and SW/HW_TAGS andrey.konovalov
2021-12-20 22:03 ` [PATCH mm v4 37/39] arm64: select KASAN_VMALLOC for SW/HW_TAGS modes andrey.konovalov
2021-12-20 22:03 ` [PATCH mm v4 38/39] kasan: documentation updates andrey.konovalov
2021-12-20 22:03 ` [PATCH mm v4 39/39] kasan: improve vmalloc tests andrey.konovalov
2021-12-22 7:00 ` Marco Elver [this message]
2021-12-30 19:11 ` [PATCH mm v4 00/39] kasan, vmalloc, arm64: add vmalloc tagging support for SW/HW_TAGS Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANpmjNOj-jYo=yaffBi5w=esyHYo=CEqDJce7cb-KmQ1P6BEMQ@mail.gmail.com' \
--to=elver@google.com \
--cc=akpm@linux-foundation.org \
--cc=andrey.konovalov@linux.dev \
--cc=andreyknvl@gmail.com \
--cc=andreyknvl@google.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=pcc@google.com \
--cc=ryabinin.a.a@gmail.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox