From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7DDC4829E for ; Thu, 15 Feb 2024 09:33:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E257A6B0096; Thu, 15 Feb 2024 04:33:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD3A28D0001; Thu, 15 Feb 2024 04:33:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C749D6B009E; Thu, 15 Feb 2024 04:33:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B24066B0096 for ; Thu, 15 Feb 2024 04:33:57 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 88BDAA26F6 for ; Thu, 15 Feb 2024 09:33:57 +0000 (UTC) X-FDA: 81793526514.17.743FFA7 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by imf25.hostedemail.com (Postfix) with ESMTP id D3D19A0008 for ; Thu, 15 Feb 2024 09:33:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zaI3V9cD; spf=pass (imf25.hostedemail.com: domain of elver@google.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707989635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V8s0NxRvI+mjl5XkkaP3mvBN6LNvbOLcAfquE2r5eZI=; b=4HKVgGX4sb0GI0LZVxbCKffgPy4louhgjPEuEc9PY65yQmnW5+1uBC8+jFVUNJ9j44g7CS N1ik6cXa+/uh8cOAZsNq8sv9PQKvNzbBwXPcsPdVi8vfmz/jpBg4lPzOaWiviP85SidLON ex3EkHOhr+vpndqC6BeHJWSYQFWTbrc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zaI3V9cD; spf=pass (imf25.hostedemail.com: domain of elver@google.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707989635; a=rsa-sha256; cv=none; b=M39F2/H5V4t/d4oPcCsW7MJrE5VYjw3ATJIF0XCw3ym1zeYtKXDgI6GuqN/3sJR7tk5Uq0 GyzWqZKOC4/X7YTsYHiJ0ZKAabuKotRBHuEZdxuf9X5C0OIN6fZv3UU2bEmZ8GhdBtf+mF FCOusv9gctKRSDg4dD/BcYtTxZ+X4FU= Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-4b978e5e240so317798e0c.0 for ; Thu, 15 Feb 2024 01:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707989635; x=1708594435; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=V8s0NxRvI+mjl5XkkaP3mvBN6LNvbOLcAfquE2r5eZI=; b=zaI3V9cDJM3Yehh84Rk3HuA1wg8uTlYWm4Qg8VWfZhNvvSLq25VUbw19HyH/JQ2IDU NGrkYTJp9JcNgsZvLR5buWWb8VLa7dU0D+ON7/hLfY7aKgqMVYKUt0+z+68odK2RNtBt gnB413+lUlcusFX+jwSQxBm3oROE84ehHYCrHLyotAk5vfkATf9e62OQ+wtUD66ZQz22 EWGo9JVsYpmthuLqsBUhv26+A3IleVZrhdiIlnv5y7kz/YVdU5tFwq3P5LzgeCyHOcRn Sbqupj435jIkuiZR/o6Nf564HCj08i9Nlh15PzS3KFsUQhddtVvkytS3BU0m0Py3AHoa v3Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707989635; x=1708594435; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V8s0NxRvI+mjl5XkkaP3mvBN6LNvbOLcAfquE2r5eZI=; b=lEldGe5udh3E5tU2MnI5ACl23zuKjpr8P1bSqtKEtayydaBXSuIDs8w19j4xfH2Bve /66NtnshuHqHcDDWa5W2+FG9QLGSZSqrO3NglCRFd+rrYm7/bE5fjPMV4NE2Mbop6gQg Hh+3BBoYGwAFgdUHELgwRIg6+qrf6AJwH6S4RsIEMcFo2qz3+VGo1lfjYajlC0YwlCwN vZFEJ/3F5ihcmtyWJBqZzPsuSXGEPNrA1m9AdR5MWp5xewb8JsW13uMayI49pcew8bZ1 fks8W10ad8y5j8wkQb9uvEJOk6noLQjgxe4t9Dmilgt7TP1dOiPyh47x4B7oN5dkht+x GZvw== X-Forwarded-Encrypted: i=1; AJvYcCU+6LUPOuJpotGz81oP1nzJYrJ9hGTz7LFjDwyeChLzVmdqqV4LD3of3iEfdwLn2HhIpyjtxxJvBfBYZXhjXoh1VjA= X-Gm-Message-State: AOJu0YxVWUJN/DM/q2qYYJQ3fFSFHkrg6RcK3pRKMkZlA5NZ+ZsIdt7z +YbGJfVXOElCtZl20CTfE2ysTia5rwPnrS+vtDbRrVuPck9Dgm9fJlJMo31w/UjBYF1QuKQKtrt ZNUZ4QUQAIouJ6AvlBwrXwFzasYwZDNAxxrFG X-Google-Smtp-Source: AGHT+IElxHBxZPPrDv/wuxMTC9HS3F+Al5XcXpij5VChL1txzlpGTpCPvZpdQ+kn1EdxDYRzRCWxa1OgWoaaU0+6Mf8= X-Received: by 2002:a1f:6681:0:b0:4b7:19fd:9558 with SMTP id a123-20020a1f6681000000b004b719fd9558mr815574vkc.11.1707989634396; Thu, 15 Feb 2024 01:33:54 -0800 (PST) MIME-Version: 1.0 References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-3-osalvador@suse.de> In-Reply-To: From: Marco Elver Date: Thu, 15 Feb 2024 10:33:15 +0100 Message-ID: Subject: Re: [PATCH v9 2/7] lib/stackdepot: Move stack_record struct definition into the header To: Vlastimil Babka Cc: Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrey Konovalov , Alexander Potapenko Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D3D19A0008 X-Rspam-User: X-Stat-Signature: asm4iwuxokub8zeephm71uhitqer4tw8 X-Rspamd-Server: rspam01 X-HE-Tag: 1707989635-702914 X-HE-Meta: U2FsdGVkX1+qLv31NsdWGbRdYohXLv30h1DKppRuDY78Dqeg9XIZHF5kdsDGm3QlENBo1MnEHncUd0mRP5DN4Zp+DUc8mFGvkFJWkYkBTyxkFIA5IdunOxEKICANGN5cUhKBz2hXk2an/ftrgHHxxKoOtob8et+4crfie1X6W+ajgpNUxt0I1tNr3Y0ZFWD5W/gFiqeyTiRvhKRIPWrv8ja9cVa9SWISvCKCWrtRXRFNhtp3q4ugvhhaTLUKZdBZXLULHzIDDfdEqCbig6Be7bMkNwnoUi9KMBrByl8Ln9cavwhdDCqA8H2lwzvHVQwR3zSOgQK6e6A6T0+frQMfcfODeHNzyEEIZZqNvlQq4obhb4RcsYnHB2zvDHtBsgTkutAFPrzaJkLvsJcaLgXhCxcGj0nHtVda+L+Ny4Bv8eX3QEH4hQfnNgFN4O5E9wkHD7opMsqb7rP8iAJ3H90v+AwQqGk3AYLR3osCy9J5Hi9vuydIXtpSvWKMKc67jAA2E+UGK9TN9AbBPXaii2ZR6ZNMCQRA3w14TqdMtu6dWlBtErqbQ2bP7lWaP+0hgOhEKqZM2ZBdr2q4p5eO46X6F4U2mbOlRqiVbFmTX2NIcFYDvyPCDv3zEy2VnGkh/wdc1weoZCzdvLAex8mxRzk8F4KNGox3auio+dRuJX1NbGYN30gb4m6mfGsRjCL82APXKV6mLoPX80K2b/31JjWiCkqoiUa4jnNMAP5vUyDWvsWOzAQVZjvzQ1yd0LOvn6rCC+DyALGwbrhH68T1rOGYnK01ZS+kSsbzvsXHW2M2hcomASpffqzUKNYhccZq+6t1bk9tQgGm4rECY8j6FDpbtPl9qlA0v4ZZBaDVdpXjzQAZev3N+grNUNWorZFwEAKpqiL/CnCHrV3YTmeTFZ08N8Xg55nPEI04ilfDHixIakTqoZxRUvcr+EXHnA0xbCa/HUZv3a6uv7phbnaTxTO Q+plS6rw 8ceWh7Qt7gwIrIDbSbo3JiYroViViRxek+hfPScTii6mxCZfN9MkSqw40ygf0gQv0EEpo+TcAwUElabcnD9vLcckpJz5+puVKth4FypnggXHMaKq71yeYMpdaa8jnn8no9nhPkWNZFDywilnIr0ARRQlViuij3y6gjLRrlmHej1ZUPXPRFFo5MyjCU0N+OekC5FC9MLmimMY+u7u1MoqNZ+TbZKdf7NJL8YHgC/dU7ymVQZwnqGJKlf3DQqcK1GPJCg7JJn631UeZE9k/SsJTYNSBXDVkeg6loMF80SUqx8G66jIHNXgoyBWefJxkN0o1hC5evTGPnsi5RWA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 15 Feb 2024 at 10:30, Vlastimil Babka wrote: > > On 2/15/24 09:16, Marco Elver wrote: > > On Wed, 14 Feb 2024 at 18:00, Oscar Salvador wrote: > >> > >> In order to move the heavy lifting into page_owner code, this one > >> needs to have access to the stack_record structure, which right now > >> sits in lib/stackdepot.c. > >> Move it to the stackdepot.h header so page_owner can access > >> stack_record's struct fields. > >> > >> Signed-off-by: Oscar Salvador > >> Reviewed-by: Marco Elver > >> Reviewed-by: Vlastimil Babka > >> --- > > >> #define DEPOT_POOLS_CAP 8192 > >> -/* The pool_index is offset by 1 so the first record does not have a 0 handle. */ > >> +/* The pool_index is offset by 1 so the first record does not have a 0 handle */ > > > > Why this comment change? We lost the '.' -- for future reference, it'd > > be good to ensure unnecessary changes don't creep into the diff. This > > is just nitpicking, > > Agree with this part. > > > and I've already reviewed this change, so no need > > to send a v+1. > > But confused by this remark. There is a number of nontrivial changes in the > series from v8, and IIRC v8 was dropped from mm/ meanwhile, so a v+1 of the > whole series is expected and not fixups. Which means including patches that > were already reviewed. That's the usual process. This is already v9. Of course, still need to look at rest of v9 and if there are major changes needed then a v10 is needed.