From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2119C433EF for ; Sat, 5 Mar 2022 09:37:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE9598D001A; Sat, 5 Mar 2022 04:37:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D96CF8D0001; Sat, 5 Mar 2022 04:37:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85458D001A; Sat, 5 Mar 2022 04:37:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id B889E8D0001 for ; Sat, 5 Mar 2022 04:37:13 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6F09F8249980 for ; Sat, 5 Mar 2022 09:37:13 +0000 (UTC) X-FDA: 79209829146.31.0BA9CF3 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf17.hostedemail.com (Postfix) with ESMTP id C156C40004 for ; Sat, 5 Mar 2022 09:37:12 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id z30so8734965ybi.2 for ; Sat, 05 Mar 2022 01:37:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o8YRPKtxEMPdU6+Q3B6e4fqO0sPdCeK3qQDcbu/LSDI=; b=lHnnCFcHOLqcqZMm+7wQDnMfORjxrlVmpEtEJuS6gqKBKU+vVsAsu/j2DDL/uk7k/4 vnoJald/c6ZzlLjFH0RiIW6L4/ClW47utWEV4ymBywMHUbQ31+5jSCXbNVOGEZMB+ALy 7Qd2TCsiTF+jFtlMtgK0GzOZz0abu2MV4x1XAdr1CalMppFy7btDAv8CuSENnArupIMq Hp3va2VbOL9LRQN6ahlW/H5+aNj/smQDh49mLjExKFZbzv5CLdqOJF0YhVzC29GJOfkX XgYn2Vu+HmHcFwlm1hjPtRMCdnkR5C2ETrWUjxvf+/3acp2xLbOMjHRB4h/mtAt1uDvz p4Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o8YRPKtxEMPdU6+Q3B6e4fqO0sPdCeK3qQDcbu/LSDI=; b=B//UCOiZqcigKoaELQF0kRT9SjSSjSzt7oVQOgX2VLPpsOam6rry63s5S5bSop7zQQ 7K0nquvd/q9rUg51o/najCWgS4hPpovCylhWP3dZqd5uV5P6HO77SMngMIX42OVvA6NO ehKofvsNdTuLaONFYJnGpEvDLvGdBQxxE7uTfOWoe84nJSR+fA2IM1mrxl/BzT8HrWQm UDfVtZmIhdGJrBGLty6SI5tiDQpdXOcXe2cQ+tAbq+aylP6tEbb1twGo1fsi08hDUJR5 n+5uBQ2H5aZIPsn6oGw9CzCkxVlpBUllmMt1Opd0qScJi5pJuRHQb40c0Ui8os6rddFv 8mJA== X-Gm-Message-State: AOAM533wcYeFJNue9C3r4jj2tQOVL7XdsgD8+RU6Ox0nuHmh+CU5TrmT dFQznfswvPXZpYv1eRKe2dXHRn8OyKEHG43ocDfsSQ== X-Google-Smtp-Source: ABdhPJy+3sPb+vFJFSCeYOx7Nqrxnm/kaHNaW4YkZqqdkW9gvOQjFuD4x1RcsXjG04ZLnGqcIy+NhRNvP9lJp7Cy7bg= X-Received: by 2002:a25:6994:0:b0:629:1e05:b110 with SMTP id e142-20020a256994000000b006291e05b110mr497927ybc.425.1646473031701; Sat, 05 Mar 2022 01:37:11 -0800 (PST) MIME-Version: 1.0 References: <20220303031505.28495-1-dtcccc@linux.alibaba.com> <20220303031505.28495-2-dtcccc@linux.alibaba.com> In-Reply-To: From: Marco Elver Date: Sat, 5 Mar 2022 10:36:35 +0100 Message-ID: Subject: Re: [RFC PATCH 1/2] kfence: Allow re-enabling KFENCE after system startup To: Tianchen Ding Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C156C40004 X-Stat-Signature: xa8gdi987ourwjs31zohebs6yoqkt43q X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=lHnnCFcH; spf=pass (imf17.hostedemail.com: domain of elver@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam07 X-HE-Tag: 1646473032-752692 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000147, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 5 Mar 2022 at 07:06, Tianchen Ding wrote: [...] > Hmm... > I found KFENCE_WARN_ON() may be called when sample_interval==0. (e.g., > kfence_guarded_free()) > So it's better to add a bool. Yes, that's probably safer and easier. Thanks, -- Marco