From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68257C43334 for ; Mon, 11 Jul 2022 16:27:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1165940011; Mon, 11 Jul 2022 12:27:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC0B0940010; Mon, 11 Jul 2022 12:27:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAF74940011; Mon, 11 Jul 2022 12:27:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AA2A5940010 for ; Mon, 11 Jul 2022 12:27:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 82A1760AE0 for ; Mon, 11 Jul 2022 16:27:04 +0000 (UTC) X-FDA: 79675348368.18.AE6096E Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf22.hostedemail.com (Postfix) with ESMTP id 0A680C006A for ; Mon, 11 Jul 2022 16:27:03 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-31caffa4a45so54714127b3.3 for ; Mon, 11 Jul 2022 09:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MNiOG9VLTXfyIumAzSkdBTE4Ro/vczfTyGGlVgeFa4E=; b=TEsjKApZIm2eGVFXX6zjsDd7ABvdwUwkWxz0rYWMXDFUGDLUjnYfCbSEh8axaflEcf /XAr0TEV8rX+gPcA0+uljGw/dhOFVhYtwVaJfH/iJZzU8Zl9ttHoRuTvQCNKLVlL8au0 3zPqttuKlbdSz8ISmN8t7W1UOYA8ZrDRI5lCKPMSixLQXgh7Jn8yPSiKsQw08yTUdZL0 fLEnLlY1fQ4/ZXeGTZzytVnyhHPgk+fmSFRNyB3kHmNQtFfPUaq1d4vdLWJxwt9rEGwT oYED+Sgjnb2pGD++4nURXUCClA1/XfbK7RNX65wwZQAx6AsAxtCq6ItH03wFIU9LttK1 POzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MNiOG9VLTXfyIumAzSkdBTE4Ro/vczfTyGGlVgeFa4E=; b=LCRUWvLzQ4F0sacRtLUnkXDA8yRad9apq7yHd8MUeJx6GSsJo6hPBX1iLII1Plsmk4 +fH1KYmorlp6ryaGD2nt9g36ll/r2w6ViPdNI0FwtTvDmr488t3c0+lvm5BFOi/qOeLZ dCrkOdU283VxwMOQdw37ua8o26g5QS1CZm4UmVfQrgR+WHByJrEBbWm9YI0OlZKmJ71T tG1qIm3k77QEuot9y5zpN7Ykpb5XbEWaEBqvJ1ICgFJNzj22XUnIrzR2ERrgQRbgW3yo ekZV0pmCu4nueTFIgi6Jl/S1zffM5e02Grp/LrIaIRnOI5xTlJDcrXLQ0V44baQAmI8b 7fjA== X-Gm-Message-State: AJIora+aaFIHig6efO4LxLZFdygiZjjKlnTbWjIhOOsnYYCq0LgEdwx4 LkwoAW81OOBbyzJw6ci6USAOY5U+Vt7GMWoIqDCg0Q== X-Google-Smtp-Source: AGRyM1vFc9Nz3PdQYWOkyhyxSAnFDy6tbKimAKMs5WJU/DJQWlYu903flN0tTaSuogpfrJrZGoq5RrujLcEOvlsW8HY= X-Received: by 2002:a81:98d:0:b0:31c:921c:9783 with SMTP id 135-20020a81098d000000b0031c921c9783mr20064789ywj.316.1657556823180; Mon, 11 Jul 2022 09:27:03 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-11-glider@google.com> In-Reply-To: <20220701142310.2188015-11-glider@google.com> From: Marco Elver Date: Mon, 11 Jul 2022 18:26:27 +0200 Message-ID: Subject: Re: [PATCH v4 10/45] libnvdimm/pfn_dev: increase MAX_STRUCT_PAGE_SIZE To: Alexander Potapenko Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657556824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MNiOG9VLTXfyIumAzSkdBTE4Ro/vczfTyGGlVgeFa4E=; b=1Qtx+YBkvpYR1UbnFixGdhaFAv6B4C6K41PyowLxWBZLrY6S9A2o/o7mgE3FlCCX81CSnd VleiYZB/2m+u3C4cqGEwrviXmUQwCCL/6ViWX0UwGb56UvWZFhx+o0mO/3MmwrHMMNXKTY QrTqtM6+BMI8jV4teJWzZRgIi+/AnGQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657556824; a=rsa-sha256; cv=none; b=voGrBOeOeOBolAKd7VMTIUZW3sa4ZNzgL0XKkCF/F4pFnOjtMCbJF4kz0s35II6gU2Gp8P w2mnaVO+WtqmsN8blIHlkoWS2KDYW55edfNZDtfgfCjrWqwyzTWyQjk2cGfRRzW/AH4kMZ m157qbGjaNjShSXMx//OhbVDpo44bZc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=TEsjKApZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=elver@google.com X-Stat-Signature: h787ma4heks38emwumg5watdqucaz1nz X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=TEsjKApZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=elver@google.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0A680C006A X-HE-Tag: 1657556823-880717 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 1 Jul 2022 at 16:23, Alexander Potapenko wrote: > > KMSAN adds extra metadata fields to struct page, so it does not fit into > 64 bytes anymore. Does this somehow cause extra space being used in all kernel configs? If not, it would be good to note this in the commit message. > Signed-off-by: Alexander Potapenko Reviewed-by: Marco Elver > --- > Link: https://linux-review.googlesource.com/id/I353796acc6a850bfd7bb342aa1b63e616fc614f1 > --- > drivers/nvdimm/nd.h | 2 +- > drivers/nvdimm/pfn_devs.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvdimm/nd.h b/drivers/nvdimm/nd.h > index ec5219680092d..85ca5b4da3cf3 100644 > --- a/drivers/nvdimm/nd.h > +++ b/drivers/nvdimm/nd.h > @@ -652,7 +652,7 @@ void devm_namespace_disable(struct device *dev, > struct nd_namespace_common *ndns); > #if IS_ENABLED(CONFIG_ND_CLAIM) > /* max struct page size independent of kernel config */ > -#define MAX_STRUCT_PAGE_SIZE 64 > +#define MAX_STRUCT_PAGE_SIZE 128 > int nvdimm_setup_pfn(struct nd_pfn *nd_pfn, struct dev_pagemap *pgmap); > #else > static inline int nvdimm_setup_pfn(struct nd_pfn *nd_pfn, > diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c > index 0e92ab4b32833..61af072ac98f9 100644 > --- a/drivers/nvdimm/pfn_devs.c > +++ b/drivers/nvdimm/pfn_devs.c > @@ -787,7 +787,7 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn) > * when populating the vmemmap. This *should* be equal to > * PMD_SIZE for most architectures. > * > - * Also make sure size of struct page is less than 64. We > + * Also make sure size of struct page is less than 128. We > * want to make sure we use large enough size here so that > * we don't have a dynamic reserve space depending on > * struct page size. But we also want to make sure we notice > -- > 2.37.0.rc0.161.g10f37bed90-goog >