From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3FC4C433F5 for ; Wed, 9 Mar 2022 06:03:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21BCC8D000E; Wed, 9 Mar 2022 01:03:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CABF8D0001; Wed, 9 Mar 2022 01:03:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BA2D8D000E; Wed, 9 Mar 2022 01:03:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id ED7788D0001 for ; Wed, 9 Mar 2022 01:03:51 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 91AC88249980 for ; Wed, 9 Mar 2022 06:03:51 +0000 (UTC) X-FDA: 79223806662.29.2E6E129 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf23.hostedemail.com (Postfix) with ESMTP id 28350140002 for ; Wed, 9 Mar 2022 06:03:50 +0000 (UTC) Received: by mail-yb1-f177.google.com with SMTP id h126so2259336ybc.1 for ; Tue, 08 Mar 2022 22:03:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IupeTBPV0CwLiSouyNsLlNej2M8VfozXJBeb1wXs4oQ=; b=YX63l3TuBE9WHvkLnj96DmhUI8+x1TUv5ps/J4Wdbj/N6Hyybd7haDR3I08A5pxdlA +l2zeiIiDOTGGSSw+XV7u0/uKlVlUuIeRltWKMYPR+536T44a6R2gqtdTILVdexRCEQy sP6q5P82Y9efU/Hm1lecDTdhH7rArXYU6n1dwDO9JMIXLFialuF7CPM1T+/0QIPMm2C3 rNsB0xW69cm7H+et2JlGu2BYfFD/kkqMAr1K0zAZEVGhroj6EJf30YvKmCc02TR5tX7P PeVHn1U645aM4Oy1dFJ/Bv+EJYIi7kor1u1lljkqt9zvXBVPytkftVBdprPcCRKiP9K8 YeOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IupeTBPV0CwLiSouyNsLlNej2M8VfozXJBeb1wXs4oQ=; b=egkd02kx9qNUA9cdNeTPXcrL0B61fSeUwxMVetxeBy0iyT8PbsZx9IYZsOeSpOAvDD T7UfXYRdrCFd+J8nk4DlmObe+dph8Hc6Oko0yHQzAwmbbsa7s7W22PUuQCyEAZTJMLac ZbLXMBHs3qKVdSCbCtTYF6QMGJVm22IchEb7COwg334R60mNxcsqkLNnrdVIaJq9BAyI dWYy9UnpIb+KA7tu7/L9o5mhFa3hk0Qbg1bD9Q4hQpoEmAu5X3lSWLC8T55rKPtd/Xy6 tnMAUJFgNnLE6Mxk6pqOfdGkyhMgcag/KBsSiIo+pV0MzJGeZ+DWXSHK0+5KnUMkQuBF pBLQ== X-Gm-Message-State: AOAM531+AysIiTjepz07XhwYS2mgseIeR1nABNG29jc0CnE/f8/Aubun 5OzbwvMqLKpfBLzgjbFH/fS7zlPkJdBSJsqdZL4rjQ== X-Google-Smtp-Source: ABdhPJwMwHfZlnKRiebptjBPF0BQZhGKq+CXkoxVgCdFKhi4kh5G6U+X3lfyayuw+aUPTtdtHmrkaM0/ZtB9jQAQcwg= X-Received: by 2002:a05:6902:184:b0:628:233e:31fe with SMTP id t4-20020a056902018400b00628233e31femr14583650ybh.609.1646805830152; Tue, 08 Mar 2022 22:03:50 -0800 (PST) MIME-Version: 1.0 References: <20220309014705.1265861-1-liupeng256@huawei.com> <20220309014705.1265861-3-liupeng256@huawei.com> In-Reply-To: <20220309014705.1265861-3-liupeng256@huawei.com> From: Marco Elver Date: Wed, 9 Mar 2022 07:03:13 +0100 Message-ID: Subject: Re: [PATCH 2/3] kunit: make kunit_test_timeout compatible with comment To: Peng Liu Cc: brendanhiggins@google.com, glider@google.com, dvyukov@google.com, akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 28350140002 X-Stat-Signature: 9pwarzsfszgt7dddfprs1awds96a989o Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=YX63l3Tu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of elver@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=elver@google.com X-HE-Tag: 1646805830-487438 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 9 Mar 2022 at 02:29, 'Peng Liu' via kasan-dev wrote: > > In function kunit_test_timeout, it is declared "300 * MSEC_PER_SEC" > represent 5min. However, it is wrong when dealing with arm64 whose > default HZ = 250, or some other situations. Use msecs_to_jiffies to > fix this, and kunit_test_timeout will work as desired. > > Signed-off-by: Peng Liu Does this need a: Fixes: 5f3e06208920 ("kunit: test: add support for test abort") ? > --- > lib/kunit/try-catch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/kunit/try-catch.c b/lib/kunit/try-catch.c > index 6b3d4db94077..f7825991d576 100644 > --- a/lib/kunit/try-catch.c > +++ b/lib/kunit/try-catch.c > @@ -52,7 +52,7 @@ static unsigned long kunit_test_timeout(void) > * If tests timeout due to exceeding sysctl_hung_task_timeout_secs, > * the task will be killed and an oops generated. > */ > - return 300 * MSEC_PER_SEC; /* 5 min */ > + return 300 * msecs_to_jiffies(MSEC_PER_SEC); /* 5 min */ Why not just "300 * HZ" ? > } > > void kunit_try_catch_run(struct kunit_try_catch *try_catch, void *context) > -- > 2.18.0.huawei.25 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20220309014705.1265861-3-liupeng256%40huawei.com.