From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A6F7C02180 for ; Wed, 15 Jan 2025 09:48:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC2736B0083; Wed, 15 Jan 2025 04:48:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D728C6B0085; Wed, 15 Jan 2025 04:48:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C39B86B0088; Wed, 15 Jan 2025 04:48:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A2CE56B0083 for ; Wed, 15 Jan 2025 04:48:15 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4B1221A1178 for ; Wed, 15 Jan 2025 09:48:15 +0000 (UTC) X-FDA: 83009210550.19.4B0E2E5 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf01.hostedemail.com (Postfix) with ESMTP id 752774000E for ; Wed, 15 Jan 2025 09:48:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KMdzZ6Pf; spf=pass (imf01.hostedemail.com: domain of elver@google.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736934493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s3jfONnwbYBavfwqwjYW7TKQLCTKaMO0wDpfiGKHArM=; b=6JRheakAmLnWalQJQUUwSatOuASi5LnwY4iCxge15Wu+1wncaLnZyGvvDGh93K+JLJkCi8 bvowhgEQmF6iGrqJLpz+5SLSnlkCiPo7GlH0Bg9DSGlNlZbj+2t4TNqOwv5YfAxAHq1snO TH41eahPhQWB7TMNe1agveD3YVMegAg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736934493; a=rsa-sha256; cv=none; b=0CE5fQDPZjkHAemoVGAq8zndjaxX3VUkWFKAx6YHP6eFcm5dEuxsqFMq1ALfCw5yI/fEWA cP329kmwK30eh+7H2ZyoQ7M/wuNrfF3CLJnq8umj8gNTCrWnRmevaj3SVRsBzcs93HXNJi v/mHoaqZY8rX5ufZJMXpKPGD+IPNVgo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KMdzZ6Pf; spf=pass (imf01.hostedemail.com: domain of elver@google.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ee46851b5eso8557227a91.1 for ; Wed, 15 Jan 2025 01:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736934492; x=1737539292; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s3jfONnwbYBavfwqwjYW7TKQLCTKaMO0wDpfiGKHArM=; b=KMdzZ6PfuTk7Z8v1aHR6rmkAvHWyJycZjUsyHFb6vr8c+XvdD+FJRrz8gCxUpZEJ5a AxGlJuXToohuHstxYZUb1wDhybHe74Do6ibmrmXRSlfBtTv5g7EUhEKxaco5mr0ztW6z VYkBX7I3HEr0TX+2OVcf3dgCuOm6FKJ1YW0Z8dM+U8cpLp0brwVXA0MSLHG0fTWBwgJM Au2nJdadaRk8ybBgM8IV0qk7sxVpBLjPa6gJr45+sfiHFdY/zpSasinBAh3Q5n9Q7ni+ 9luZJsQnw6euI5rrg3PsbMT0RUGLECUhV/IFgmEBH//4m5Zj/HHMGuTQmoR1+ZRRK1GL gj1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736934492; x=1737539292; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s3jfONnwbYBavfwqwjYW7TKQLCTKaMO0wDpfiGKHArM=; b=ssc8N9Hhci1Rl2fzNTruIoIk9Fm7ncGxRae4lS3ScCIgmLglMKFtcLDrNiY53784nh NAlcLqexVkxWhYmXpPaGgCrKX9ZfiwfLTzfX8wYdt0q29bR7ZGVF9BxOqfZTeXk9oRln nKu0GVJk1FQNNS3CMwkZj39HxjfP4KX7FyWs9Pb6gywi5fPaMDQBiw3bY/0I9aUOohua O1pFkg7pSJc+awAIZZBxhwRdqAq6ldODHkwdZoQbm1xJTBVJEEgNZWAd25+psyLTxrIJ Yv1UMWuV8j9QpKoKZF4Dmq+4d17KmWNRSzSJohLP4RGZXeJwhN7ICHF5WLi5hjxzQl2R 85eA== X-Forwarded-Encrypted: i=1; AJvYcCVIZwiwkwCWbUgzfxR2MRYRyHH4iAzedNhu0CAtmygg60eVmlf0xqT594RkVi8Kl2kFa7PnMagQOw==@kvack.org X-Gm-Message-State: AOJu0YxAn0pInON4yRAKlolUlUz5Qbjjo0/o5R52nb+sqEzKjsms8pZ4 Zd/zDqhKEcfVBGKTTqhBc/+1fqOcnxjkjfXWDbb8cdQi6gHUfsom58krYUxYLfznkBc4by9NZJx RHfs4FpPq6qqkTzj+EjyJkda6xNaOmj72v9qVRFNU6T+MshCL53Jd X-Gm-Gg: ASbGnctaD9uWIv+aL/nTblUpUpw0h7qH+F7KXfA2HeC1l6mmwxEs5YdEj3f8pPweX/t tyjU2UUIoE7EvraVDgGqaiF4g5NtzcXwS3Bkz6Qn7iP4QNLCH3qW7RyhAiuA84wvdnpI= X-Google-Smtp-Source: AGHT+IEIVRahpUKBi63eaYONU3xV90r6yHYwr+1j0YD9ynxyEKbnF9JpVaWdn+9zXuBPawrO/MQvueW3mMrw4SNZKlI= X-Received: by 2002:a17:90b:258c:b0:2ee:f687:6ad5 with SMTP id 98e67ed59e1d1-2f548ea5b95mr42258470a91.2.1736934491985; Wed, 15 Jan 2025 01:48:11 -0800 (PST) MIME-Version: 1.0 References: <20250115090303.918192-2-thorsten.blum@linux.dev> In-Reply-To: <20250115090303.918192-2-thorsten.blum@linux.dev> From: Marco Elver Date: Wed, 15 Jan 2025 10:47:35 +0100 X-Gm-Features: AbW1kvY4BndOnAABBFjjdCNbS5eXARCMsrlemA1tLX3CWVG4AcGszK_WeqGMxJg Message-ID: Subject: Re: [PATCH] mm/kfence: Use str_write_read() helper in get_access_type() To: Thorsten Blum Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Anshuman Khandual , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 752774000E X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: gpzinfduhwz34r3qwu8katffxaqrsj8c X-HE-Tag: 1736934493-828562 X-HE-Meta: U2FsdGVkX1+CQVS0SRvLgNOHm6KfhYog0sPGIQ9Z7fPik+l8dE7aXsWkFm/0w39b7s5VvyrpZIB6wW1BsOqmxKXGZAfOA2iBDwnyVpFCmia2sG4czGkhaRSTdXMIY/t/HQpzq3fZZ1K+tBR/A/rqme+gGoX5TIAi3a3txmS3ZP5LN3I/n+O/lcd8W0pp33OloBl5xJobBgbplbLY7bPs9ZTc603Lfyo5qVh0yXkOfM1jBhl8KgBhQu7pRJUQyUhijzi4CvmsTnIb8gSTCst3DAczgAWUkrBBmBaT1kYcnbOrd5kxwtjmh/kFutJjWQzsuJgvqEBpZ0GtvVyMNz4Hy8raLMVh+8X/JqGRS1qXp/MPTO6qigSkZviRNBsRe0g0/anrqWXWBwKRkP/W7zCXWBTudbtQSgUVpz3xfkNVERv6B7JaAvd4er6tzSyV8xAE0k6CXFh7Vb8YCEzx1W9+iq30jMWAYhFNp8N1IpV7naYL+g/r5OB0E69v3ceqTB1TbPc6mQuaqBl9wyXmFfk90G3pGX/cEr+yFcoU7btxwuwx5zwR24GB7S0vIRn40lLHxdIXLsWhcBYpIAJ0/+IXfyjVZKvKToGeWBTR2MfCtPu3fAQ6a/xHrIDh3cw5lUZmhaxw20vLKofgpcSVfNdl1+xRakdFZMu8LDV7SKOZb5Vmuv+qsrw6hRV9XL5l7nVK7eRX+b8NdFtYRcwFrZf/LHmqNMSkjnjW6hMf+LcMlNnLLHxRon5P5pyvTu716OxLxWVF7c07uqGV4U7wtYNNaJSqhaouJCizbqEONMIfIREmkAIgAJcomkn145sxXqvCRG7SIV2ewXSqdRgqwbo/tyTsi9VsYqNe8rh3oir/yHrvghzV7TGygRgHbeEKAwpUADpo0T6AwbvMyGoJY3ShHnO2qZlxr9QI8tbbAy13KiHUasGRUTu12BnV5OmueYFop5BOdRW0ni3DeK/FwTy PArOWY64 j4Ib1iz/TQD8o/ny/3IcrR9XfwdXRdQ+jMzGdr2Z9huT+5bNoUGW1nAzic6W5/ciEXaqlyJC12op6UAHqMTiuCeKOxTtT2gSxbbUEvPYFlaURIJQ0jmDFwKcF2Oflx0ETYP32WZ6tTtUyyVTm6qiVOmuUUxP2JvUgB+0+haQC0+xUeOcKuL+Adfs1F7dwFv7jPXEPK4kafe0jSFj9pGofGAgcTbkO78LNfb8FfRSTZTGV/lPZhr2jupscinHU3Hpz0MpdyYBLIP54Zw9lR/G+4KesPEYz+q9Rw9DOnpTZnZA0MVKKNH8sOKlQ893CwCiGmbp3IjAWu+96U6cNKaZ+pIiD8kGHgzzaFgISyfZrfUZJX2nshZV56ZZgOvD6NSHXUBIj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 15 Jan 2025 at 10:03, Thorsten Blum wrote: > > Remove hard-coded strings by using the str_write_read() helper function. > > Suggested-by: Anshuman Khandual > Signed-off-by: Thorsten Blum > --- > mm/kfence/kfence_test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Why only change the one in kfence_test.c? $ grep '"read"' mm/kfence/* mm/kfence/kfence_test.c: return r->is_write ? "write" : "read"; mm/kfence/report.c: return is_write ? "write" : "read"; > diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c > index f65fb182466d..00034e37bc9f 100644 > --- a/mm/kfence/kfence_test.c > +++ b/mm/kfence/kfence_test.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -88,7 +89,7 @@ struct expect_report { > > static const char *get_access_type(const struct expect_report *r) > { > - return r->is_write ? "write" : "read"; > + return str_write_read(r->is_write); > } > > /* Check observed report matches information in @r. */ > -- > 2.47.1 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion visit https://groups.google.com/d/msgid/kasan-dev/20250115090303.918192-2-thorsten.blum%40linux.dev.