From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A8C4E95A91 for ; Mon, 9 Oct 2023 08:46:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C19E98D001F; Mon, 9 Oct 2023 04:46:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC9E78D0001; Mon, 9 Oct 2023 04:46:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A917D8D001F; Mon, 9 Oct 2023 04:46:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9664A8D0001 for ; Mon, 9 Oct 2023 04:46:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 62718C0190 for ; Mon, 9 Oct 2023 08:46:19 +0000 (UTC) X-FDA: 81325291278.01.0BD357B Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by imf01.hostedemail.com (Postfix) with ESMTP id A6AEA40013 for ; Mon, 9 Oct 2023 08:46:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Xr+baia3; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of elver@google.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696841177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z2RpbvMTdKoZ2zJiAZ7Z5I3rvjdlk66rFfj4n9j6rj0=; b=j/Vs8WOY49ULBmkJ1s83s4RZaG/vvMHU5L2Iav6pW8xieAxoQtllc9VPLH+cz3BGMbhfEm zRRdrK44CvV/tj/lee79Z5opi92n7aCKsIxNtlp0bnoZJlHR0YT9iMrupy2JCg+oQ3YIuJ BdTL/tXvhBLZp49me9d1UnZRkXootoo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Xr+baia3; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of elver@google.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696841177; a=rsa-sha256; cv=none; b=T/SO3PoP3GIM5NkvCFHsXE9eZXNImptWFGXxfxT5vtJ+ZdvoVMbiQWpbiKlk1SDvQcbDUz ZATxJdi51Tcg5hz6zgi1DhQ7qkg/RFmLR/Xpn8MJ2yaoe5fVDbtVnGtw49dQao5UHZON71 ZMsDuDdMrzhpEp/0NZqM9fSdH52Ig6k= Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-49aa8518df8so2935922e0c.1 for ; Mon, 09 Oct 2023 01:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696841176; x=1697445976; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=z2RpbvMTdKoZ2zJiAZ7Z5I3rvjdlk66rFfj4n9j6rj0=; b=Xr+baia3y4Gxehbv3w2+aw8MtTk5iUb/UX6ZkP8cE5Bm6HbPPRYPB6ZJ7Eg+lfGC/w wlylPmNyFSH6rcKKiLHaEEJCURJK5DVjLaifdKMyAkLLHcrIXjA5lgxKx8B8yj++viMD dqgq+h8cvRNZ7Z+e9UsuUgNHIAXS+Vanzc40AJw1f+O5bdg13KhMY9+qfYq6x07/jYtG YW5jNPRfCjjl2q2s7Z0sfDRg/lPyUTWjrvOD1lrMsF1y5l9CoqKRLhH4VJq+XE5N+tmC j+93QykZYmwzQjYNXQgFmMbEIVWUAHDqz5vl9xSniwOaYtZaaPGIh8zSlRgaoAYURs59 4RAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696841176; x=1697445976; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z2RpbvMTdKoZ2zJiAZ7Z5I3rvjdlk66rFfj4n9j6rj0=; b=GQWgqp3+gDWAQJMp5yumYA0+QWd99PSPOdmGjAbWyhOoCZnRgrMAWT9N9lLK/cUzyl qVTVoaf7ZqEwGzSt4WNYGE8t3WwvvjBGOaMfrTqL0Uj5XLtHpe/L+s6U5RPssc7HF9ab sB48fRJ4hdhpHyTdkSRRiQtGFlFIM4LFz41WYn/LsNDwXYQ+A3pTGHfvg/t19A4KqGKc O6dx9zi+kal5MLuRZzewepeNiKsSCZwAP5T4Xf8hYT7HQUmR6OmpIEYgvH/ebGJtx6+I vmz6A0/i3e4VXmfep5dSH4Ukx0iNdycFS1kuyHmpPECHJWk85bZcU7nx+e3FQdHbW3Cw /OFw== X-Gm-Message-State: AOJu0YzWtxub/aMQPG58opsCWYAJDbyKMH8DvS8ACG5K80pzVaNvGqhB sWiz0miOc9K1rJJXOmmgInKVhBgb9XHfj4wvp6UqNw== X-Google-Smtp-Source: AGHT+IHJAkG1xfrKUNuQ0TQrvXyaCe7agnEMJzL4WMrcd8MJmGF43xIyigd35G/FEsVM6J9ytZ7zIV7xpP6mYageJm4= X-Received: by 2002:a1f:6d44:0:b0:494:63f7:4e7f with SMTP id i65-20020a1f6d44000000b0049463f74e7fmr6815444vkc.2.1696841176576; Mon, 09 Oct 2023 01:46:16 -0700 (PDT) MIME-Version: 1.0 References: <6f621966c6f52241b5aaa7220c348be90c075371.1696605143.git.andreyknvl@google.com> In-Reply-To: <6f621966c6f52241b5aaa7220c348be90c075371.1696605143.git.andreyknvl@google.com> From: Marco Elver Date: Mon, 9 Oct 2023 10:45:40 +0200 Message-ID: Subject: Re: [PATCH 3/5] kasan: use unchecked __memset internally To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A6AEA40013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ad9mc6qfk3bfy1wrxx46yxgfuoz3tybf X-HE-Tag: 1696841177-426508 X-HE-Meta: U2FsdGVkX18RB4sUE4WeO7/VZKMIqp/FTcN5v38t0Yl4wI0JtlWxjs/36jD8Ujn7E/oCpEcEi4rZX5nqVSaz+258LSJHKxrzN4y+nvGMmlhypkm3vzs/I/Mn0gsja7OyQLytTLON7BaNg/Oeeq5EcHZiKFpr0ERlv0MFJVifrrt6btZnjk+CC+4RreTN68B3vJXQHZi/bVxtWt/ukRVI8it6h87+4Qdp28jI1N5tBt9L90Xt81tewhbXzew4MyoUuneNFu+Wn7CPYchowT4oyLDUCJJbNF8/N32xTuk/+lI9sR1xJLNPNGX0XMRTx+kXiY4FF3XNgwYzdgYfvUtvozOuK5pB0+EfTVxR99MH2M/jmelBd1mPs+JGIJg81OYnOvXafTFScm9kDbVdkwxZcP8Lq//3pnFStplrdlqXj8thiesEEMDe4yFMEiBnMHzEa+DlLxzgZKbf8+vM8pE5K1L2St+uhB7J2G1kBs1ev4S6kJmR0FWcdRmBX+CM+K+FwglvawQQ9t845o7W9v65Xb/p9JGQStym329e5tA3PH7lvPBz+WFLbeNtF5NGBNXr2eFbcf5twJCSc7mxZm/zSpODBREiAdnT2nNszgi8P4JBc4wIEemMD2eV+jNSGYKV0Me4lgE6+cvFYh3U0tWgYTbCsZQFO6xoWJIOATkGvUQt7snYIAd2yt3fWtGkeLCtnEhq/d67PNqjmS295Z4F+hrB7KdunsjHlM69Xj4KxauZpih9QXBYD3S0HEE7wFUgHDmaD/NegEJaOgDgObwL/rnHsNtrzGBkIRjVMq982JtgfLTuknhQc6BPDvIv8YrRONGK7JCnrZ67lBC8FtqNOrJbqt7f6LA+/21bR/pgfzNTNhvjHsEQ4GV4rjKqzV1KYSiVa57uL08BOfN3DvBZNXGFamz03I8I5CRV3BZTRYcM5bjhsw88tQgcDgjMrbxjjCGvD1U24JWUgzqNsEZ u8JPaNRO h076UsiUBvmvKlUtvzUEcXfT3nYnqejx9DDj1TNTjs1jyJGKJYgNk3NdAyg05DcjVHRMs3w2zQWNNkkxNPOFlFrZE+fwT7ajMjMifP7cTrPRWN/EmFka96xgOXtFcLDcY0RM0bOpjzG0rolgJ+qw9woK4btDIzrqrS+hvL6NqDHnrzXAtFjRBP5J0+0HBaCV+cMKR1Pqg10o4W5kUyVKcuLl99Epfc/wIyul16yUDjOoWZpS47zd0W+aLuJcVkFY1edKL3vEc+IhhbM6zPc2h2/wXpbe/svSrnDAQEzsokjxZ4fbeiZLxxwvoh994u5nhqqgaJxQ9/p+oQCRY36Sb4BaJuULdHyXI29dDTm7iSiia59xH7T21HqHuJmHGZwIPdIvzF3ejBPwQif12ZeuM2qTk1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 6 Oct 2023 at 17:18, wrote: > > From: Andrey Konovalov > > KASAN code is supposed to use the unchecked __memset implementation when > accessing its metadata. > > Change uses of memset to __memset in mm/kasan/. > > Signed-off-by: Andrey Konovalov Do we need a "Fixes" tag? Reviewed-by: Marco Elver > --- > mm/kasan/report.c | 4 ++-- > mm/kasan/shadow.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index ca4b6ff080a6..12557ffee90b 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -538,7 +538,7 @@ void kasan_report_invalid_free(void *ptr, unsigned long ip, enum kasan_report_ty > > start_report(&flags, true); > > - memset(&info, 0, sizeof(info)); > + __memset(&info, 0, sizeof(info)); > info.type = type; > info.access_addr = ptr; > info.access_size = 0; > @@ -576,7 +576,7 @@ bool kasan_report(const void *addr, size_t size, bool is_write, > > start_report(&irq_flags, true); > > - memset(&info, 0, sizeof(info)); > + __memset(&info, 0, sizeof(info)); > info.type = KASAN_REPORT_ACCESS; > info.access_addr = addr; > info.access_size = size; > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index dd772f9d0f08..d687f09a7ae3 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -324,7 +324,7 @@ static int kasan_populate_vmalloc_pte(pte_t *ptep, unsigned long addr, > if (!page) > return -ENOMEM; > > - memset((void *)page, KASAN_VMALLOC_INVALID, PAGE_SIZE); > + __memset((void *)page, KASAN_VMALLOC_INVALID, PAGE_SIZE); > pte = pfn_pte(PFN_DOWN(__pa(page)), PAGE_KERNEL); > > spin_lock(&init_mm.page_table_lock); > -- > 2.25.1 >