From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0752C0015E for ; Wed, 19 Jul 2023 10:55:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2288280053; Wed, 19 Jul 2023 06:55:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED23128004C; Wed, 19 Jul 2023 06:55:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B60280053; Wed, 19 Jul 2023 06:55:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CCC6A28004C for ; Wed, 19 Jul 2023 06:55:34 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 86BE81A027F for ; Wed, 19 Jul 2023 10:55:34 +0000 (UTC) X-FDA: 81028055388.02.152C000 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf22.hostedemail.com (Postfix) with ESMTP id DFF5AC0003 for ; Wed, 19 Jul 2023 10:55:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ZiKC0YFs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689764129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=crS3CSY6szxFlGqC0R3v++4ayIAdFFaeNUOCZ6hKf28=; b=qwz8zeXVJtFrVgZe0yhfwd4aXVbK5pDs7fwYVwU2ILQC8hovY4j0HMNh9R0UPWWw1yyS14 ktqfHoGfCmgxMJe3XGwe4Tof9COkm3IDx29Bqo/rrZX7d0xfFOYrbGsf9xk1ARa3MRnPnc ExpmGhT521l6DpTexmxxfulQz6Tm+Ik= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ZiKC0YFs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689764129; a=rsa-sha256; cv=none; b=d9HuTpR+MpJ2mS1gbv1fe2aFsVciM7CEQ0C7jr4WgE7XPUoPunuvf2263BYcIsKjeM9i5z NmiRRXfdHR1YlPEVF6cs/36Lo9TMrKIanl8CxdijP4SdXPSeRCoxWgsDtFfmPM1KNPFtL8 fTp7f5i58d7AWVqF5SFZbKw0aebPNuo= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4fb9ae4cef6so11182236e87.3 for ; Wed, 19 Jul 2023 03:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689764127; x=1692356127; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=crS3CSY6szxFlGqC0R3v++4ayIAdFFaeNUOCZ6hKf28=; b=ZiKC0YFsXf/R3jipNPfVIY5KgeG84dUlqbCtWAg6V8AGXiMt6ZSY+4RwN/+5X/ARVp ohUibp4WtghvVVtTMu1cmE4QEm32WEIhkPkIr/YkCJMNlrvmfkud2ckKdtu/1MLNWqYW gnpxURiqZXCNRB9z1xVBXfLF0A/W7mBkwHlmkH/mVu2FrpxYHTebt02mTQTdmy+23CLg tcBcB/K2MKP8W+B+r0cNtH0W3bKDGhds3yUjs3kCzuiq9Wx58Q//fwKGMc5J1cQiGudL N796KqjiS3J+cB6dy9MmerW57k0y0RuOtMfuYXA5iQ2lnwI8G34VRu8c5S4uQmiWUWS3 mYJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689764127; x=1692356127; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=crS3CSY6szxFlGqC0R3v++4ayIAdFFaeNUOCZ6hKf28=; b=JG0+XnFfqLfp/yDsFiJaGUWMVUUKaDOwujleZsa9JJG9Zw2JlFMSB+rPplbbR5yvaQ MqMvohKTAeXoF3GO6RD81D1RgnE0EXwo2hwVefIbtYIwczjJV996LOUAu50HmasaB0Nm 67IqBWpBQ+ujWasVlpOt5CWu3CQ/4aeCBVcwPK0FFQQumq0GLf4rEYx5XuJtzngEGSXk Hlf+9azquPL0ZtVMsFjTRm0SZYQyf0viUdmZuOhcDVKrKC1dzxsySGCXiiabd6J3vhcP 2TssBuNFNQLx14/om0eYDfJG+X9gx5/ZP/hCEIW2RcESO+qbEahUBKOH0BUcPWM9cZ6b X/hg== X-Gm-Message-State: ABy/qLZ3Gz3540QXzF7G0Mh23r6NvqqbzBIEY446vjWEVlxZKWnkaX+m EOghK4fPZdOyiTxxQHiDFVm5oRMDCZ26T2g99aX4Uw== X-Google-Smtp-Source: APBJJlHdvyvpRFFm1VTfzH+Tt0JUWjZvrNpoITi8/TcyUtirJ5DyLJrCuQnUxjvJp89HvM/AkCXAzbja2xsmXHz5sqc= X-Received: by 2002:ac2:4e8e:0:b0:4f8:b349:6938 with SMTP id o14-20020ac24e8e000000b004f8b3496938mr10924928lfr.65.1689764126796; Wed, 19 Jul 2023 03:55:26 -0700 (PDT) MIME-Version: 1.0 References: <20230719082732.2189747-1-lienze@kylinos.cn> <20230719082732.2189747-4-lienze@kylinos.cn> In-Reply-To: <20230719082732.2189747-4-lienze@kylinos.cn> From: Marco Elver Date: Wed, 19 Jul 2023 12:54:49 +0200 Message-ID: Subject: Re: [PATCH 3/4] KFENCE: Deferring the assignment of the local variable addr To: Enze Li Cc: chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, glider@google.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, zhangqing@loongson.cn, yangtiezhu@loongson.cn, dvyukov@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DFF5AC0003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: r75hxnetkio4miak1tnnjxonuxsegk8q X-HE-Tag: 1689764128-342300 X-HE-Meta: U2FsdGVkX19YP/0KHHvwrGHiFUbaIidqkLXN2qX8Ot13eCKCZKHW9IsCb1aonwj38GYW1lKrdiYTxpv8Hyznbsr/GMa7bHO1QHcHk6aI+ZImvXRxLO5N324GsqRho1zJmp0FDz/XKYLj2tyng7gQNklea3ssXToYeHh0sIJpRLCUESURHxWT2whi5rHQu++tmog0xsE55Mvu9fBRQ5ztAmpNUqj7L/FVX0W6Qotx26RJcc/Q3wglFFQdCqTszEHjN9zb9eHGd1Iobq6eNHJ98LAvu/MbezC38AABeQ2qnITLpt08+I0wWYe+AVFCmKDfszsgXSe7zCzQdTOOEchO6cWDim82TMGHZG2qBkDc2DBu2Jja4TCkP5FiwvRo0vLp1ZvUkXgYYFWzxP64ZpUVfZ0md0KAiVqAjmbUCV1jZQXkNUGEUPxwHjwWkz4nBNJleja1w/+85l1b2yoze7OK7/EyGwtLlPiKSGUC2ptCIZROjc3GOUi9OS0NsWAW4nMsb/E15cJ9eUFLRkgRcW8yCbSGYmQVCVe3rEHOaN99ZapARUK1O0AjWhGRyS9awHCG190Cbu3B4qHM8Zp/lVl/Ydr7u5oNenWICv4Ff4dDgOoPdp5mPG+AicQGfGqJ9J0ieJoYOzpoxJvwdnpe5PfpAr5Cdn9Q36rV28UTXff5MXmc//JXbq9zhGTqLK/494TpDN8WeC4eT4pOUOoE99Ddlz7zkv+6t87BNDyqTqYyO4f2UjTfDZJMXz2gzbrHdNKa+3WUpvEeH7UWc0x4X+FbnwmsYmJtYWSqAiazr1piTBUUAzQq9uZYFRfcNDmgsvjPwyBAHNtOQKjSYInyFZKxcrfuWMc2zgmBoeUx8iO6UK8auHc8alnMrVpOB1G62Wc38kUTHUfvVpO+o8r0XcSSogRtKpGeAAgReZULeKT+cx8GEYoo1JT5xsSvuBded3u4A6UwxqL3fn78gvHAk4e JHFkEPzm xWro9in7fVTOii5hlqy9zJ11PiCaDs9bKQ/z2kBGn08POkF5dGJF2AEfe/25St3Z147I1Jr2tBqQeSs1zAVd08RWMa7tc8c1QWifdwOU1YN2Ir+FTBC071gCLCENtaKs4ANCxd2iGLVvK04T9W+RUwpNQkAnQt/RwioLCf4ud+8Ltwekk2mNs+3b7yL6WBvEKsS9oTlnHye9EZ45yhuu75mhQU56i1rB9FwMjLSvHI55X6+88HXkVqPMBHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 19 Jul 2023 at 10:28, Enze Li wrote: > > The LoongArch architecture is different from other architectures. > It needs to update __kfence_pool during arch_kfence_init_pool. > > This patch modifies the assignment location of the local variable addr > in the kfence_init_pool function to support the case of updating > __kfence_pool in arch_kfence_init_pool. > > Signed-off-by: Enze Li I think it's fair to allow this use case. However, please make sure that when your arch_kfence_init_pool() fails, it is still possible to free the memblock allocated memory properly. Acked-by: Marco Elver > --- > mm/kfence/core.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index dad3c0eb70a0..e124ffff489f 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -566,13 +566,14 @@ static void rcu_guarded_free(struct rcu_head *h) > */ > static unsigned long kfence_init_pool(void) > { > - unsigned long addr = (unsigned long)__kfence_pool; > + unsigned long addr; > struct page *pages; > int i; > > if (!arch_kfence_init_pool()) > - return addr; > + return (unsigned long)__kfence_pool; > > + addr = (unsigned long)__kfence_pool; > pages = virt_to_page(__kfence_pool); > > /* > -- > 2.34.1 >