From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63309C433EF for ; Mon, 21 Feb 2022 11:15:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6C338D0002; Mon, 21 Feb 2022 06:15:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1C298D0001; Mon, 21 Feb 2022 06:15:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE3598D0002; Mon, 21 Feb 2022 06:15:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id B039A8D0001 for ; Mon, 21 Feb 2022 06:15:25 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 571DB9731F for ; Mon, 21 Feb 2022 11:15:25 +0000 (UTC) X-FDA: 79166531010.08.9E2EB88 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf25.hostedemail.com (Postfix) with ESMTP id E6C22A0005 for ; Mon, 21 Feb 2022 11:15:24 +0000 (UTC) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-2d07ae0b1c5so133863967b3.5 for ; Mon, 21 Feb 2022 03:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aW+puJnFP6GDgHHGWDtmoEv/OAIRXfNxeTuS1KHKS4k=; b=ouaPUyc5S5AFk1T7BxP0W0fhHLsDrC1X05D49SErp1xkWV9WjlDmH/BG8/BhlD++F9 AT+4MGNLApzlCASeujOqYro1ZV8advB1PdCWuxdmmgixehhzJykeKLDDOqbMg/JkzY/6 rnq12h426up1wRYeC10q6kegTee8TO07+5um77gBiNcyGEaIORHSDfbUM1BstxfamRP9 grWcbQpNcTxhADWewkL5NuY6rahD3ZCPdUdpAAEpS9eI5oznaRHDJmcFixfdLNo/u+WN E8+LgKgf0MghrhwbqqY0TSVIs7YPxomaod3TrD9B1Eoi7ak7V39fxTeek92jejy85ncN TLyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aW+puJnFP6GDgHHGWDtmoEv/OAIRXfNxeTuS1KHKS4k=; b=RCLPL6P70MXkuQdFcBkG9sfp8wj0i6YDJFaU3atYiDcGeswRBjQd40w9HPHRRmLAPu t2wRDLjErj52gXIkkFFEOyYedHz9fWJkKQ3sutwYqCGy7XQ/CxnrOW6iA5j69lXqY59U /NjvpgNpau8Gyu4G4CP8EMBjkjBl9uo+qVGbYLkqKdUGfq+K1uYcC5rLAOHfYPU3ZGzl R8TRm5HoWGoM/+OHLUealZMaPiBrUNZBBPMwejoskqvl9X3PgSqHiZD6maogKKN3jPiT kzuaZgKlDYsOEDm55aATjTxS74qvkHRqyrHRPF43Q+CSSqNqfrwEn/NVi/C5Dp6jFNMz jFTw== X-Gm-Message-State: AOAM532dEIs35WOOWx6HptOOCEf17Gt0qZBMiak3Umc2CzH3utxHNstO Gitx9HT6X0oZtyx/CNCc0COspVD42OvJ0rIHooxbCw== X-Google-Smtp-Source: ABdhPJyE6n7bniNE5YxwK4dvryGKYZY5CGm6vwxplnSM1NRRpYP8o6nDdeY+frPLwgGsECDDDHkRoX52uu4YXmh5jss= X-Received: by 2002:a0d:fb07:0:b0:2ca:287c:6c97 with SMTP id l7-20020a0dfb07000000b002ca287c6c97mr18617337ywf.316.1645442123922; Mon, 21 Feb 2022 03:15:23 -0800 (PST) MIME-Version: 1.0 References: <20220219012433.890941-1-pcc@google.com> <7a6afd53-a5c8-1be3-83cc-832596702401@huawei.com> In-Reply-To: <7a6afd53-a5c8-1be3-83cc-832596702401@huawei.com> From: Marco Elver Date: Mon, 21 Feb 2022 12:15:12 +0100 Message-ID: Subject: Re: [PATCH] kasan: update function name in comments To: Miaohe Lin Cc: Peter Collingbourne , Andrew Morton , linux-mm@kvack.org, Andrey Konovalov , kasan-dev , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E6C22A0005 X-Stat-Signature: 1qpafdf55co47bx8now1u1768agbgx13 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ouaPUyc5; spf=pass (imf25.hostedemail.com: domain of elver@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-HE-Tag: 1645442124-301591 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 19 Feb 2022 at 03:00, Miaohe Lin wrote: > > On 2022/2/19 9:24, Peter Collingbourne wrote: > > The function kasan_global_oob was renamed to kasan_global_oob_right, > > but the comments referring to it were not updated. Do so. > > > > Link: https://linux-review.googlesource.com/id/I20faa90126937bbee77d9d44709556c3dd4b40be > > Signed-off-by: Peter Collingbourne > > Fixes: e5f4728767d2 ("kasan: test: add globals left-out-of-bounds test") > > This Fixes tag is unneeded. > > Except the above nit, this patch looks good to me. Thanks. > > Reviewed-by: Miaohe Lin Reviewed-by: Marco Elver And yes, the Fixes tag should be removed to not have stable teams do unnecessary work. +Cc'ing missing mailing lists (use get_maintainers.pl - in particular, LKML is missing, which should always be Cc'd for archival purposes so that things like b4 can work properly). > > --- > > lib/test_kasan.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > index 26a5c9007653..a8dfda9b9630 100644 > > --- a/lib/test_kasan.c > > +++ b/lib/test_kasan.c > > @@ -780,7 +780,7 @@ static void ksize_uaf(struct kunit *test) > > static void kasan_stack_oob(struct kunit *test) > > { > > char stack_array[10]; > > - /* See comment in kasan_global_oob. */ > > + /* See comment in kasan_global_oob_right. */ > > char *volatile array = stack_array; > > char *p = &array[ARRAY_SIZE(stack_array) + OOB_TAG_OFF]; > > > > @@ -793,7 +793,7 @@ static void kasan_alloca_oob_left(struct kunit *test) > > { > > volatile int i = 10; > > char alloca_array[i]; > > - /* See comment in kasan_global_oob. */ > > + /* See comment in kasan_global_oob_right. */ > > char *volatile array = alloca_array; > > char *p = array - 1; > > > > @@ -808,7 +808,7 @@ static void kasan_alloca_oob_right(struct kunit *test) > > { > > volatile int i = 10; > > char alloca_array[i]; > > - /* See comment in kasan_global_oob. */ > > + /* See comment in kasan_global_oob_right. */ > > char *volatile array = alloca_array; > > char *p = array + i; > > > > >