From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B415C3F2C6 for ; Tue, 3 Mar 2020 20:20:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F1FE620842 for ; Tue, 3 Mar 2020 20:20:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="erfB9EEX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1FE620842 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B5FF6B0006; Tue, 3 Mar 2020 15:20:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 766E46B0008; Tue, 3 Mar 2020 15:20:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A36A6B000A; Tue, 3 Mar 2020 15:20:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 4F29D6B0006 for ; Tue, 3 Mar 2020 15:20:53 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 99AF0181AC9BF for ; Tue, 3 Mar 2020 20:20:52 +0000 (UTC) X-FDA: 76555169544.10.bear21_7c08b3e946029 X-HE-Tag: bear21_7c08b3e946029 X-Filterd-Recvd-Size: 3897 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Mar 2020 20:20:52 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id i14so4404004otp.5 for ; Tue, 03 Mar 2020 12:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P2kzWYnhHNwPKndZNxUfTV8Fu7co3KaoSWSaF0iBUUU=; b=erfB9EEXH1OrsG7ZoHatHAnCFvM5uXNWzBvJHrxa3PNccf1O+8LugRnExtYFRWJ5uP 2ZqjCuPbZviv5jOvIxmKCZnwfw8ScajoJUrA+m5KKeVbTSsYdgKJ9qAxw/Mb6hguDJhf SE1UHtlKMKKFU1aAGNlUdg2pdNbzs5xFlhwsBnNnlqrO4d8AuoETisVrThfpVWmQlvBv BFJQiMXCMPLtvxA8V7bQaoOzoZFUkATmzjsnw1J1asWEzusfJxBiy+lFK2SOprNGT35+ 1kSaP+2YgMYsUU0nxd+X8t6Tly2u9E4NzvvFBhP8CCV9LIknKelxkvLF9g2KMlwJp8Zm GP1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P2kzWYnhHNwPKndZNxUfTV8Fu7co3KaoSWSaF0iBUUU=; b=Y5LzzUxQHJkTgOJ2tNSEndw67sX5zbL+XUUF9UEBe9VI1HybaMi6b3EbVj8+dJNM5C J1zqlhek9wvF5Ar3+ScOCnB1TJnr53YvoSPJYPC6HAMOHF/tfxwIIH3mcWlFKgHCrzWG qfutF/dq6WfzABDMuLDAaz/sTVj1meJ9QaI5W5bcH4az1ziV8x2HZoFMtDRfwTYlSTe+ xoHfGkJB8eDFQdQDBejNDXXUk3E4rEB+d0ULNVX/kGdOBxb0riTB3cH1wcrXH/gP///k XKXltUC9pRs0X8c42RvyL5khX87C/aelB7db2Ly4DxV00JgNU+g9U6UUYQTOm10qTlrt OEXA== X-Gm-Message-State: ANhLgQ1vjW7UBze8Mr0nW7NiM0PIOaw7d3T5iXoTafxzuwwhqLmFYUlY R4WwP7fuYafvCF3AzOeyngLlEUoWX5PdoWMjyScedg== X-Google-Smtp-Source: ADFU+vs2DtsvTbW47OVOu6Ao9H1B1gjgvRzFxWp+o3Hao6p4+O9zUgSqehDixn13kp4U4VInFxKDQNdyTxgN5AhhznI= X-Received: by 2002:a9d:906:: with SMTP id 6mr4419945otp.251.1583266851521; Tue, 03 Mar 2020 12:20:51 -0800 (PST) MIME-Version: 1.0 References: <1583263716-25150-1-git-send-email-cai@lca.pw> In-Reply-To: <1583263716-25150-1-git-send-email-cai@lca.pw> From: Marco Elver Date: Tue, 3 Mar 2020 21:20:40 +0100 Message-ID: Subject: Re: [PATCH -next 1/2] mm: disable KCSAN for kmemleak To: Qian Cai Cc: Andrew Morton , catalin.marinas@arm.com, Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 3 Mar 2020 at 20:28, Qian Cai wrote: > > Kmemleak could scan task stacks while plain writes happens to those > stack variables which could results in data races. For example, in > sys_rt_sigaction and do_sigaction(), it could have plain writes in > a 32-byte size. Since the kmemleak does not care about the actual values > of a non-pointer and all do_sigaction() call sites only copy to stack > variables, just disable KCSAN for kmemleak to avoid annotating anything > outside Kmemleak just because Kmemleak scans everything. > > Suggested-by: Marco Elver > Signed-off-by: Qian Cai Acked-by: Marco Elver Thank you! > --- > mm/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/Makefile b/mm/Makefile > index 946754cc66b6..6e263045f0c2 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -14,6 +14,7 @@ KCSAN_SANITIZE_slab_common.o := n > KCSAN_SANITIZE_slab.o := n > KCSAN_SANITIZE_slub.o := n > KCSAN_SANITIZE_page_alloc.o := n > +KCSAN_SANITIZE_kmemleak.o := n > > # These files are disabled because they produce non-interesting and/or > # flaky coverage that is not a function of syscall inputs. E.g. slab is out of > -- > 1.8.3.1 >