From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2603DC001DF for ; Fri, 4 Aug 2023 08:39:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 963002802D9; Fri, 4 Aug 2023 04:39:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 914482802D4; Fri, 4 Aug 2023 04:39:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DDCB2802D9; Fri, 4 Aug 2023 04:39:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6F6B92802D4 for ; Fri, 4 Aug 2023 04:39:03 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3F92EA1330 for ; Fri, 4 Aug 2023 08:39:03 +0000 (UTC) X-FDA: 81085772166.13.94C8152 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf12.hostedemail.com (Postfix) with ESMTP id 626D340006 for ; Fri, 4 Aug 2023 08:39:01 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=4wbtWBqY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of elver@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691138341; a=rsa-sha256; cv=none; b=wY5V/augBwpqCfR/OW73+7nbDRwT0rUV/xrIZeyZeUF7aLTRHXrWy3fefmYTjnHYo9auXF jv+MSe1xTuFwfStYeFp1av1T9OUDnfrWWeZLU9EE/ysosKPstF36UKn3jcXN7T4UzwCE3K u4kvqu40qzGax3FS7ppvJDxxkED80Zc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=4wbtWBqY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of elver@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691138341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jQoJf42Fd/g+GKy4ubOkk+li/mbuiTLSPOgxMQ9ZBj4=; b=oQwj0XZVY/a0aPFZ1RkLuZfxtHgnR428JdFMzaO6mytY8rdI2PcO/JwACn4hzKhldat9rH KOBtBY923vhlLbecxNWQ6JU1eBiiTCeqbRF6UpKbP5eQoPumsCvYs7EZezIaIcThRxAOJI oaCPek7XM/G+7SU/i1hVfYPY6xqS1Eg= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3fe2d218eedso18157235e9.0 for ; Fri, 04 Aug 2023 01:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691138340; x=1691743140; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jQoJf42Fd/g+GKy4ubOkk+li/mbuiTLSPOgxMQ9ZBj4=; b=4wbtWBqYa9d46u042FMjLzzWiutHrAZHd+XdXgXZjL82Jn/OyVyM4qeu1rVnJxxYLO qgg+RpIX8KWR3ksW3YgJLxBdrzT4k0FfVYpETBhJ2htvevZnWgZ06vuGgKafDjY79pND g+eHyq/xOfGYqmAXRHGHQ7deki96r49afuzFDCtQo/1ar+sHkaEa8fozsFmfaQOL4sEZ hiob2uogFDqFrlApdRnCwtoGoN0+l/i4hBndBzTJvKPh0ivS4jzROganDwrCfRBJNZ7d iVuQc+baW0nn/4I6zEA9+IP8g1VdFjTN4P/kv12EbZNHByvSINTX8DRg46NCdKgk/EGw 4Rjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691138340; x=1691743140; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jQoJf42Fd/g+GKy4ubOkk+li/mbuiTLSPOgxMQ9ZBj4=; b=KISkE5/OUU2kvksQ1R/wruB3MmTg44ZjqsldZGk7uu//DFv3WmqSyWWaXMmKJca2qs IKjsaIFE+I/5z+bA8gKOBUbJow50QKJrJ62W3Vs859BW+fVeQKUopqdLocAp+kefaPlZ NwddeMChphzNRjcVsy8Np6AXDAa3AgPKOpdloecEkeubBs711iRA3iHLs83ACK2ayHtj Be51AFGUZhrGu2CFKassGiFFmL7+EZvGRiZQRc1Q3cNXBJLcvUAqdx2CxLyf6q+KW0fR rII+xH0bDHTOrgkXq56lvuDcGn2yQ3sTYqK6dlb5wo9Tl2cBzW6Znk0HT4swSJPyid4T kfTQ== X-Gm-Message-State: AOJu0YwbAXKK38FDWNyPOv1oCLj4NiT3BOCDFfeiIjs+YK7CyfKIirTi N5t5mrob7BTGcO3HV3UcAVM8jA07K4zmDU1g2HVeeQ== X-Google-Smtp-Source: AGHT+IEkpSwsCCculoDUh7U7kxEZUNr0bPhh+2T8rUewy+rf6a9Uskt25TFrovjrcD2Ept4C8udzGv7nn2FeMRHLdaY= X-Received: by 2002:a1c:4c13:0:b0:3fe:485f:ed1b with SMTP id z19-20020a1c4c13000000b003fe485fed1bmr897546wmf.28.1691138339742; Fri, 04 Aug 2023 01:38:59 -0700 (PDT) MIME-Version: 1.0 References: <20230804082619.61833-1-andriy.shevchenko@linux.intel.com> <20230804082619.61833-2-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230804082619.61833-2-andriy.shevchenko@linux.intel.com> From: Marco Elver Date: Fri, 4 Aug 2023 10:38:22 +0200 Message-ID: Subject: Re: [PATCH v1 1/4] lib/vsprintf: Declare no_hash_pointers in a local header To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 626D340006 X-Stat-Signature: 67pbmfm8kyn8fbcjz7wdxrn4wwha3dqd X-HE-Tag: 1691138341-830366 X-HE-Meta: U2FsdGVkX1/HG4ZtIDnE10IIrO1/M3ergzmJghzXAr66ob2KtUfUnC5yVD3w/tJxx1+JrQpY65m8Wnz9s0eaea/HAiKBMuq3os+hnKUTCi6oUslmm+1FXkmkCaPfC7iku/QziashF5O1I6C44xci6TTK8h8qUjQnAub/ce1PG6KyBWqNnEaAjScGcR7GHg+twI54yQgLRqxiECdbLKlNc05N9GRejA89a1N0kI8cHMPJ80VsgCbufgO0E51IaQKXYsTRZ3GBQAra/3rDXXexanByVlX7TfEEyzDrxwnAi0QMeSpIzR3r34kpICSJftAwILJBBRC3DjzocdePdHQFryOwzb7VE4ItFRsVBXQbu4KKG2GqYoIGljEUNAyIqOmRpyr73D+Vsx7l62CJr5bIaoZoDEU+4FBNTcr168KIuWLuVdDJI4tf3455tDJ/mi2XgRh12D3YNBOEn4YAiqkR4KfpWMdQOfghqvJvcb/YkTg4M43nHy7GSj6Bh5vphRhoy/z8koCkf5ibOhZxqtCCeqA1CFq/eL7DMY2HKwvaAjCAW74W497kEZX4CM0YGzZ+scGkt0l+cIQhzAmkFzKNRC5ta+AEEDcI6UaZnTgFIm5FqrlNcDGJxtZdUDYvrP5ns5FPGiOBuu/TFwTDzx1ndBRt19Ln8dO9btSJXYxQUDTBES4qnIktbKleT64dyO/SZ7cd9lZn9mwk0XUiWThG9gbcV9OYkBtykCKyOxz5ositXo62j4OTnJ78PmrBuILitpM+gNM8b0ONS2WNUqQsXQTdcVKdJqWwNJPGLfezZ1PjfPxfuQYM2dKxZyKYspE910nTxONJ9t3sQ1sjJlVTf8MKq1KsGD6il3TUqUCr/Ziq6uqruPIUXzX1eaEE37Xyn78UVLTTvICb03Ej0bNA6ApdsO9UyEvNHSjKbiCSfZdU20oqo+twvNBXFIrM58GnGvf/mRV/lDrb/rPqUnT AdbK/J+2 OuGXOlN0dQ4JveQA3Q5YaZ08HnEM/pUhZpKEH8g02YhjsTBWlR2nhOtbBSaUvueLXwhxwjoijAJ6A3LxbGhHZBkOMmj6vata3D0Uo4mhCHVQC+GuyTEEXoYU3jvkdDnLlemI0gvucYJP6tqBK2dPnrqjZNyNeJeBrRTOvs9+Ma3PAP2y/vhEwgjcwRP0G3UBdIkB2ZDAg2ihMp6yTwkEbTIDuXhDiTTrnN9LdRXu20bXHR7vSc7rIn4cxuJVyysYVDSvkzTygx4caZB75rE+d935V01Ri3bbAGbz9xpKCZSRPWsRfelIwoVTu47yT9/NM1dYiIZElEJ3EvPY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 4 Aug 2023 at 10:26, Andy Shevchenko wrote: > > Sparse is not happy to see non-static variable without declaration: > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static? > > Declare respective variable in the local header. > > Signed-off-by: Andy Shevchenko > --- > lib/test_printf.c | 4 ++-- > lib/vsprintf.c | 1 + > lib/vsprintf.h | 7 +++++++ > mm/kfence/report.c | 3 +-- > 4 files changed, 11 insertions(+), 4 deletions(-) > create mode 100644 lib/vsprintf.h > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 7677ebccf3c3..9e04b5f7244a 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -24,6 +24,8 @@ > > #include > > +#include "vsprintf.h" > + > #include "../tools/testing/selftests/kselftest_module.h" > > #define BUF_SIZE 256 > @@ -41,8 +43,6 @@ KSTM_MODULE_GLOBALS(); > static char *test_buffer __initdata; > static char *alloced_buffer __initdata; > > -extern bool no_hash_pointers; > - > static int __printf(4, 0) __init > do_test(int bufsize, const char *expect, int elen, > const char *fmt, va_list ap) > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index 40f560959b16..6774cf84e623 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -54,6 +54,7 @@ > > #include > #include "kstrtox.h" > +#include "vsprintf.h" > > /* Disable pointer hashing if requested */ > bool no_hash_pointers __ro_after_init; > diff --git a/lib/vsprintf.h b/lib/vsprintf.h > new file mode 100644 > index 000000000000..ddffde905824 > --- /dev/null > +++ b/lib/vsprintf.h > @@ -0,0 +1,7 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LIB_VSPRINTF_H > +#define _LIB_VSPRINTF_H > + > +extern bool no_hash_pointers; > + > +#endif It seems odd to create such a local header and then refer to it from other subsystems. What's the downside of just putting this into the new include/linux/sprintf.h? If someone wants to access this variable, they will one way or another.