From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66C6CC27C6E for ; Fri, 14 Jun 2024 14:37:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 121986B0115; Fri, 14 Jun 2024 10:32:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A90796B0173; Fri, 14 Jun 2024 10:32:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF7906B0142; Fri, 14 Jun 2024 10:32:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4DE926B0173 for ; Fri, 14 Jun 2024 10:29:31 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 021478073F for ; Fri, 14 Jun 2024 14:29:30 +0000 (UTC) X-FDA: 82229727342.20.54E705E Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by imf03.hostedemail.com (Postfix) with ESMTP id 40F4420014 for ; Fri, 14 Jun 2024 14:29:29 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zB7Hz6e3; spf=pass (imf03.hostedemail.com: domain of elver@google.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718375366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+M4MVfQsxov5VdJSZaNFx/kfeT/vurY02zgZoKqlOZY=; b=SqI2R+joY26/WhfI9AO8Yfy7li6L3Tat5LiJetCXniB6iwATqchH9xuVzbbjObpOR5ITBK E8gbzamT/T7FP6smiaEhuIxU3vrh8+c1RDDx/p2cWWiK5N1kX7WseN66DItz4pskSZSIKS VekXOg1fWjseqjFuqD8WjeeX66mCHSI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zB7Hz6e3; spf=pass (imf03.hostedemail.com: domain of elver@google.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718375366; a=rsa-sha256; cv=none; b=Qf0/hd6VpFdVSjSYvS1iUKXkLOb37bXSFyEXgfhYE1uJ7QMcUueXgCFN4x13JgsxsEQIoh DwmUlrV3BSpceWU/+zGbtcX4AOGpXBvQ5r0AXpEXL0b1mOt4FWfj8kK8Ii++fbm+CmeZbl beKUT0f++tOVZH5KspZRr5BybFMhg+A= Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-4ecf0d18bc9so671373e0c.0 for ; Fri, 14 Jun 2024 07:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718375368; x=1718980168; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+M4MVfQsxov5VdJSZaNFx/kfeT/vurY02zgZoKqlOZY=; b=zB7Hz6e3UFe20wv5ahT+DvGw3/Pqlq6HCWhXpudeb8dyjf05VTmxIbK8oOu404ZPR4 KilNkxbi2UJbN6VjaJx0JzOFqgFVG/2evDWH22ar6nDhHL8JIQ7C4u/vnQNdWJfsMp2V hPxg7yNiQJirWK/KfLZFGiTUoKDJPyg6Wf+Ij1dz7PpgmcSDSZJXPQR2gTTJfIn8HgpZ 9XapJa4lHrcw+0Y/i+cp42G42WCmw8olTQQuQjVUu4cIbodcJuJCJTiwqFceZNiaTAi1 OAP4F7qb4moxXHN7Z4JF5GtYxUsT475mQ0RsNTqO/cDsOjO5CPBoDxruYYAXWaL5HcCV 8bUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718375368; x=1718980168; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+M4MVfQsxov5VdJSZaNFx/kfeT/vurY02zgZoKqlOZY=; b=bhuW9p0KSKA6hjmIc+ik/VYkZqtk4aOIpkWjzND08lW7jTgD5YplEYg/NIGlIqmYQ4 AdBJuysJwuVuJeMEOm14ZF2POlMMOwbmXFJux2PRiObXJiRRkJLo5sjvNZPbURStY3yr QDn7szq2KRmo89fs5Ir3b3WV8FJ9GlmCNf81B0QHWScpx866FB3E777/oF9XH2j21+lj vZ7zvssn8n2J4NF3aLSoiFuL68pJmrEgubR7pi+XFAi3SkF2KaWSvW29P15c58hp7pom hj4UR4ygrVdbeBf1ZnY4GpetuquRVh3X4UcmcTRA3+/uSvDboFkLJqJWXMKBAOT4SC0v gj3Q== X-Forwarded-Encrypted: i=1; AJvYcCVZvSRNFuMSl+ZfnSodP2MoQrJ4wy+XnAnlvwHcaYUyJRCXNraSQ9iOn+eecTULZsKKDbfcV58Yl2SFjMIhlD9fQ14= X-Gm-Message-State: AOJu0YzToMZgFPWZ8yMSEHQVhEzpjY9pbQv4SOkQraPyQGWDipK/fJTK i/dE2TT42EM+gFUyDZVp9Yy9pd8Eak+pZyg8VOMGQoTEZptjKDjYkRuzvyxbI+A/uQbJ0PxstFf NnhuTjjPcSlYM6UrTY9XA0YmRPudKqPNofKGg X-Google-Smtp-Source: AGHT+IFvLtBsNkt/EHH9zb4a3GIp+wU2qWyVRWUEWGarYvJcHCO7wVvPBLT5A6iMQRK8HeLel0TcH1bgkYM/oBsiR/k= X-Received: by 2002:a05:6122:1d8d:b0:4d3:3a0f:77ce with SMTP id 71dfb90a1353d-4ee407328c8mr3639955e0c.13.1718375367706; Fri, 14 Jun 2024 07:29:27 -0700 (PDT) MIME-Version: 1.0 References: <20240614141640.59324-1-andrey.konovalov@linux.dev> In-Reply-To: <20240614141640.59324-1-andrey.konovalov@linux.dev> From: Marco Elver Date: Fri, 14 Jun 2024 16:28:48 +0200 Message-ID: Subject: Re: [PATCH] kasan: fix bad call to unpoison_slab_object To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Brad Spengler , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 40F4420014 X-Stat-Signature: 5989cz3qkoxbnua6w3gaseqy87bxa3mi X-Rspam-User: X-HE-Tag: 1718375369-795914 X-HE-Meta: U2FsdGVkX18qVq80Q+uBjWq5zFOQOLVCMoGkjNI/vFWYWe517zy12t7D+B/rj+xGoCV7+WaXXjCO+1q3fxS2bFWXXqRy1POjzONm6srB41QBW+gYsdYW6USx44CkoZAjE1OtYAs92OutdYxtUD35bbDkm/paTtC/HznCGD4899NbkcrC33mzUoZKEwXy8qXjYVQF83eyK1VAPv3yYM9yLVLGjVl0CVTTT1zz999hbaTOV7h2F3+dGcE3a+Ij6K6LVUix0E6QNjQSKOBCgpMzw/XUDfsDZSI7hUh9Dz6TWat3fK4HJimnUYgNxXQ15hhQQVx3sVeimiBcJJ4GYIswZTmyopKKh68mB2talzs9MvgVnVjsWkvOhhbSHj+XUqWEMP68NbnmAWk6OpGVIjpun7jW3UDzrxCLIZB4BKc8pjIBeeQbUX0PiMAvY0l8sbJvkmPSCE53VhN1YyrfFsAiN+7MPg8IB2QSP8veYwQgOoHbEaF7SJ/jdyTNmkazhzEQnIp44mnoiJG4v8V5TQnCq48tVsQuutGDtloXnPdii28xMXftOoItQGTjxTC8GZ+0puUAUAT4PmuHQ8TNOdVLHgyIDfB0561A6P41+f0U/Y2stNsw1v33rmK3sWVG4AE1ZEs82tMqDywAW/LeX4cQ9ui+q1KoN8hL0hQJe7MHtnR7gtTdA56AAtZu/cYlLypgUeq7kE/IoTu2lEXYtZn6zfByRIsROtQ6ndkjye8oY1UKEY6T20x+H2ocjzvTXMOpZd4Wbq9ZW9DjfWUsd+ZJGUx9yxkPbxZWlWYbbqefX8pkq+070x6dAnjBh1vJCNDukxbdsS4RvUihMqYcz5q3NmAx1ID+LFDcX9n38UncG5kfJOohCpQcodx6bO6y8kJUqEzYuvVDSsSsbrJrXU8Bm32bYp8mgkTy5IFJSN93ig0DYyXbAjBltLlKmUQkI6upNjZVkkVCuAG2Tv3hUQr WhOT8A2C jl7Wfhm7sDEBN+Ixjuemt9a/g3tEGR87Ps6UoxSOXuIvONe3TyaZEDx+BM0pYwx4PjdI0ldmQlsZwARKii329J2xvBUFFG6Q2TtHT9Sxo9yHc8PxRcgbuwWdRXB5SQ+tTCDm0oqklwhl9hxSzk0bbw8AGB2ldVB6FVab7A0y3oDfbXoSTVei88p2D2RIiVHWGwF2s7Rd36DXIQHx2c+1LLbLRkjE7+GQcMllZOJQdHtwyBnJQ/uQFf2oesD4tSYOa10WVksYgryD1EBIaFnZmowFXa+nZ8jjA5eRQo//KSUzS9SufgUgQxQOipKyl92CrSFDbaQqtKP1NBPT75i6zoIFtaN3L2jKKvXTEmVO36GpEdhJzTvbPiUBWa1INg4mpRKlSme55i8g77fY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 14 Jun 2024 at 16:16, wrote: > > From: Andrey Konovalov > > Commit 29d7355a9d05 ("kasan: save alloc stack traces for mempool") messed > up one of the calls to unpoison_slab_object: the last two arguments are > supposed to be GFP flags and whether to init the object memory. > > Fix the call. > > Without this fix, unpoison_slab_object provides the object's size as > GFP flags to unpoison_slab_object, which can cause LOCKDEP reports > (and probably other issues). > > Fixes: 29d7355a9d05 ("kasan: save alloc stack traces for mempool") > Reported-by: Brad Spengler > Signed-off-by: Andrey Konovalov Oof. Acked-by: Marco Elver mm needs explicit Cc: stable, right? If so, we better add Cc: stable as well. > --- > mm/kasan/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index e7c9a4dc89f8..85e7c6b4575c 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -532,7 +532,7 @@ void __kasan_mempool_unpoison_object(void *ptr, size_t size, unsigned long ip) > return; > > /* Unpoison the object and save alloc info for non-kmalloc() allocations. */ > - unpoison_slab_object(slab->slab_cache, ptr, size, flags); > + unpoison_slab_object(slab->slab_cache, ptr, flags, false); > > /* Poison the redzone and save alloc info for kmalloc() allocations. */ > if (is_kmalloc_cache(slab->slab_cache)) > -- > 2.25.1 >