From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09928C6FA8E for ; Thu, 2 Mar 2023 11:23:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C51F6B0071; Thu, 2 Mar 2023 06:23:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94EB36B0073; Thu, 2 Mar 2023 06:23:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EEAB6B0074; Thu, 2 Mar 2023 06:23:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6CA536B0071 for ; Thu, 2 Mar 2023 06:23:18 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3B17340F16 for ; Thu, 2 Mar 2023 11:23:18 +0000 (UTC) X-FDA: 80523722076.08.EE3F7D3 Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by imf27.hostedemail.com (Postfix) with ESMTP id 78F5F40004 for ; Thu, 2 Mar 2023 11:23:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PIN9Xd0B; spf=pass (imf27.hostedemail.com: domain of elver@google.com designates 209.85.217.52 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677756196; a=rsa-sha256; cv=none; b=fHj/gYQkqWssrCBHyWuJ3c3H5CunDCk1ycvyHYpHwogJ34x8mUYCIWqoBdgXNv2VAZE8AY dCKauxbsEc/PqfSz78ZdxykL+iZTusQ336g4uLN4rL15HM5AANZwPjHB0GMzcCdjMKSxPj 82RwMKzIfz2DBEk7xGqW2Enky3UPHJ0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PIN9Xd0B; spf=pass (imf27.hostedemail.com: domain of elver@google.com designates 209.85.217.52 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677756196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZXJcpekVJsbf05nQkG74Sggw1Qq7M2Hhxe/99xjhW+0=; b=5vurIOsxogDUN+FqADird5q87iSM3do0CTim52x347RKG3xX8paBYzcJAkeD9xQAe4FvYu wuyRF6slTdbYRwXxscYltE28NF5yqJl+DqS/koe+uvbQgUPYKyPVMiho2C12r4b6YKoFou QI1hC5bp7AQJhD8ym04ZX0AjJseRQPY= Received: by mail-vs1-f52.google.com with SMTP id o2so22045730vss.8 for ; Thu, 02 Mar 2023 03:23:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZXJcpekVJsbf05nQkG74Sggw1Qq7M2Hhxe/99xjhW+0=; b=PIN9Xd0BS6NZmE7GIp9DfduhYOcFG5F3437KwQbDfTMk+mHR9ICEpZcUJWafSRmI2n 9/hB6hmJmyTZlDgR223DpQt7V8PfZUNWKRqwi2sU+/LS8rHYQmF9otH1guS2aYX1IfCC wmFl+5l/Hl0d4ab6+Mn8YficsrHpAwgpyEsmVrCnQVzfKqNqaKIn6eZHcNLfGdooz1Hk Pr7Ifvdokus8dk60vHGd7RY6t5LFyGHyn6xfoR4cIaFmdRCU3c2ttyo/LI9/MwtcdyW0 0KvJWY7AZd/LalYwL2JDhTdDnIhUxygnFD4v1GEJZYez0LCKBTdjTITCIaMVt67g4AAQ cJEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZXJcpekVJsbf05nQkG74Sggw1Qq7M2Hhxe/99xjhW+0=; b=m5J/QIe539Oz+wKFH+2W39SKNQpyk8amwOZ47Fc6dkg0gMiLE20zJ9FBvmrHWc/Dl4 UW0xCnRdpue6h3dJHTzPUyV83xxNafpyOUPTE0otgxy9W5H/QYzHGW7fCtHRzvIwK0f7 tnc/0nqN4ec9egRn7DzMvbcIuvB4X4mxPD+kvi+2/cNfUBxMvmpTlAM4gNLSlDTWVdLJ hiQDIhYSKsfttsrc6qRbMVbKtdxiEV0kFI5QQqDMRTTTCn5ic5PDT4EdTu1Bb+mfFKYn R0w4H3GiFrupF+OIRNGgswkYy7LvlAdaGAWtYOr3BnYuYKeV4evNNwe8wFweqM7Ud+0E HM9w== X-Gm-Message-State: AO0yUKUajPm01g957Ey/qQ9fEZPx5kr2BTMRfhyzcTJAfnOPKMHIFLZr Rx/SzPApX9qruDAj7mRMhhi4+p3VFmKCX7lxIlE+zQ== X-Google-Smtp-Source: AK7set/jIWJRqDWo7AdMl27Z2cGJ9tTD2Y9soJ5svr/gGiePeoQZ21mQhPpNv0T6BykpxNdBwtsC0lwsoVbx2Cuv/2A= X-Received: by 2002:a05:6102:10c5:b0:412:6a3:2276 with SMTP id t5-20020a05610210c500b0041206a32276mr6437205vsr.4.1677756195604; Thu, 02 Mar 2023 03:23:15 -0800 (PST) MIME-Version: 1.0 References: <20230301143933.2374658-1-glider@google.com> <20230301143933.2374658-4-glider@google.com> In-Reply-To: <20230301143933.2374658-4-glider@google.com> From: Marco Elver Date: Thu, 2 Mar 2023 12:22:39 +0100 Message-ID: Subject: Re: [PATCH 4/4] kmsan: add memsetXX tests To: Alexander Potapenko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, akpm@linux-foundation.org, dvyukov@google.com, nathan@kernel.org, ndesaulniers@google.com, kasan-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 78F5F40004 X-Rspamd-Server: rspam01 X-Stat-Signature: syh91o6r6cfewqb9w1uqh6j5nzwpjyhh X-HE-Tag: 1677756196-940561 X-HE-Meta: U2FsdGVkX1/FALOsR9UwDPPO4lRDyiyZ3LxkoqIfDV9En3LjkH8/s8Ln3RLnj3jc1aGYZMpke/NE2dlzsPY+fgETv1l9VMG3QjLjH0U6e5+RRGPgDttuV91OXg5CQdqrzLyMMIqp/ktFdsL9lNsv46457HpvaQ71K+fzjWHfPGFcCMr3xnKnbm7xAMuOevpG1gpkD9CTWygCaVw/RUM4kwqY1KwE4JCe3olUp4gZajNB0Qyz/TpzhbZ08s0do3fwOOTO8Z+7DiAE3opMfwu+kpGkzdIBjRSGp9rZDD8qjJt50TnJQI8bK/h6dshxc+04a0R5DgYwJzl6BQPtfMVbkdU7vizfxn+5mn5/nWHMDhzw5VGWgztRI5n6I6WIlU1Qk63795QUPDGFkKHFPVWOZ6Ox+2SRagFnJy40lDnfHzPS5FXAKvOSo8amokpIqN7Dpd8CnwSI0/uvesTyFTWuLhj2MhSsI8DSfnrH4codNvuKP6oUHyTXUwnGIhfzohRHo9IvvTq4DrQzSDo8Ij1fKGC9HuxJ1j2vzCdOWTqJoQm2nvsa3AbcNaB9Pm3uwHtrKRiV/u06qrd8h/wBv5c9xpA0TBu14BK2Zog7cmqZucanOZIAppLcQ5rptpfmfTfgeEXoeJXt2yuhC02R9OwBGXC2VILdwiogZzZveAeL+uFGaWN/JLe5bwoA7otIu4u4JVuF/xT2TL3V13TRz1ofuJNrtrc1xlyAPTRixU1BXUPoZGrUvGA1mQ0kPLolVDs/lUGy5GYcfBbbRI3L/+9hwrV/4BvPHYIsLlP3M84eXVddKwEhq0WNrb8S6C5SWUjPC+01hMeIiQdhsGjoEuSJxL77ixHKAruaHAPD5tpGubT83zHsmoWeH/7TQiceeJ0+rNPL2hGIU/OqKqGFg9OhvIgGIcYF//GatZpWUM8bNybJLEjtcoVHWrawrLt1ETbDGeHmqxHUR1K9ZuLDTgw oT7HWZGn RRz21fveAcUfagCCIFRJQxFHTnmELiRDYnaGzHs3rLsvRO8Giictco0Gx5eIOTS6ZR6cL7xAMTTzKxryc1zY0YStASMza1ZniA4lFMFEM1j/DUd5rBVSboJo8dWX+2xP/rnIui7BW7KriIL6oWS4uN8a650Bgi75LzZbmBTdPn5x7EcNBL16PLnXBw3L9Rt6XAbQmenQ9yFNjHIoHh4Pz+3Xfnd5TYKParuBAI9ZgvCj8FXB9ivqYtVpWGvlp4/t1EYELYrjwK0F6268= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 1 Mar 2023 at 15:39, Alexander Potapenko wrote: > > Add tests ensuring that memset16()/memset32()/memset64() are > instrumented by KMSAN and correctly initialize the memory. > > Signed-off-by: Alexander Potapenko > --- > mm/kmsan/kmsan_test.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/mm/kmsan/kmsan_test.c b/mm/kmsan/kmsan_test.c > index cc98a3f4e0899..e450a000441fb 100644 > --- a/mm/kmsan/kmsan_test.c > +++ b/mm/kmsan/kmsan_test.c > @@ -503,6 +503,25 @@ static void test_memcpy_aligned_to_unaligned2(struct kunit *test) > KUNIT_EXPECT_TRUE(test, report_matches(&expect)); > } > > +/* Generate test cases for memset16(), memset32(), memset64(). */ > +#define DEFINE_TEST_MEMSETXX(size, var_ty) \ > + static void test_memset##size(struct kunit *test) \ > + { \ > + EXPECTATION_NO_REPORT(expect); \ > + volatile var_ty uninit; \ This could just be 'uint##size##_t' and you can drop 'var_ty'. > + \ > + kunit_info(test, \ > + "memset" #size "() should initialize memory\n"); \ > + DO_NOT_OPTIMIZE(uninit); \ > + memset##size((var_ty *)&uninit, 0, 1); \ > + kmsan_check_memory((void *)&uninit, sizeof(uninit)); \ > + KUNIT_EXPECT_TRUE(test, report_matches(&expect)); \ > + } > + > +DEFINE_TEST_MEMSETXX(16, uint16_t) > +DEFINE_TEST_MEMSETXX(32, uint32_t) > +DEFINE_TEST_MEMSETXX(64, uint64_t) > + > static noinline void fibonacci(int *array, int size, int start) > { > if (start < 2 || (start == size)) > @@ -549,6 +568,9 @@ static struct kunit_case kmsan_test_cases[] = { > KUNIT_CASE(test_memcpy_aligned_to_aligned), > KUNIT_CASE(test_memcpy_aligned_to_unaligned), > KUNIT_CASE(test_memcpy_aligned_to_unaligned2), > + KUNIT_CASE(test_memset16), > + KUNIT_CASE(test_memset32), > + KUNIT_CASE(test_memset64), > KUNIT_CASE(test_long_origin_chain), > {}, > }; > -- > 2.39.2.722.g9855ee24e9-goog >