From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914FEC4338F for ; Thu, 12 Aug 2021 08:59:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2DC9E60C3F for ; Thu, 12 Aug 2021 08:59:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2DC9E60C3F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A5FE96B0081; Thu, 12 Aug 2021 04:58:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A104F6B0082; Thu, 12 Aug 2021 04:58:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FF848D0009; Thu, 12 Aug 2021 04:58:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 772A46B0081 for ; Thu, 12 Aug 2021 04:58:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1C8151807CAB3 for ; Thu, 12 Aug 2021 08:58:59 +0000 (UTC) X-FDA: 78465828798.11.8488936 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by imf07.hostedemail.com (Postfix) with ESMTP id BC6381004AA6 for ; Thu, 12 Aug 2021 08:58:58 +0000 (UTC) Received: by mail-oi1-f178.google.com with SMTP id u10so9284999oiw.4 for ; Thu, 12 Aug 2021 01:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=glSRtZn0PFX+XapwdsQxtT//X4Ni5wcQnHCn2+naPE0=; b=UHg5LO9a6h4YMLmtIURwo12v57QKDIMxCUykfKcMR4UqfxdWKLCkThvo4Zz4fnXZbO oPTjDMSeqwgGAUFRZL47F7L7dDap+mM9lQrpEbdTj+V1PPl2mDD0sMqoAnar7gxzq2tK cYaMYMloamBz+t6QO7cTKHRk51NzB+Ic6zfRoHcAdWbx7UP0vj/OSjR3aED9sEORUm1+ d6h08PAArp8Tk/cEYNCBdttUirJXx8yW2XhuJYG3BY/R9Mr5NJmGGc7ttrikeI+hVDfW YTBcxefrIvMsjgjYk8LvEVO/pppWtOVwtsIA/SPDqkM6fJ5j3LKWu1cdAmt3vfEgrIYV wQAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=glSRtZn0PFX+XapwdsQxtT//X4Ni5wcQnHCn2+naPE0=; b=SgB1qOdT626pm+OuOVsy4NOhNEVN0Hcvo/cGxib8u5/3LGbv1j9H98Un4+4j1G3zI8 /v2XGDgsadfl+FiDOVYhyLIvwzc2BCuJoPitkZLL2Fv5V/h6Gds/gSDDJAdNgTARjTaz WXBemS9mmsn+ucuBGtn5cpDBPM+xQTppoMWQ9vcxlrfm9DDJ7fS1GuNKpEbBtzJ3IQZk m+XXbz/d6fJ9VlxlinrPhHkXs1R8GRlrjdqHYgwH7i6oUS5WPRPbnIuDUtzMUqtRqLOu fgn6esQSyj3gF6Y/BKTAj1ajaW+l+CTde8PVKrLm0MOIHt7ns8X1jaPWDFI7EhJVf/6D m+Aw== X-Gm-Message-State: AOAM531fG+I9waIkGsKzIiG4h8cimfnvCTWVGIVXHgV5z/dee8PaNEZr /j+cIFeNyq6wJYbEA2uiNXHJO7QAztHDRfQaS5J+WQ== X-Google-Smtp-Source: ABdhPJztYAQ5HI2PE0ZBReSLN1qSUw8KPkARULQ7RPk0jCEXnuCUozSBipIHcxboDnnLJ/ZPkj/n3nWl76t4BMWSGYQ= X-Received: by 2002:aca:eb8a:: with SMTP id j132mr2513361oih.121.1628758737993; Thu, 12 Aug 2021 01:58:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Thu, 12 Aug 2021 10:58:46 +0200 Message-ID: Subject: Re: [PATCH 0/8] kasan: test: avoid crashing the kernel with HW_TAGS To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Dmitry Vyukov , Alexander Potapenko , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=UHg5LO9a; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of elver@google.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=elver@google.com X-Stat-Signature: jkppxs7ji4kah34hgmiwj5chn8a6hymz X-Rspamd-Queue-Id: BC6381004AA6 X-Rspamd-Server: rspam05 X-HE-Tag: 1628758738-72444 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Aug 2021 at 21:21, wrote: > > From: Andrey Konovalov > > KASAN tests do out-of-bounds and use-after-free accesses. Running the > tests works fine for the GENERIC mode, as it uses qurantine and redzones. > But the HW_TAGS mode uses neither, and running the tests might crash > the kernel. > > Rework the tests to avoid corrupting kernel memory. Thanks for this! I think only 1 change is questionable ("kasan: test: avoid corrupting memory via memset") because it no longer checks overlapping valid to invalid range writes. > Andrey Konovalov (8): > kasan: test: rework kmalloc_oob_right > kasan: test: avoid writing invalid memory > kasan: test: avoid corrupting memory via memset > kasan: test: disable kmalloc_memmove_invalid_size for HW_TAGS > kasan: test: only do kmalloc_uaf_memset for generic mode > kasan: test: clean up ksize_uaf > kasan: test: avoid corrupting memory in copy_user_test > kasan: test: avoid corrupting memory in kasan_rcu_uaf > > lib/test_kasan.c | 74 ++++++++++++++++++++++++++++------------- > lib/test_kasan_module.c | 20 +++++------ > 2 files changed, 60 insertions(+), 34 deletions(-) > > -- > 2.25.1 >