From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C67AC61DA4 for ; Tue, 14 Feb 2023 06:08:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 375576B0073; Tue, 14 Feb 2023 01:08:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 324CB280002; Tue, 14 Feb 2023 01:08:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EBFA280001; Tue, 14 Feb 2023 01:08:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0BB636B0073 for ; Tue, 14 Feb 2023 01:08:06 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BB47C1C61F1 for ; Tue, 14 Feb 2023 06:08:05 +0000 (UTC) X-FDA: 80464866930.27.B62EBB3 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) by imf20.hostedemail.com (Postfix) with ESMTP id 0EED11C0011 for ; Tue, 14 Feb 2023 06:08:02 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="FNiC/1wr"; spf=pass (imf20.hostedemail.com: domain of elver@google.com designates 209.85.221.170 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676354883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+nVV5Ba3Z7LEjnraYcY3XOVAg4sdVrhWrxDDszwimc=; b=nC5WE08/vdj4a7Vav955rL9Bwqiz77DLNTgAEJao9feJo+iGRyVeJzpuHyfgkzgcZ0SWtq l3qy+P4YF+WnZaV92KbW0UU0t49dfdVC3o7eLpaj4eNi2wnw5i+OJhcI6uYhQDuexrv17h uwgpdtHPF/DT9YAWsbLP46q6qDuGBw0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="FNiC/1wr"; spf=pass (imf20.hostedemail.com: domain of elver@google.com designates 209.85.221.170 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676354883; a=rsa-sha256; cv=none; b=K8npNoswhYilrEPx4ajyu9hehRVpDNMAzDiAshGz+NzV7q84ROQqLl2KqlNbbjuC17bmnD Hjr7HiJ6pH1N9O7MxXMHRzOJ3/r4ufP2s5W93vPOSA2TBw2faOh3SyymfPVWon/RI6Ca+m vrFi0Cgtsy45T3hKKb9rhaQy3nfxJ6E= Received: by mail-vk1-f170.google.com with SMTP id f17so4903352vkm.2 for ; Mon, 13 Feb 2023 22:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1676354882; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i+nVV5Ba3Z7LEjnraYcY3XOVAg4sdVrhWrxDDszwimc=; b=FNiC/1wrGp4NJ8oCUZdHlK/+r38iPxWS8UfDndQGWukyI4wyamp7X2ltuHwIwMRIp5 vuK7K52MlVn4QfRTzEym05tDXEWm5QEPV0YRelm1LzM930Xk69zadhZDonD7PIGz9+TJ e2dmbLK6O+JkEhu81A8gsDSznUjDu0s3Bt9xOtk+VtCORdXJEhx1xIw4exI37/BmmOqE X33KY3jxhiokmVVSmo5Mxd6ML81n9ktXJ2bjmjdKIY2t3z1/FoXIGSNo8Bee10c0er1A 2BkVXefCOWE4MYvILmkRIJES48vvjFLHKRq5QceeTJfMBNv54ce6k4z8jGm0FC3itZ8m hitA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676354882; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i+nVV5Ba3Z7LEjnraYcY3XOVAg4sdVrhWrxDDszwimc=; b=lw9iXzNTIbVgYFD24koZfqtdGkZgxo5NTCmHLvO2Rppfo0uLdKZUMtUqZxtgOSfNZ0 N6aXgmW8PHjIJ7MmqdF0slQ+O9BH+bB4W6AxqPwKb4SDUQ+QiyLGrfYIgpPg15exvqQD uFzNUBKPEzsU8oCdBbz6c+cCfNamh0eJk+qevP4tQQpRh1Hfg0sS3QH3TcWAI2ocd4g/ wEtmFBn1xhueIDUPZyaTW+ADDKiQ7fHJAnBDgc4bno3FDALTI7ikOcm+7yt1aMf8oN/u ezBMEHrHl7PS9DaqG54peDs+0M3JY7aowCxwZy5HTcxWjwRlDwCxSwZ+FZFZv0jDcVYZ 5t4w== X-Gm-Message-State: AO0yUKVjVyci23OMjC/h1AdfR2a00P3cafmEPOQwzi1Ac7C6rVHPP5Y7 wtMy34MKo1yEb4C53XuVm14KcaG9zld14tm0u53TAA== X-Google-Smtp-Source: AK7set/ovk8zGfBhnXCZ5kjifb1AK0CSWtL1GQ956rLYgMhdqnq2dvJx+6I9gn5rWGg48BJEGan7qFp8aOgSfRBDFG8= X-Received: by 2002:a1f:2012:0:b0:401:5cb7:dc92 with SMTP id g18-20020a1f2012000000b004015cb7dc92mr191751vkg.1.1676354881939; Mon, 13 Feb 2023 22:08:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Tue, 14 Feb 2023 07:07:25 +0100 Message-ID: Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints To: Peter Collingbourne Cc: andrey.konovalov@linux.dev, Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: t1t5ywyiz19ujw79jf6pxo8hkx668jkp X-Rspam-User: X-Rspamd-Queue-Id: 0EED11C0011 X-Rspamd-Server: rspam06 X-HE-Tag: 1676354882-230684 X-HE-Meta: U2FsdGVkX18+7IQ6DgWA6AXKRA0yn1aNPtnrS42bc1ra1LlM+6Fu/U5HslF8islm1zLOSHiOXYG8PZ+X+3qhfL7P1ZvcGAjoPGquevhND4VVi0+NAwQ36iTp8+WcHJl9ow+4vPlSaYqE4cGhWxgj8P+6LUerfEbkwHNxFD4QWwpvkx0VpOrtzA7/FjXE9fYMRLaIs+6TbEmJWgKSJkjuV3QnBA0r+zFIe04qBVZVWoAtcIcQ9JfW4EzwIu/pBZTu/AVT3fz849sQdD/Qi7axbrznc8dQPM2CQp4e6UBQmezrkD2Bx9HtYzdyltlaQ6cVeSlY44H2oeF4qpGIT1OuqJ66Gt5+K1IFUaXNvSVxTZnc3S7QK6E1HTm5QSfCNGl7fKFugOREpqMyRbWx9DTcT/LcQtwL96aBgmkPZyAqSNcKO53fzkGaeJrGHnHYJrtyyMRz8uoNuC4ipRKQBQ23l5rddQAdu7CZdnu6nkKERvT5sTJ1Yhanz9TvMO/OctaVNy3X22oaHhlr3EG2zcddNxNmKc9+6oaBg6cIJ+Z7wkG/ZsO7TFzDZveXUtuiLCp3C794ssPiql6Cxog6EGp4Z9Rt8SirWE0YAewQfLM03D/O7rgstlHGZk0DCdS1UrP/cZd6SIwY6zqef6rBT2VIlbjsZUdXc56dbcCo+gGNavcjSxWffgLtXdNEncdoKXd2momfvQIYoA8Bt+WrYt30SCnJK6ApUwOQ3QzHi22Sh1XMHUCBpfGjy5WMPR90m/elXHrjbcCspTb7xlZsjJttH9kmeRHq8yoqRWaVFkDpstCJ61wRoqtoe5fsvgNFVltR7fqbkdw0fChOK0mGddBhfDzWN6hDQZBZe7RSTL2ifLlGFbGWxE54NJ7zPDkXNCLF+NtNyRKFQc07BqmYlO6ww19UYOhqdVsZkYn65Dz7O57UVUgx9gkjLOuvDZC8POrj4de8YBb5LqEl+ujB3wx 7w6RRESp ZaRbDHp6IeaIHOpZ6pov+s8gevM/zd36E6sBmXchHpA9wSyhsjQKHB9lz8Vq1oejecceiyYhvddSpGfW4W7KgGIEJD8zRBkYoDMkuD+RJBOWoKZNGNKSfCTiA4HcfBNU9+szClZTPMeGnZLFllOvAH0xuryuwirXst6U9Y35Fw4X+YPZdRzkNhfoNwBcIDJSBEN2ML4pilmHxQj16jam8zKqufbXAGSgJv7wQqwhBBqVJZgtu7QWqPhI6ZGjL2YG0wZM372ECs675794DwegjnMUDp/KjB4kKtAFDzqg5YY8AFtHNk3GcGZLyE4ocme8F5jsbAR0VzM2Pmh+MCta7WwgSGmposhot/T3804gp88MJfnH/ODNWVQS2sw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Feb 2023 at 02:21, Peter Collingbourne wrote: > > On Tue, Oct 18, 2022 at 10:17 AM wrote: > > > > From: Andrey Konovalov > > > > Switch KUnit-compatible KASAN tests from using per-task KUnit resources > > to console tracepoints. > > > > This allows for two things: > > > > 1. Migrating tests that trigger a KASAN report in the context of a task > > other than current to KUnit framework. > > This is implemented in the patches that follow. > > > > 2. Parsing and matching the contents of KASAN reports. > > This is not yet implemented. > > > > Reviewed-by: Marco Elver > > Signed-off-by: Andrey Konovalov > > > > --- > > > > Changed v2->v3: > > - Rebased onto 6.1-rc1 > > > > Changes v1->v2: > > - Remove kunit_kasan_status struct definition. > > --- > > lib/Kconfig.kasan | 2 +- > > mm/kasan/kasan.h | 8 ---- > > mm/kasan/kasan_test.c | 85 +++++++++++++++++++++++++++++++------------ > > mm/kasan/report.c | 31 ---------------- > > 4 files changed, 63 insertions(+), 63 deletions(-) > > > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > > index ca09b1cf8ee9..ba5b27962c34 100644 > > --- a/lib/Kconfig.kasan > > +++ b/lib/Kconfig.kasan > > @@ -181,7 +181,7 @@ config KASAN_VMALLOC > > > > config KASAN_KUNIT_TEST > > tristate "KUnit-compatible tests of KASAN bug detection capabilities" if !KUNIT_ALL_TESTS > > - depends on KASAN && KUNIT > > + depends on KASAN && KUNIT && TRACEPOINTS > > My build script for a KASAN-enabled kernel does something like: > > make defconfig > scripts/config -e CONFIG_KUNIT -e CONFIG_KASAN -e CONFIG_KASAN_HW_TAGS > -e CONFIG_KASAN_KUNIT_TEST > yes '' | make syncconfig > > and after this change, the unit tests are no longer built. Should this > use "select TRACING" instead? I think we shouldn't select TRACING, which should only be selected by tracers. You'd need CONFIG_FTRACE=y. Since FTRACE is rather big, we probably also shouldn't implicitly select it. Instead, at least when using kunit.py tool, we could add a mm/kasan/.kunitconfig like: CONFIG_KUNIT=y CONFIG_KASAN=y CONFIG_KASAN_KUNIT_TEST=y # Additional dependencies. CONFIG_FTRACE=y Which mirrors the KFENCE mm/kfence/.kunitconfig. But that doesn't help if you want to run it with something other than KUnit tool.