From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.7 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF998C07E99 for ; Mon, 5 Jul 2021 14:06:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 43C9E61951 for ; Mon, 5 Jul 2021 14:06:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43C9E61951 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F349B6B0036; Mon, 5 Jul 2021 10:06:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE4D06B005D; Mon, 5 Jul 2021 10:06:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D858B6B006C; Mon, 5 Jul 2021 10:06:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id B55196B0036 for ; Mon, 5 Jul 2021 10:06:04 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 360AF8248D52 for ; Mon, 5 Jul 2021 14:06:04 +0000 (UTC) X-FDA: 78328708248.36.4BA28C7 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf28.hostedemail.com (Postfix) with ESMTP id EA9FC90000A2 for ; Mon, 5 Jul 2021 14:06:03 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id n14so32705967lfu.8 for ; Mon, 05 Jul 2021 07:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ORehuuFLRHngj4BfeJzGKp4s1pOaJxbH1Vm9Xu/XC1M=; b=Su+vopsmQhtsd2F1gNDaJSmu0WVcyTt0V1ibrc+uIbCRi+M/8PgO/A8D33Mz9mH7T0 WQhn3iPeWexedTFUx+5vPk36vhAmp5v3wDJF/J3S/dc3CHjxh44cDT5PMhkWGoctey6V sJ0Z1qkOWM/b8ZNMowf/6Q/+q7xSEquYKtkOWoMAx22KY7uSValdpJz0S0D8EKYhTest k3VFZw8ZC+mxdmoa233hZg7Js72bSQ1+GbV/TWv17ILcGlY21TFoWJKsyI3Kn2j2Vzeo wQTmxIRqLsEjlKksrZpUEvKGSDumv4qWN7+nzlU2cNrmQMKiNgWCkecWcYnjzrw9DUUd rrIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ORehuuFLRHngj4BfeJzGKp4s1pOaJxbH1Vm9Xu/XC1M=; b=j7bcebuFYqwYIydgWieMHq+EdQlWoFCsBeE8z9CeVDB0HfSbuvipfj+x8uaQDOMLyL GR8hY4P+LqVAWb0ekHs/BETUm+B01/qm1RJlMoSsntbfa5jdnK73iOt7AyDGZ4A2LRRR RDedONmPWDQ3siOHLnqVYBdNWmCRgt1SRkF3TLC/6dbzGmkvPLe9t2hPU6s7agtIjRgC Z1Uihe3LAXk4va2gQxe/CCArwD9AdkyM4ffG52UiPvmgLzgbyQ9r8vONu4xR9oLC9VTr nHFBUXQgp+6qbqA7HkdIFQteG458GtWF6nRGIdAzsrlK30hjN5hmSUTnOWJbxJKpVKjf 5XGw== X-Gm-Message-State: AOAM5301Szc4FbVY3eLu/TMP6I1E5QdrrFRpyTGxSJ7XLlROnsEysDGy JszQU3AKBuzjtkm37rFXCpdRKlxpYSyNP7tdeHa92g== X-Google-Smtp-Source: ABdhPJxO3WGhVkYE+IFwo0w2hNQzHQTiWFMbNaD9/SY9x6NZGtxADqLJ23zQaYzEHXrl3SZ9Nzs6/lax2vxYqskyGYU= X-Received: by 2002:a19:6803:: with SMTP id d3mr10752593lfc.235.1625493962095; Mon, 05 Jul 2021 07:06:02 -0700 (PDT) MIME-Version: 1.0 References: <20210630150234.1109496-1-glider@google.com> <20210630150234.1109496-2-glider@google.com> In-Reply-To: <20210630150234.1109496-2-glider@google.com> From: Marco Elver Date: Mon, 5 Jul 2021 16:05:50 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] kfence: skip all GFP_ZONEMASK allocations To: akpm@linux-foundation.org Cc: dvyukov@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, gregkh@linuxfoundation.org, jrdr.linux@gmail.com, Alexander Potapenko Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=Su+vopsm; spf=pass (imf28.hostedemail.com: domain of elver@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: en48tjj54kepxwds465orgjg7eqxfp1y X-Rspamd-Queue-Id: EA9FC90000A2 X-Rspamd-Server: rspam06 X-HE-Tag: 1625493963-619993 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew, This series is ready to be picked up. If possible, kindly consider including it in an upcoming batch of mainline fixes. Thank you! On Wed, 30 Jun 2021 at 17:02, Alexander Potapenko wrote: > Allocation requests outside ZONE_NORMAL (MOVABLE, HIGHMEM or DMA) cannot > be fulfilled by KFENCE, because KFENCE memory pool is located in a > zone different from the requested one. > > Because callers of kmem_cache_alloc() may actually rely on the > allocation to reside in the requested zone (e.g. memory allocations done > with __GFP_DMA must be DMAable), skip all allocations done with > GFP_ZONEMASK and/or respective SLAB flags (SLAB_CACHE_DMA and > SLAB_CACHE_DMA32). > > Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure") > Cc: Andrew Morton > Cc: Dmitry Vyukov > Cc: Marco Elver > Cc: Greg Kroah-Hartman > Cc: Souptick Joarder > Cc: stable@vger.kernel.org # 5.12+ > Signed-off-by: Alexander Potapenko > Reviewed-by: Marco Elver > > --- > > v2: > - added parentheses around the GFP clause, as requested by Marco > v3: > - ignore GFP_ZONEMASK, which also covers __GFP_HIGHMEM and __GFP_MOVABLE > - move the flag check at the beginning of the function, as requested by > Souptick Joarder > v4: > - minor fixes to description and comment formatting > --- > mm/kfence/core.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 33bb20d91bf6a..1cbdb62e6d0fb 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -740,6 +740,15 @@ void *__kfence_alloc(struct kmem_cache *s, size_t size, gfp_t flags) > if (size > PAGE_SIZE) > return NULL; > > + /* > + * Skip allocations from non-default zones, including DMA. We cannot > + * guarantee that pages in the KFENCE pool will have the requested > + * properties (e.g. reside in DMAable memory). > + */ > + if ((flags & GFP_ZONEMASK) || > + (s->flags & (SLAB_CACHE_DMA | SLAB_CACHE_DMA32))) > + return NULL; > + > /* > * allocation_gate only needs to become non-zero, so it doesn't make > * sense to continue writing to it and pay the associated contention > -- > 2.32.0.93.g670b81a890-goog >