From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D34C433EF for ; Fri, 4 Mar 2022 11:51:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F6698D0002; Fri, 4 Mar 2022 06:51:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88A298D0001; Fri, 4 Mar 2022 06:51:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 746988D0002; Fri, 4 Mar 2022 06:51:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 625028D0001 for ; Fri, 4 Mar 2022 06:51:00 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1E43623CBD for ; Fri, 4 Mar 2022 11:51:00 +0000 (UTC) X-FDA: 79206537480.01.A2B535B Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf15.hostedemail.com (Postfix) with ESMTP id 9B3A4A0007 for ; Fri, 4 Mar 2022 11:50:59 +0000 (UTC) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-2dbfe58670cso88595147b3.3 for ; Fri, 04 Mar 2022 03:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/QMKz41by9JRTwwLAdweIX5q4Gx6CkMA+bu/XdMpGwU=; b=MHERMiV3OzEHRf+oF3doL0VQqQqulIYbwiwmvY/ysTPJav11DFfh4asKH3SgRWJi5u m2uwY1RGax0AJ6EvROBRltNM5lW+1/7lSEVWhl8mFgYw2s+Eef1R79xadJj7r0WzZGDG tEqKIDEEn28WvQXYtSLQsFKhUWSiM3fFlEHZQCvb14ZLjsbLESZq87mChm5j69nvUVUP HWr4nTzh8pga6taIJuuWJGUzdEEdPPOPqW2iQEtBFR628dhd/tJUf8S7uLGffSTYfD21 g9JSDqrt8ZBbkhtruGglMmKn9DD9HUl6omKKoKH3CVzAFW65h/spw/oE6qf+W1XqmU04 Xu2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/QMKz41by9JRTwwLAdweIX5q4Gx6CkMA+bu/XdMpGwU=; b=U0cLzpVEwT7fO5M0BtyPsHJ69sjAIoVVggovPU2T2uTnznzS1CsZBGQW0xfg5MmvO1 bReu/GwGCkV2+soFuyypLhzh+AC6Mc43k1Ha4eG1a9WR5EcjO211UDlGaN21BVAb772k xwY9/89EGhbkgI4pEp0unTrqwAWOVKgVxEWKzXVRxa8qty1uSwSuZfA260W8zU6J7ZaI G2WSLppiYVUEyrkLkxdv0u0+guerNhZXPsK5gB/sAi52wMNNMvR3hsqJ3ySCMYYShwtJ pU8iHOqiJLg/gDs9xbjBt1655R+At8wLOvYAd7/do0OZ5RBgo51BE5bAS/axbXaydzb/ OT5w== X-Gm-Message-State: AOAM533Jbds8l/ZKekw54zhSArGznHBjqqTZH9QyHn6qY4zDCifxQOUM F7bCkfNiDniXZ9mKUc7EO6T6aghIqRBtGhXyWbec5A== X-Google-Smtp-Source: ABdhPJzNQ8uG33oC4WJoKAcrp2fTVx9Gy+VaRHhWr0JwhE78dBabgNIhxzHRennaCQGr10Ej+e620fnWt1LOUbTblPo= X-Received: by 2002:a81:9ad7:0:b0:2db:f000:32e7 with SMTP id r206-20020a819ad7000000b002dbf00032e7mr16196340ywg.412.1646394657601; Fri, 04 Mar 2022 03:50:57 -0800 (PST) MIME-Version: 1.0 References: <20220304063427.372145-1-42.hyeyoo@gmail.com> In-Reply-To: <20220304063427.372145-1-42.hyeyoo@gmail.com> From: Marco Elver Date: Fri, 4 Mar 2022 12:50:21 +0100 Message-ID: Subject: Re: [PATCH v2 0/5] slab cleanups To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: linux-mm@kvack.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Matthew WilCox , Roman Gushchin , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9B3A4A0007 X-Stat-Signature: a4sgfoptsa5xi7ookm4am9nme7hyksz8 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=MHERMiV3; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of elver@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=elver@google.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646394659-245927 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 4 Mar 2022 at 07:34, Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: > > Changes from v1: > Now SLAB passes requests larger than order-1 page > to page allocator. > > Adjusted comments from Matthew, Vlastimil, Rientjes. > Thank you for feedback! > > BTW, I have no idea what __ksize() should return when an object that > is not allocated from slab is passed. both 0 and folio_size() > seems wrong to me. Didn't we say 0 would be the safer of the two options? https://lkml.kernel.org/r/0e02416f-ef43-dc8a-9e8e-50ff63dd3c61@suse.cz > Hello, these are cleanup patches for slab. > Please consider them for slab-next :) > > Any comments will be appreciated. > Thanks. > > Hyeonggon Yoo (5): > mm/slab: kmalloc: pass requests larger than order-1 page to page > allocator > mm/sl[au]b: unify __ksize() > mm/sl[auo]b: move definition of __ksize() to mm/slab.h > mm/slub: limit number of node partial slabs only in cache creation > mm/slub: refactor deactivate_slab() > > include/linux/slab.h | 36 ++++++------ > mm/slab.c | 51 ++++++++--------- > mm/slab.h | 21 +++++++ > mm/slab_common.c | 20 +++++++ > mm/slob.c | 1 - > mm/slub.c | 130 ++++++++++++------------------------------- > 6 files changed, 114 insertions(+), 145 deletions(-) > > -- > 2.33.1 >