From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C02C4829E for ; Thu, 15 Feb 2024 12:52:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 367F58D0013; Thu, 15 Feb 2024 07:52:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 318168D0001; Thu, 15 Feb 2024 07:52:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DF738D0013; Thu, 15 Feb 2024 07:52:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0E8E68D0001 for ; Thu, 15 Feb 2024 07:52:58 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AE72012107A for ; Thu, 15 Feb 2024 12:52:57 +0000 (UTC) X-FDA: 81794027994.27.5DB4344 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by imf08.hostedemail.com (Postfix) with ESMTP id E261716000C for ; Thu, 15 Feb 2024 12:52:55 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IRJJN0WI; spf=pass (imf08.hostedemail.com: domain of elver@google.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708001576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SezWjjSD6orUt3oayIngZPbAFgryKCchhK4x1DAlrho=; b=b90WnBFfgv2msDRIs0GgHooTigzyc0x8JiNb512APAshAbOGZVFgyeakpmH/4ZX2pKtC2D mQ35XTzYTJNeNXzDSNeUkP4JQwiRqwf5PjWyv5v+Q47/iUFzlXuZKjIb/lKxpPbLg77xAv ogkHZF25s3QWynsMYHUxjT5hlO7xyKc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708001576; a=rsa-sha256; cv=none; b=zHCYgy+ZcjZjFzHjxcp3AbsdtNAC2pOwjDdfLtBCnEsH1Re7ps5l9KLjSXychs+w4rB1Ii FjvWYqR/AjmqKsya+VxBiGp+wXvEjp2pT8B5zXm1Vnswgr+vwKAYIcege98MMCu+fwFV4J te1tW/95kcFIGoQkTYOYhUQT00vY0rM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IRJJN0WI; spf=pass (imf08.hostedemail.com: domain of elver@google.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-4c01a5e85e8so257022e0c.1 for ; Thu, 15 Feb 2024 04:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708001575; x=1708606375; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SezWjjSD6orUt3oayIngZPbAFgryKCchhK4x1DAlrho=; b=IRJJN0WIcl9vo1d2vRnAvmpZVzYzNtKDRXkACQdjRfHP0ARBPfpe0xGqi622Ko6Gcw IONLrHgITzunbXL/4WtVmjKWY3lGDT4DBFxqclbHwE0XYASXtVrWEaD5gl1uHBsAwY/r evbY/qu57ru2GyJ8OQ8e64wfBCZDJeim6kVZNNXUzFFP7Zqyqfq2lE1JvB8QAWuy/Dki VsW+IhGJsM/0pG0jZDe3jf6shsI+cuKE1WmaUzXXuL4ntIZXf5Bg+DNWWjnfducHVcdV yp2J7bQoP5zFFlDRWXGa2n72emD2K2p3a99a+zItwfIYcYsRxKPFFuid6OmGkmP7/M5/ K7xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708001575; x=1708606375; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SezWjjSD6orUt3oayIngZPbAFgryKCchhK4x1DAlrho=; b=QuEctjgK0P6vidB0U+CQ97pjNQsGRZ2Nr6ZmlcO5GGdVSRQLIr9YRvNlZVUO0VfxWL 7CuhBXB9BqQ9BHvC2VzzGiAKkrnrVzm5RjI+hoPwWg/04G5HH0lQqxf2tRSUZ7pZvu2D AlD25LCFoU0Pz7qtxDn+lg85kmz8BiJ1usjeO+d91UICbs2JKP+4vXzA3L2PwmMFVxuT VL3nz9T6UMMEWShU6TXX06JTgqTBNaKasy5oSlq/UdNZYCKRkOg4WaQMxu6uGuN/L7kU /Uo3eovpr/4OxyEXPsbJ8x7QlKVuuq7DzzAKuxDPIGeBmhjt86XrKGYwMadOQ+wCzPWd OnXQ== X-Forwarded-Encrypted: i=1; AJvYcCWtmtqtITJ/ozMzoN1ITTegPLfuP5cz70KpK+wm8k71jgiqZ5R/lVCNyyyNWBKyn94WHLRa8ifNLdddBtVOYSPYuuc= X-Gm-Message-State: AOJu0YxPsCK1IBk9FkZJx1m7rGTeoqHdIYdz1+WLCxGLFhfdwyhVRQ90 xmHyonXRQaLJiDq0p3ISftRxfeLoHACKQXr3EyAPYRU7twtFYNVQE4rhp4Dos189GtDYz7ZUWTM kRdvWq9egNTAsJyRo/6t4iiEu8MiMpqDccxEt X-Google-Smtp-Source: AGHT+IFGg5ehmpRt1TzMWxKazEmhf4eseqGfVUyCWfT2BFzc97DdnDCICov8BtBGowVdPef+irHc7zDmAcs3IBnxstc= X-Received: by 2002:a1f:e401:0:b0:4c0:305b:694e with SMTP id b1-20020a1fe401000000b004c0305b694emr1209911vkh.13.1708001574796; Thu, 15 Feb 2024 04:52:54 -0800 (PST) MIME-Version: 1.0 References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-4-osalvador@suse.de> <08a08ea2-6764-48af-8883-84639c732ce5@suse.cz> In-Reply-To: <08a08ea2-6764-48af-8883-84639c732ce5@suse.cz> From: Marco Elver Date: Thu, 15 Feb 2024 13:52:16 +0100 Message-ID: Subject: Re: [PATCH v9 3/7] mm,page_owner: Maintain own list of stack_records structs To: Vlastimil Babka Cc: Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrey Konovalov , Alexander Potapenko Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E261716000C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: yucttqshffonm3fdyr5up8w896sz395r X-HE-Tag: 1708001575-15072 X-HE-Meta: U2FsdGVkX19O9IAbmKUp/mRIuELEugW9mLdXZUpVArDOFXsYsRnY8C4nkZ7UdSADhX0+EDmqYVV4fGlFfptVmFCN2en889tfgWcqtzM52g/1yYYCqPEBVlzRcySP7Iddb7lvVCDdba0YPJeLFAqigEiJYTETV9HC/0RzwUgJmWb1bZKzlqhZLlmnIJDAH8ISzYwLH65aIkkdqmof+lMgn0BGVpPdT85WKrL6PXcqBftCOHsl3Hw/bi4Id427y0QjGt/JSLjHbYz1j3BkychyRZ3cqqVkTRlYw70WskinxdF+8TzNa80+dnab5g4+ZWCydC53j4fIMVb94SYnrpATCOr0x+JHxfAHP4h0VZxOJxRfpT7ohNfddk0hAbeTH6gaN9lW6WecCrmpX1jbia+M1xJc2rIxDG5te1K651Fr0mzQko70Vul/fMDpYHkd0IB1avAixFRF9MrDcFaJIZ83IejiZW1byBAI9dsFHGzZp5lBPAADjCQFbnHIoxI1dLWAostHzFjhdDyeY/Wa5lxbCVgiX2oep2HBdcloRBHJkX50jpiNIB6NL1F3YOs/xO3r4x+OP1mLMGKVOvTRH5Yob/8j3Hwryfk62QbXc+vb/UplOH3i72PYJMRvNP82ojQb4IUI0FiS7ua3qhKfWNAEP9dK+cCkVpmsZe81El7hZmeHQEV1Uijs2WfKHF0hrxPqUiyeOTCU6Fc/X8uzK6iG4Rz6X1rbF5+kURFGwjKJN4XRLosHy41LGUnh78L5fz5WQ0BnSS+BoyNXdZYT3bquETBgwUayjd3Gi2IhIy0xw7p6NwKmhJokkiwaAzKCRcZgsgJ5RUM1bpCfDojO2Rw5x7uyvS9NgNyn8NiCJXPOF9CWGxwV5a7fuUa00DoO0N8/XcpzJ73H8WjwgkdKLa+eflPb9I2Cw2hcqZPeCCnYkenr3WkeYl2rjnv/y8/QYRfOyf+uSFdfy+KOH0tmcyJ zPl4ml35 UldNjwEqt9lfxeehX7AGb2ttqXYgOroqzdCrWG9IhRQ/mVQFM+q2kxyvgb/HQYYBMnRLAsw0ji+4wcaUoJO/ZEmqGLYgX6oDzikCn1YJGAr4nwNasn73Q/sPq48BzhiH4hRGoohygTYuJQzbBoT8dGP1ueHCgffQtZDuagqgh3PtEdhjYRLh/xTYN3D/YTb0UQaL1TusykOBMjIhGMS+E8BEgaMasKZuKud3MRzyT42aC92/TCZK2artuMsysLlWcrX1U0Mo8ONeYJ4q038qhL171v/zBpD0fhk1lEGUPZnWf8ys= X-Bogosity: Ham, tests=bogofilter, spamicity=0.026839, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 15 Feb 2024 at 11:55, Vlastimil Babka wrote: > > On 2/14/24 18:01, Oscar Salvador wrote: > > page_owner needs to increment a stack_record refcount when a new allocation > > occurs, and decrement it on a free operation. > > In order to do that, we need to have a way to get a stack_record from a > > handle. > > Implement __stack_depot_get_stack_record() which just does that, and make > > it public so page_owner can use it. > > > > Also, traversing all stackdepot buckets comes with its own complexity, > > plus we would have to implement a way to mark only those stack_records > > that were originated from page_owner, as those are the ones we are > > interested in. > > For that reason, page_owner maintains its own list of stack_records, > > because traversing that list is faster than traversing all buckets > > while keeping at the same time a low complexity. > > > > For now, add to stack_list only the stack_records of dummy_handle and > > failure_handle, and set their refcount of 1. > > > > Further patches will add code to increment or decrement stack_records > > count on allocation and free operation. > > > > Signed-off-by: Oscar Salvador > > Reviewed-by: Vlastimil Babka > +1 Reviewed-by: Marco Elver