From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82090C433F5 for ; Wed, 16 Feb 2022 10:01:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2BF86B0073; Wed, 16 Feb 2022 05:01:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDBD46B0074; Wed, 16 Feb 2022 05:01:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA3A66B0078; Wed, 16 Feb 2022 05:01:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id C7AF96B0073 for ; Wed, 16 Feb 2022 05:01:51 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 87D3992EB4 for ; Wed, 16 Feb 2022 10:01:51 +0000 (UTC) X-FDA: 79148201622.26.23CE821 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf05.hostedemail.com (Postfix) with ESMTP id 2D132100011 for ; Wed, 16 Feb 2022 10:01:51 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id bt13so4471358ybb.2 for ; Wed, 16 Feb 2022 02:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S6LWdrzCSVeHr2t82bSdnaI065vYCk5GbX/G1ZKc0RA=; b=UK52QltyXkrM0wMM/f4bYZKZG795s7LaUW25/5noaMNn05HLnozC6ZwXn3IETp10YP 9Lfq0Bg+O7zDtXL8Dznf2kHEghY0nxQFjbcFGLr8rLeDeMtQqje/VApxMh/UJTI/DiR/ 6c0z6Cokz794PgoZiU4wivLpLpYnbuUheyvfbjDc2ijAEQfLOB5MS/QNj2Q+8gxgOA23 zmk7Igsat5F9ewFfjec8wV3QbguluR5Z/J6AcedYeSAdfpSwosOU8PgjuMlJZ9t5n8Ql WpBR3cf557FR+S6t+qYZ8fDqNkLonIkpjKFBikQE9+8CcPlnPhLrXnE97hfIxjS+KTgu 1muw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S6LWdrzCSVeHr2t82bSdnaI065vYCk5GbX/G1ZKc0RA=; b=grJUTFFht6RdAwS71PwU5aLi4h5Y9fD97JGrGxIj9pJFoYUZh3v2Wl0EV/LdXTXKI3 bVT3KxTcfkFmoM9vodTqzz1bqz1E9WWWI7JdWXgX4R4NGyy0FBUt7GSrNcCuMDpq7yTR pKND1TovjfFx3KF0YzMPcJJ3sYfkitKEcV6SsLj9rGXtSQoCPF9x2Zq68XJZ0DPBs/gr 2XTTk+ru0qrHEtuZSd0qNlNkZUgKYvqoNFvlx816ddBU/pkSGckR/dlvy0YPDG4Rd37/ E9ymB5ElDteuVZmy+W6SfCWhvstqdPwsMOlZJEpdAtAshEZtI5a4ikaNwbKKWcG0V4xk 52/A== X-Gm-Message-State: AOAM532L85hN8cxiJiF1KKMGpOChmCPI2xuHcxxx98gHBxR2DDlM2VR/ BAJw773LmHF3Kw9PQH84T1SUZHE+jpjstUxOxx7apg== X-Google-Smtp-Source: ABdhPJyILCEt/42x2fZi87wMwuOsI9Lh/rToYatkHndVcxwT04AF24jAetxuHwWDnLECRBVSVj8PEW8HlErhTWVU1ms= X-Received: by 2002:a81:7943:0:b0:2d0:c8bb:a45d with SMTP id u64-20020a817943000000b002d0c8bba45dmr1600577ywc.264.1645005710386; Wed, 16 Feb 2022 02:01:50 -0800 (PST) MIME-Version: 1.0 References: <865c91ba49b90623ab50c7526b79ccb955f544f0.1644950160.git.andreyknvl@google.com> In-Reply-To: <865c91ba49b90623ab50c7526b79ccb955f544f0.1644950160.git.andreyknvl@google.com> From: Marco Elver Date: Wed, 16 Feb 2022 11:01:39 +0100 Message-ID: Subject: Re: [PATCH mm] fix for "kasan: improve vmalloc tests" To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2D132100011 X-Stat-Signature: 41ojxhsdp4771ziy61aouzng8g36oy1q Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=UK52Qlty; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of elver@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=elver@google.com X-HE-Tag: 1645005711-566450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 15 Feb 2022 at 19:39, wrote: > > From: Andrey Konovalov > > vmap_tags() and vm_map_ram_tags() pass invalid page array size to > vm_map_ram() and vm_unmap_ram(). It's supposed to be 1, but it's > 1 << order == 2 currently. > > Remove order variable (it can only be 0 with the current code) > and hardcode the number of pages in these tests. > > Signed-off-by: Andrey Konovalov Acked-by: Marco Elver > --- > lib/test_kasan.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 491a82006f06..8416161d5177 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -1149,7 +1149,6 @@ static void vmap_tags(struct kunit *test) > { > char *p_ptr, *v_ptr; > struct page *p_page, *v_page; > - size_t order = 1; > > /* > * This test is specifically crafted for the software tag-based mode, > @@ -1159,12 +1158,12 @@ static void vmap_tags(struct kunit *test) > > KASAN_TEST_NEEDS_CONFIG_ON(test, CONFIG_KASAN_VMALLOC); > > - p_page = alloc_pages(GFP_KERNEL, order); > + p_page = alloc_pages(GFP_KERNEL, 1); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, p_page); > p_ptr = page_address(p_page); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, p_ptr); > > - v_ptr = vmap(&p_page, 1 << order, VM_MAP, PAGE_KERNEL); > + v_ptr = vmap(&p_page, 1, VM_MAP, PAGE_KERNEL); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, v_ptr); > > /* > @@ -1186,14 +1185,13 @@ static void vmap_tags(struct kunit *test) > KUNIT_EXPECT_PTR_EQ(test, p_page, v_page); > > vunmap(v_ptr); > - free_pages((unsigned long)p_ptr, order); > + free_pages((unsigned long)p_ptr, 1); > } > > static void vm_map_ram_tags(struct kunit *test) > { > char *p_ptr, *v_ptr; > struct page *page; > - size_t order = 1; > > /* > * This test is specifically crafted for the software tag-based mode, > @@ -1201,12 +1199,12 @@ static void vm_map_ram_tags(struct kunit *test) > */ > KASAN_TEST_NEEDS_CONFIG_ON(test, CONFIG_KASAN_SW_TAGS); > > - page = alloc_pages(GFP_KERNEL, order); > + page = alloc_pages(GFP_KERNEL, 1); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, page); > p_ptr = page_address(page); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, p_ptr); > > - v_ptr = vm_map_ram(&page, 1 << order, -1); > + v_ptr = vm_map_ram(&page, 1, -1); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, v_ptr); > > KUNIT_EXPECT_GE(test, (u8)get_tag(v_ptr), (u8)KASAN_TAG_MIN); > @@ -1216,8 +1214,8 @@ static void vm_map_ram_tags(struct kunit *test) > *p_ptr = 0; > *v_ptr = 0; > > - vm_unmap_ram(v_ptr, 1 << order); > - free_pages((unsigned long)p_ptr, order); > + vm_unmap_ram(v_ptr, 1); > + free_pages((unsigned long)p_ptr, 1); > } > > static void vmalloc_percpu(struct kunit *test) > -- > 2.25.1 >