From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB7DBC433FE for ; Mon, 14 Nov 2022 09:57:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C65F8E0002; Mon, 14 Nov 2022 04:57:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 575206B0073; Mon, 14 Nov 2022 04:57:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43ED48E0002; Mon, 14 Nov 2022 04:57:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 368986B0072 for ; Mon, 14 Nov 2022 04:57:54 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0EE4E120E38 for ; Mon, 14 Nov 2022 09:57:54 +0000 (UTC) X-FDA: 80131596468.19.DB3759A Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf13.hostedemail.com (Postfix) with ESMTP id B91A920003 for ; Mon, 14 Nov 2022 09:57:52 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-368edbc2c18so100851217b3.13 for ; Mon, 14 Nov 2022 01:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RH2+m7K5zmlE9wCFpvve3I5Fi8RQASbgvvHyRX4D28g=; b=caH5zcwkog0cMjlAJPkHeBavqbL94j9ZBu9bzj995wPA1niQU1MOQevoIK8FYeq65X CZVxpcYpKgdxsSgPpoH7oBCrw8VRDMF5To+i0fPdipkBKC4HQzoH9KMb+KzzyV6NEJSb YSDm6+/fn5oQLCCvDUZSNfnP1DZP4ZRHufhJQBVLKVuKjGY5tSSoP5gsN6P5GRZIRKFO P401CdBic2g2TjELvkKLbrdkzGEfkAZWeiD9pkWBf6zRmyLN5sepbhiNOrnJwttRejKo w6qk4g+2euVxCE3fFovbK0wfejNOv+gS8uk51+E/DRCnwo9ajKDQ7piqJDvUhON8rUmF K0Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RH2+m7K5zmlE9wCFpvve3I5Fi8RQASbgvvHyRX4D28g=; b=P5+7CA4nX2tFOHi14egUH/OFDJceaLOuywtwCO7aTfdFBS8INGsUjkRI5TQ3WXlc8F MgnjzO07tSxFHoKr0zAiy9DpcyArbtBOyjb7GwhE4LZzmcjvjMsNIYllRukUcr/K6d8s 3ysmN7jlGLL70JmDzLx3tmilx+HkoDN3v1gi/+dn1ocjzymo5f8xHWPZ+wJuw9hofZoM d9ef36SfMyExbTUDP2pbLUEf53O/hha9lI/WILEd4GxBXeG6GbruzN+7iq0bcfYMcEnb V4pOlNUJwU3GavccDIJHGMXcDlEnV7zRvoCphvZ5j8Q26FTkWvC5/OrTWgzhmk1nHAQX Q6Cw== X-Gm-Message-State: ANoB5pk2kDNVsX68vXHDBS+KbhaZjLteIpg4WXin5/iVr7n4ynbAiYAO umjtULF4KgJ+mGe4MLnVElloIzb7hQHgbcNc+IHAYw== X-Google-Smtp-Source: AA0mqf70pl/z47fmpk4u4ZeWHoOSrV7lZsGiEEsaIoLkCXk5PZeeohOP4gcTGHGLHcH5obzGuI4SUFJO88mv9HjyoRg= X-Received: by 2002:a81:4949:0:b0:36a:a52e:fe48 with SMTP id w70-20020a814949000000b0036aa52efe48mr12368442ywa.267.1668419871793; Mon, 14 Nov 2022 01:57:51 -0800 (PST) MIME-Version: 1.0 References: <20221109194404.gonna.558-kees@kernel.org> <20221109200050.3400857-4-keescook@chromium.org> In-Reply-To: <20221109200050.3400857-4-keescook@chromium.org> From: Marco Elver Date: Mon, 14 Nov 2022 10:57:15 +0100 Message-ID: Subject: Re: [PATCH v2 4/6] panic: Consolidate open-coded panic_on_warn checks To: Kees Cook Cc: Jann Horn , Dmitry Vyukov , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Vincenzo Frascino , Andrew Morton , Luis Chamberlain , David Gow , tangmeng , Petr Mladek , "Paul E. McKenney" , Sebastian Andrzej Siewior , "Guilherme G. Piccoli" , Tiezhu Yang , kasan-dev@googlegroups.com, linux-mm@kvack.org, Greg KH , Linus Torvalds , Seth Jenkins , Andy Lutomirski , "Eric W. Biederman" , Arnd Bergmann , Jonathan Corbet , Baolin Wang , "Jason A. Donenfeld" , Eric Biggers , Huang Ying , Anton Vorontsov , Mauro Carvalho Chehab , Laurent Dufour , Rob Herring , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668419872; a=rsa-sha256; cv=none; b=CGfIw/Yf+bgJWoqxbNWVD/WGxUpWCHipFixkUDjroZ46zU35MbGapfYIO9k44S0uTEWI+S GKvR2JNA8J1E6JuPeqkC+xEawL79hXJcokcFmWwER4p8fQbR5DKua9gtlJAeaIgGnhunX8 6bm/vMJMRjCweQlbn9Fj28dOwkDUJ3w= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=caH5zcwk; spf=pass (imf13.hostedemail.com: domain of elver@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668419872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RH2+m7K5zmlE9wCFpvve3I5Fi8RQASbgvvHyRX4D28g=; b=U0bRLojYie41aQwkk0g+J+PSQXompMvNktnGQ+6idqtO4bSkzUCZoOJ0D+tX+T5BAXKXhu /3DkgrfbMoX3lWAEyG0yavOnEHmhsNeEgQbjZ7YL+7UJ9SUnjMA0S1nnMXYe7mbLC47+IX 1DSIqAkgo0/Xy2e1hn/9727+46ZxNds= X-Rspam-User: X-Stat-Signature: 3dencrh8433ak4n1ntuwzrn8zg7w338y X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B91A920003 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=caH5zcwk; spf=pass (imf13.hostedemail.com: domain of elver@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1668419872-271455 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 9 Nov 2022 at 21:00, Kees Cook wrote: > > Several run-time checkers (KASAN, UBSAN, KFENCE, KCSAN, sched) roll > their own warnings, and each check "panic_on_warn". Consolidate this > into a single function so that future instrumentation can be added in > a single location. > > Cc: Marco Elver > Cc: Dmitry Vyukov > Cc: Peter Zijlstra > Cc: Juri Lelli > Cc: Vincent Guittot > Cc: Dietmar Eggemann > Cc: Steven Rostedt > Cc: Ben Segall > Cc: Mel Gorman > Cc: Daniel Bristot de Oliveira > Cc: Valentin Schneider > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Andrey Konovalov > Cc: Vincenzo Frascino > Cc: Andrew Morton > Cc: Luis Chamberlain > Cc: David Gow > Cc: tangmeng > Cc: Jann Horn > Cc: Petr Mladek > Cc: "Paul E. McKenney" > Cc: Sebastian Andrzej Siewior > Cc: "Guilherme G. Piccoli" > Cc: Tiezhu Yang > Cc: kasan-dev@googlegroups.com > Cc: linux-mm@kvack.org > Signed-off-by: Kees Cook > --- > include/linux/panic.h | 1 + > kernel/kcsan/report.c | 3 +-- > kernel/panic.c | 9 +++++++-- > kernel/sched/core.c | 3 +-- > lib/ubsan.c | 3 +-- > mm/kasan/report.c | 4 ++-- > mm/kfence/report.c | 3 +-- > 7 files changed, 14 insertions(+), 12 deletions(-) > > diff --git a/include/linux/panic.h b/include/linux/panic.h > index c7759b3f2045..1702aeb74927 100644 > --- a/include/linux/panic.h > +++ b/include/linux/panic.h > @@ -11,6 +11,7 @@ extern long (*panic_blink)(int state); > __printf(1, 2) > void panic(const char *fmt, ...) __noreturn __cold; > void nmi_panic(struct pt_regs *regs, const char *msg); > +void check_panic_on_warn(const char *reason); > extern void oops_enter(void); > extern void oops_exit(void); > extern bool oops_may_print(void); > diff --git a/kernel/kcsan/report.c b/kernel/kcsan/report.c > index 67794404042a..e95ce7d7a76e 100644 > --- a/kernel/kcsan/report.c > +++ b/kernel/kcsan/report.c > @@ -492,8 +492,7 @@ static void print_report(enum kcsan_value_change value_change, > dump_stack_print_info(KERN_DEFAULT); > pr_err("==================================================================\n"); > > - if (panic_on_warn) > - panic("panic_on_warn set ...\n"); > + check_panic_on_warn("KCSAN"); > } > > static void release_report(unsigned long *flags, struct other_info *other_info) > diff --git a/kernel/panic.c b/kernel/panic.c > index 129936511380..3afd234767bc 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -201,6 +201,12 @@ static void panic_print_sys_info(bool console_flush) > ftrace_dump(DUMP_ALL); > } > > +void check_panic_on_warn(const char *reason) > +{ > + if (panic_on_warn) > + panic("%s: panic_on_warn set ...\n", reason); > +} > + > /** > * panic - halt the system > * @fmt: The text string to print > @@ -619,8 +625,7 @@ void __warn(const char *file, int line, void *caller, unsigned taint, > if (regs) > show_regs(regs); > > - if (panic_on_warn) > - panic("panic_on_warn set ...\n"); > + check_panic_on_warn("kernel"); What is the reason "kernel" in this context? The real reason is a WARN - so would the reason "WARNING" be more intuitive?