From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669F6C74A5B for ; Thu, 16 Mar 2023 22:49:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0266B900005; Thu, 16 Mar 2023 18:49:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF289900002; Thu, 16 Mar 2023 18:49:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9266900005; Thu, 16 Mar 2023 18:49:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C607B900002 for ; Thu, 16 Mar 2023 18:49:01 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A28CA1C61A7 for ; Thu, 16 Mar 2023 22:49:01 +0000 (UTC) X-FDA: 80576253282.12.7E31F7E Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf30.hostedemail.com (Postfix) with ESMTP id EDB6B80011 for ; Thu, 16 Mar 2023 22:48:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ADu4GbHa; spf=pass (imf30.hostedemail.com: domain of elver@google.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679006940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gxr240v7gPTttE+NPLSA84Q9E6emq53Syi5SVB2+hgU=; b=jO+iWouTBkSVZU+C8bOjbarSfh6u7c4SqR9+k3Hp2tlZhl+knXnBiV13Z+awqrI2MK9QXR 3TjDHC3peHMGwvW+vA7qpf2GciB5kGC19ioSEYLMouHqgBWr9/hfJCf4fpqA2Mkt3ObSfC H/zwek4+q3LZRAhtZo52VottjL+E750= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ADu4GbHa; spf=pass (imf30.hostedemail.com: domain of elver@google.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679006940; a=rsa-sha256; cv=none; b=BJyEo0WOKRXQCCplnOg+nUmemV9BruDjVCP+OcQe1tYkoLF2QgtRACLi2IS7EZ3rjNvWAU +Ku1x2zjwgiGNPBLIRzNri/nkcc5E4SRghmZI56bKdelpoWICFnii//gTKAbVwF5uH7eRB G1XuJTMbVBZLKevupIH+Ht7AwA/Er0Q= Received: by mail-io1-f47.google.com with SMTP id k17so1521847iob.1 for ; Thu, 16 Mar 2023 15:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679006939; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Gxr240v7gPTttE+NPLSA84Q9E6emq53Syi5SVB2+hgU=; b=ADu4GbHaErlrOn0VmVYPpIMKX5Zqy2fcRK+6i6Bqjfj4gjh1PNDY94sbkf8tssn95g BYrOfR5ONrGboCnUY8prbwyzRYVLUGR1wHq3Wb46NnQOa46KT/VECOqelGgbK8Fe+NMJ Iz7KE+EnBfBNp0PIaPN752kzqZhe2MbQrFIaoKFs064grmcITMVJkP5QDij30fLT5oBs DwBZFMwRaHskwcxkzteuDcExPAHp66elMbVDLz8o6NPxXR4SlF8QBxNP35BPBZnzz+i5 1Ti0uKXIo0DAoMLq7I6mkbMYeKZkLWGTFq2ojDkdNuZEi5ZZGmagvwTFEGV3YeBIBLCf ODiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679006939; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gxr240v7gPTttE+NPLSA84Q9E6emq53Syi5SVB2+hgU=; b=bUWZIqnb9isjNxa9y15Nw1EIdtW6Gu/kuvl0VUMHEy1pNsPtsodfRpHE2hH7uANAh2 yTGOxN1c/OGnpx7K4HsUDiJ10e65cO0LpD5TRwamzTXg67NwZyR831wFnALot0LTa4Wf Sfs7O5RHJJHfOY+u65rmyevrvhNILFXjxMJIN9uk7P1CCvUP5cVuycxKkNyb5Is2eaSN GlpvDGjRyQQ4nFb4i0pb4emAzDWkbjMnU9Xe4h+h0vFYL7kbUT0vbcxqprNjX/ZtNDHJ vEyvaaAl14GtLvOp/J9Wt/W9eIXFeSg38tNGopGG1VBxbPpHVycZp05POaGiVh6jR4/Y uoSA== X-Gm-Message-State: AO0yUKVeJHdWBzz6aL0C/G/flM2l/gKw9ltI+KhYVtb3MFFz+u4072dO SjLs2q3Hual75ymBE4TCkme3QdhFUT9WDfvmDJpbAQ== X-Google-Smtp-Source: AK7set/+QGT+zp/m9OIPmBdmW5Wf2XkrsV6D8oXdPUwkZGggZmYAUbh6m4uhfMEPWmVTSHCdOvuqn7BR9TPWZ6YANdY= X-Received: by 2002:a05:6602:228d:b0:74c:8c3c:b71 with SMTP id d13-20020a056602228d00b0074c8c3c0b71mr533639iod.12.1679006939131; Thu, 16 Mar 2023 15:48:59 -0700 (PDT) MIME-Version: 1.0 References: <20230316155104.594662-1-elver@google.com> <20230316153354.bc31b9583eae6a79a1789de0@linux-foundation.org> In-Reply-To: <20230316153354.bc31b9583eae6a79a1789de0@linux-foundation.org> From: Marco Elver Date: Thu, 16 Mar 2023 23:48:15 +0100 Message-ID: Subject: Re: [PATCH] kfence, kcsan: avoid passing -g for tests To: Andrew Morton Cc: Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nathan Chancellor Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EDB6B80011 X-Rspam-User: X-Stat-Signature: nak3qzhqb9jdj8spaw1d3bray1tpyp7x X-HE-Tag: 1679006939-987422 X-HE-Meta: U2FsdGVkX19tfj2zEJsZVdE8JJTdvAS0JHnjGAkcyzPerA+o2Lr9SOJ7sKdkyxPB/K9tdXS5vKZRejPjRWcutk0xQ6B5HuhYngJsN5wt4YBnqV3lerx1CP9D/yOyVHQzwJGHuywaFJEFyuP++JprhxloxYJpxtZrecxXaqn8E597nDktgJF9aRxP6GZuTaYMTPlS84J1292s8KpzPv2kMb8ClaL+vI0IwcJz2BvBymJxQemNLhMAZRtKmkybBR31loekUx9U6kynPu1XsQz2nN4dPVQBUdBHQ4ZXsyBRGzjJ0xieuQFOfwxlOaatIe0J0MBsOdnEABsMLztCmIkcuN4eYihht15GdKsQQyNniGreeDMGda8kCP7uCSK56anIj0VppZF9c8qmdBJdcOJ9cAQklOcH5laFPCs9mfI1E0wuRwnoHNgh6E0bdOyp70RbqiALtH4dpTE2cCtVHNQTcRIR66v5DXbr6kgYi0OC51f82fRvO4p2fJFTzJuTDI0S4IRbZLWnAhavRg8DVC3FfIbYLIn42dwkFeyNbzm91RNi5A42PTaSOFNM8n7qmdqEG6xb9QIAu0lx3RA7cdgNWLdTctAQfoliy/KBiaRjkCAbfiasNQPJmIpcQSjKOxwDcn5vfwwLy4y6y//P+Td9QViV7Z6RaiZIWUPZID7oqtCAx6rZR5exH6q9mDSYHFMWOewSQZn92GCe+xcH/swWWWq/H2Yo/on6BZHK5mDwTFfLFw3dj9NBgjpfgKz4zpkEy+Q7HFep0LrL+llJHGiAYrsEY2gykWMqQfKLiiGkeCg72zW3ld+3BL8PONkpjAfc2JQvVSe5P0ifO1WoJ8/5/6VPsAmoNAej/vXGouBGd1A/jYj4n6DFVkIlCi9ViRxAgtWHbGhpcF4wAQ9pORGVhbpDpmpIbUuFqWJP49b9BhC6/4T92v3Hvp33bpCquIbe//ol5OJ7VHb+dvfLgcb LZ4m0LR8 ZNN5A3i8TjTx46u8SB3GkGB+l4tR7fngvhFE8TCfjXEhIXqUFNXkro+biJjVCLFl833sI6ykpYJzuUqnMqaP0Zr2lYacvJvd0ytcwm2EiLL9kk0SQH1xLYIChgpCDiQfA1I84LOwZWDe9AbPmLcRVsby/ub34r3aRZwRUERjB07xWYcCc4RPnO2LYZDDIEeoq4a63KyR1Z2F2MqjE1v+0VaJixZ4mF6hoduAio4biO69SJ1bs/GeWh0fYTvTwW1mAMQizx2uD/EUKKdxEhEb9VS7ppc+JaJO5O/WN3TkO5TvVVnRs4kyXJwGmGLUi2k8JyISPfTMb2Tu2JXJ73wnqq7W10BAAk7PSMbuFbJ7EF1WvkoZif2rGG4BAb0QA4ee3gXrL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 16 Mar 2023 at 23:33, Andrew Morton wrote: > > On Thu, 16 Mar 2023 16:51:04 +0100 Marco Elver wrote: > > > Nathan reported that when building with GNU as and a version of clang > > that defaults to DWARF5: > > > > $ make -skj"$(nproc)" ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- \ > > LLVM=1 LLVM_IAS=0 O=build \ > > mrproper allmodconfig mm/kfence/kfence_test.o > > /tmp/kfence_test-08a0a0.s: Assembler messages: > > /tmp/kfence_test-08a0a0.s:14627: Error: non-constant .uleb128 is not supported > > /tmp/kfence_test-08a0a0.s:14628: Error: non-constant .uleb128 is not supported > > /tmp/kfence_test-08a0a0.s:14632: Error: non-constant .uleb128 is not supported > > /tmp/kfence_test-08a0a0.s:14633: Error: non-constant .uleb128 is not supported > > /tmp/kfence_test-08a0a0.s:14639: Error: non-constant .uleb128 is not supported > > ... > > > > This is because `-g` defaults to the compiler debug info default. If the > > assembler does not support some of the directives used, the above errors > > occur. To fix, remove the explicit passing of `-g`. > > > > All these tests want is that stack traces print valid function names, > > and debug info is not required for that. I currently cannot recall why I > > added the explicit `-g`. > > Does this need to be backported into earlier kernels? > > If so, we'd need to do it as two patches, each with the relevant > Fixes:, which appear to be a146fed56f8 and bc8fbc5f30. Good point - sent https://lkml.kernel.org/r/20230316224705.709984-1-elver@google.com Thanks, -- Marco