linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marco Elver <elver@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	kasan-dev@googlegroups.com,  linux-kernel@vger.kernel.org,
	linux-mm@kvack.org,  Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH] kfence, kcsan: avoid passing -g for tests
Date: Thu, 16 Mar 2023 23:48:15 +0100	[thread overview]
Message-ID: <CANpmjNNqmRa3qYPoWcfe=FQXtJvLU5xN05hnZTjo4-cG9B984A@mail.gmail.com> (raw)
In-Reply-To: <20230316153354.bc31b9583eae6a79a1789de0@linux-foundation.org>

On Thu, 16 Mar 2023 at 23:33, Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Thu, 16 Mar 2023 16:51:04 +0100 Marco Elver <elver@google.com> wrote:
>
> > Nathan reported that when building with GNU as and a version of clang
> > that defaults to DWARF5:
> >
> >   $ make -skj"$(nproc)" ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- \
> >                       LLVM=1 LLVM_IAS=0 O=build \
> >                       mrproper allmodconfig mm/kfence/kfence_test.o
> >   /tmp/kfence_test-08a0a0.s: Assembler messages:
> >   /tmp/kfence_test-08a0a0.s:14627: Error: non-constant .uleb128 is not supported
> >   /tmp/kfence_test-08a0a0.s:14628: Error: non-constant .uleb128 is not supported
> >   /tmp/kfence_test-08a0a0.s:14632: Error: non-constant .uleb128 is not supported
> >   /tmp/kfence_test-08a0a0.s:14633: Error: non-constant .uleb128 is not supported
> >   /tmp/kfence_test-08a0a0.s:14639: Error: non-constant .uleb128 is not supported
> >   ...
> >
> > This is because `-g` defaults to the compiler debug info default. If the
> > assembler does not support some of the directives used, the above errors
> > occur. To fix, remove the explicit passing of `-g`.
> >
> > All these tests want is that stack traces print valid function names,
> > and debug info is not required for that. I currently cannot recall why I
> > added the explicit `-g`.
>
> Does this need to be backported into earlier kernels?
>
> If so, we'd need to do it as two patches, each with the relevant
> Fixes:, which appear to be a146fed56f8 and bc8fbc5f30.

Good point - sent
https://lkml.kernel.org/r/20230316224705.709984-1-elver@google.com

Thanks,
-- Marco


      reply	other threads:[~2023-03-16 22:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 15:51 Marco Elver
2023-03-16 16:05 ` Nathan Chancellor
2023-03-16 22:33 ` Andrew Morton
2023-03-16 22:48   ` Marco Elver [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANpmjNNqmRa3qYPoWcfe=FQXtJvLU5xN05hnZTjo4-cG9B984A@mail.gmail.com' \
    --to=elver@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nathan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox