From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC2ACDB465 for ; Mon, 16 Oct 2023 07:25:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05C2F6B0187; Mon, 16 Oct 2023 03:25:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F26A46B0188; Mon, 16 Oct 2023 03:25:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC7896B0189; Mon, 16 Oct 2023 03:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C8CBD6B0187 for ; Mon, 16 Oct 2023 03:25:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8FA3C80AF4 for ; Mon, 16 Oct 2023 07:25:16 +0000 (UTC) X-FDA: 81350488632.25.D585163 Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by imf20.hostedemail.com (Postfix) with ESMTP id A45D41C0013 for ; Mon, 16 Oct 2023 07:25:14 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="J/0NHS5Y"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of elver@google.com designates 209.85.217.48 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697441114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Aaq5gGSXXFhrvTLVP4/6JBiex67TLmoZv6JITqT6ub0=; b=J4mKeamHQcVs3IUPvns3PApaMd5lIEQFO52kmwACVMwMr8TqvrRnFzL0sSWEyhczT4pHuK qf+DuxRnhX+urvyBRosf+B72fC2xccOcSuGymg9MRyq1nsReyeWHnj9NtFWC2ecs2uwzh1 qU9PtrC+Ye2uKZJ2HYe5x3gbe+5phPo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="J/0NHS5Y"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of elver@google.com designates 209.85.217.48 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697441114; a=rsa-sha256; cv=none; b=2eaKByLJ/Wlr8vQFJzS6ASOuT9V/gnCkFk8CgRzbGGVtIbJE8ZG4Jym4kh86qe8BSx3B2N RWGWCZJ+tncJ8bVhLJ6xdgpDyigURboT+dzOCJ51+ip3Sx+wdkjN2eM51wotpYmvgZY/L9 pGwRz7DGgIE4JC3WCeYUbveTmUAIUa8= Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-4577c1ae94fso1683460137.1 for ; Mon, 16 Oct 2023 00:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697441114; x=1698045914; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Aaq5gGSXXFhrvTLVP4/6JBiex67TLmoZv6JITqT6ub0=; b=J/0NHS5YABqmbjJi0K+3zY/kh0UGkHzMG9hsobNKUbmv2q0D1N0cR8eK0JwcEdLJ3p B16s4Q+vJBsrAsKDyvBkeA1CwCHY3gNAklFpKTHrmOMKTgy90uPftXE6knNZpClC6bwG +KDrbytiPv+VSEeJmYF8XZVJR5o7FLXL1g6OUmQFftiU+NtkLdxcoz3ybeeJUGv9JQha y/HgyobzAC6wtJGbexEaG6QhXkhiyRSMRm8wJFb3ZRECovvStHwtKABTieMOlERT/Jb4 pVgQkZWT0rSTEEqbSl/dKpiYUACryOordoSlRLPB+7wQO7cPFxIKrKVEMemjyN5xHMrj ocFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697441114; x=1698045914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Aaq5gGSXXFhrvTLVP4/6JBiex67TLmoZv6JITqT6ub0=; b=jgHzhANQih2g9vVYcPzRywwByBv1W9hUCr7Pf4l5ypU84DPm/rqQluXX93B0C5hdV1 sfN+LLU9LPyecExHXKHRChBkljOBQzIdwyU7lu0jqLQVuhGpZHd67VFMO+LoLRha+/Ny ItD7m3ByPvRUcYoJo31Y+JkD90OjICEJOrKb/NOi/Ryvtn4Iqn3fSui50pHlTqr4QElp EjJ0bf7sb0dSB2suUpMgNc2C6kxtR3fxZ+6vAJzbrFPikAOjXRWOcQLXpallUXtTAfBc Zc9n6FJUIQ6FNgKitJfS5CBcm+WJr1zfMA1XN5KLke7gRTbVLXvIVnsR/Yb97iQ62CCl K4Dg== X-Gm-Message-State: AOJu0Yx8wGEXiucDugsbzjcHXqhUQEVGl96pswU5IRHr93VHGUzU0wPv bzJfCJdxrRgTx9MzcZomfJXNjhy9xTaZVW6CWVRBng== X-Google-Smtp-Source: AGHT+IHM6KHt6t7x5t8fil1Plwgk0EsM4WTEYEIj9ZZGHoZ/I6lKkTvCIA4i9QP2W1cZcN11E/Wv3rB9KseVrX4b+qA= X-Received: by 2002:a67:e00b:0:b0:457:c052:1949 with SMTP id c11-20020a67e00b000000b00457c0521949mr6953894vsl.25.1697441113556; Mon, 16 Oct 2023 00:25:13 -0700 (PDT) MIME-Version: 1.0 References: <20231015202650.85777-1-pedro.falcato@gmail.com> In-Reply-To: From: Marco Elver Date: Mon, 16 Oct 2023 09:24:37 +0200 Message-ID: Subject: Re: [PATCH] mm: kmsan: Panic on failure to allocate early boot metadata To: Pedro Falcato Cc: kasan-dev@googlegroups.com, Alexander Potapenko , Dmitry Vyukov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A45D41C0013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sjkun5qjwyd3i7478bm9prssqqcogxza X-HE-Tag: 1697441114-484009 X-HE-Meta: U2FsdGVkX18h7AqLnVRnz5aRnoZepz8ovykFAicH6fk//UjuXExWsPvbQj+weD5EwIcqUVllRaErbuhOCSeJ4oS0I2d1ivNJpHTRIOH8OLzAhdGg45pwnSDznz16d4CjLoxdiTLJl54k2R9Rijq9nI28niu9P8N64IYcfgc3VXeNvn6uuA8U7qWvD2pkCjSWXHdXOzP7dwnZeukZWQ0eqWqZfhq7flj2Jj2NjtJMtX2F4dZd6LC36EwOjKU/4Zc6fBjZRV6OA/JBrTy+rXNQ5/laJN5Plnbp8/bxNDmKXYo04Jc0Kgx1SFxtihT+L3CmXmnLvySfdaAPwuOXeH3C1X4fjd8eSexnHbqyQqiUcBfzDs5YJlZ+SoAP4984HgzO8+ewrbRNYKgskyeomNsGLrRgmtxN6mGy2IBiVd6MOkLUhqk8/+UrfGZhkdY0R5pY+9gqQYzeJABKy33w0ZRnzp0MuQihvLDmV0wveWuXXhM22WNGssLDFhr7SsTUA6/tOOnDiP9nMCqxsJI32UmPrM5YsZ4qOh5vY65blmO1IEuYN0pAOtSyouE4+crnjmrOeNxVRLS0QaP7C1sZwR4uIGP8XuaGeNvi1gw4+1AqRIlOuaHGM3c3AT8srK2TfYBpMKwfPtre8A9oDa+I1eUaPfFKmCPPdlLu6ureaOZjlT/pXt3paWv37my6kgGVMFLzHZmckBkkVLh0NaJ9cLYzbaNyf/jqCP/P11wUnGIhgo+Z9Sx4pmsWEPsIj6DMA7tgNpVJL1w3cHqtwBeWcA6bCcCE+nwr+e/KjUWrea2V8XyjwZCD2RvFbD7MzLGFbIhxXwAdI5EbXzlQmSaRT92+n9F6p89hBSMLeu46N60R6+VzLxPEYWd1SItlCCjlQWli5AqHLLRUst+iMLCrgldyA6+FUooTXjpn6QthVzp7+ODServHkj8td6Q31V0ghoRcHqDpqaeZYZsfULEVOXR MIKalFvu AM8Y+r+Lxu7LoZtN+CwzGCB4fSKUZpITKJPXvlXD/UKVSTVx4/gLcsW67C8XZWpFvWOZ/bwEij3mmcZ9IuX9RNY62IhwD+C3/qg2iSVHR/qzSmnkG81JXvA/5DG8FsLAF/DZ3dkP5Z91Hw8O3SyTfn6AFJk4uRC016LZnQA/xBHNVJw1hOfr59ekqd1DCiW7DsZrFOMoqCkTml/HRVjbmQimFLgB1e3LCIdooV89WlozILBnDsiAi+E2pWp7qZaYolNT/nmJ4KmVTvZaLGycUotR1Koc/x68ycF8ur5G/mOMLAa8D13EZFe+CiG+CGdXz/4yoxoH1QB+6PEuLYCiastBhjsnSW9w5COMH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 15 Oct 2023 at 22:35, Pedro Falcato wrote= : > > On Sun, Oct 15, 2023 at 9:26=E2=80=AFPM Pedro Falcato wrote: > > > > Given large enough allocations and a machine with low enough memory (i.= e > > a default QEMU VM), it's entirely possible that > > kmsan_init_alloc_meta_for_range's shadow+origin allocation fails. > > Ugh, forgot to run checkpatch.pl until it was too late :/ > > > Instead of eating a NULL deref kernel oops, check explicitly for memblo= ck_alloc() > > If there's no need for a v2, please wrap the above line and... Probably easier to send v2. Otherwise looks good. > > failure and panic with a nice error message. > > > > Signed-off-by: Pedro Falcato > > --- > > mm/kmsan/shadow.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/mm/kmsan/shadow.c b/mm/kmsan/shadow.c > > index 87318f9170f..3dae3d9c0b3 100644 > > --- a/mm/kmsan/shadow.c > > +++ b/mm/kmsan/shadow.c > > @@ -285,12 +285,18 @@ void __init kmsan_init_alloc_meta_for_range(void = *start, void *end) > > size =3D PAGE_ALIGN((u64)end - (u64)start); > > shadow =3D memblock_alloc(size, PAGE_SIZE); > > origin =3D memblock_alloc(size, PAGE_SIZE); > > + > > + if (!shadow || !origin) > > + panic("%s: Failed to allocate metadata memory for early= boot range " > > + "of size %llu", > > unwrap this string like this: > "%s: Failed to allocate metadata memory for early boot range of size = %llu", > > Silly mistake... > > -- > Pedro