From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6528CC00A8F for ; Tue, 24 Oct 2023 13:14:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC6EF6B0251; Tue, 24 Oct 2023 09:14:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B77686B0252; Tue, 24 Oct 2023 09:14:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3FD06B0253; Tue, 24 Oct 2023 09:14:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 91E446B0251 for ; Tue, 24 Oct 2023 09:14:35 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 58F1E1A02C1 for ; Tue, 24 Oct 2023 13:14:35 +0000 (UTC) X-FDA: 81380399310.24.67EEF9F Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf08.hostedemail.com (Postfix) with ESMTP id 8118C160014 for ; Tue, 24 Oct 2023 13:14:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gtnjmS1L; spf=pass (imf08.hostedemail.com: domain of elver@google.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698153273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nEr9urFwA/XFdZ4nlXaG4cbFnHUMhCkx9szJZ37Mwg4=; b=JkZe2zngxBpTcYePUMB3NxjoLzU6KaPlAotnhcFhchaZo3CtVdjYwU8OQm9SRLMYmXCVl6 Aam99327BTvKZGT0FlNWCwiQ893XkU08UnJnDlbq4xHRIALPKam0sDG+Mo4EeN+QubdsAY rbsr69E6VAKYRw9n3zBk6ccls+F9RE4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698153273; a=rsa-sha256; cv=none; b=2Pa6M83gHLC4CeT/NimgET5rTzvWQ6ziVJD3POmrDK3ljrUd5RB44rmbHXhSgL7BgQO/3n RcUZrEnV4WmnPWuXegPIhgP3YQSc7LanPilXLb4+fCEe9bObIuSwMdKnZW3n8yp6uKk6Bs IytjjKOXCWkfTB2MJv92rqWSByFXGaM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gtnjmS1L; spf=pass (imf08.hostedemail.com: domain of elver@google.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3b2e4107f47so3218399b6e.2 for ; Tue, 24 Oct 2023 06:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698153272; x=1698758072; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nEr9urFwA/XFdZ4nlXaG4cbFnHUMhCkx9szJZ37Mwg4=; b=gtnjmS1LJAyxgo1tZBhsYYdsT/RzP5ROiCgzYpKWRPc6UgfC+8x02QYCw3Zwh1b+v8 USbP9CWYKHUGJTiWftlT/8ZcclDpkL/7Mo7gO48kNm03U+xYpfOOmzytFe69Kd9vkdZR tAVd17LS0/G9mzVGrHraUB1OAaBqP1giqIFtHSyuO25lglcBHFY/IbVp2TEKL1mJs/1z 6V4gUHqHPrIy9N5BykKQox5LLUnVHR+UKHUom367XqPilSKTMczK2PCGoFo3CjmYRIbJ UO5vYQuV4Jsnpy+H8u+WgotNKdu+v4CATGO77GLyju0HfX4eVDHo0iBwUCVsdMzvWcHh f3MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698153272; x=1698758072; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nEr9urFwA/XFdZ4nlXaG4cbFnHUMhCkx9szJZ37Mwg4=; b=N9M/t9HSxOPv7FLdR6G66RIXbkk2NPWKxaKS7B1CPn2SC8Ca/CEXdcQIXrIdIcNySz S2gfJ9Wmm4pdStlxVSYK7LAx5QeKDiOTQ4xEaE5+ib+dx8MfN9LgTUhi66izYYJ0HaW8 U3KYhWVxLJyC61UWSOs+hFFwVNf+N1CHN0NBgdk7HV97QRDrWm2r86PbVUWBVNeI7BxW OOOLtK436tnKfL7Pt3l1PdXBrHjitB77XoF2TqKbfGwnS5DaMA3BaGMtzeVwlVD6JhyB ddvDCf+A9pGm79of+oA46sdMIYfnkCXxGL5DdQWPXnPaMTswVgjXzi9C/AckSsRkKDEu wwiQ== X-Gm-Message-State: AOJu0YyC0NiQcNLhypsWtdVdSCug8JW9ypMSZYswEzEJpkGbW+CDZusB McQm1F1eMUXOGJQprjCOfjidLVOjZGr1I7DUxGhjlw== X-Google-Smtp-Source: AGHT+IFko/8C6M3JHArZ1Zx5hfggnK1QA7sDxIbWpOuWMp+LhICu2KMX4uEDtQ/Lxme/mdMUv5QiMHA4JlifACARQAg= X-Received: by 2002:aca:d12:0:b0:3a7:6ff5:c628 with SMTP id 18-20020aca0d12000000b003a76ff5c628mr13328519oin.11.1698153272314; Tue, 24 Oct 2023 06:14:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Tue, 24 Oct 2023 15:13:54 +0200 Message-ID: Subject: Re: [PATCH v3 00/19] stackdepot: allow evicting stack traces To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8118C160014 X-Rspam-User: X-Stat-Signature: i7yofc3ri3pe3z5wgw3p6t7m6jfdeqa6 X-Rspamd-Server: rspam03 X-HE-Tag: 1698153273-173617 X-HE-Meta: U2FsdGVkX1+RF4lLwdW86JMcGSDAnSbfIQ5OLfmR7vdG6Jtp6dSuTNWwJxXdKBm7pguDIRd8CKGZDrR5q76KeTftXvIEgxoKntRwM/nz75+cQ9TzOP+/U/jRziRCaNe+fIvABUwPKxiWuVWZag1QX5TdN8sYR6kxfewz3o6mUdR+UQEH+wOYdV+MYaZ6VQtlql06qIXeI+vvReIDH78+hvK+kz1n1s4tRfRaqdth3upGxHOgmEkjw3dqpSCqodT8vqLWZvR/f55mVS3lJgkchU7ruTpqtXfclnudFSOJhFlvaz+oivSnVySxYEdNOTKupM1j2+Q/kFhkxX6IWMCLArKbrQ+8/gozK8T/WQ+T1fzPI9xtqts+clV4WchgAh8HfVgt7FknEYbMw4rVvzo7o2zJJa5CHg3kEFdSrZnDkiZt+igaB/mnNnOUP70F9vB/wGZUmKFhrtyXA07ZqM3y++R74Znge5w25pT7pzhlPD6R7fe3Zk4EeKSvpIhkdgUM93A3eDNV4Ln7jUT4NSjspfXhrBOauvLsIhu3S2fp6TomjjMgOIWP1C6PpLhz0uyddevTbczYLuCkjM4pbb9U7t7dah05opPsn0ULJV6qbQZEQUPoPXskze0F8llnUKtuad7C0fBERF7Ibubr2jTNMdlOqDJqbx3RVCBjb5dr67WTtQmZTnkx81akczONG81g1UpLi5ZCYVp8ewmz5ZHyM0i7biAu8B3/KeGBqk2O0E4s+cwuuesrJOtUC4Keqp9CVmLgh+91VlLPekqi5Bg9iC/RdAZcwusc3Szij4/YSJ3bwpCHqD4vT9ntN41bRwc+1h0xssiCFCxvcYx4aW+2YM4Seht6RjtHi6dx++Ew1FbxZ510f2sW53i8f81zheGK/7Hnzmh+gBwfAv0lcMyxrNiYui+JG9zG+GZD74UkQUIPGXS2BblAsyL5zhtb7lS63Be/ik/mNsQF1OvV2qJ 1uDKwgNa LapV5vr2ZrY3GAGr+ojxB9htxUuQ7oQoljahBQ+2JmbWviWgAQ/Eaw2Vk54LGIoN/1Ab8IFp+pNSOIYSfy61NAuGyhMokOAvOtQDeAHpzaH+sa/FQI75ANtKOakawj/lpASPYWDGNBlUt4EY+RIdoFx8AFyFjjw4/I2a/WKaml/paUVw4uJ1unwzZ55Jdy8q7r/QyhlE24o0+kpyNrs3sTVQSrRE+fTtyiNVJgUHloKLpzn1P/DMyQtxE6LBJn6SptbaJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 23 Oct 2023 at 18:22, wrote: [...] > --- > > Changes v2->v3: > - Fix null-ptr-deref by using the proper number of entries for > initializing the stack table when alloc_large_system_hash() > auto-calculates the number (see patch #12). > - Keep STACKDEPOT/STACKDEPOT_ALWAYS_INIT Kconfig options not configurable > by users. > - Use lockdep_assert_held_read annotation in depot_fetch_stack. > - WARN_ON invalid flags in stack_depot_save_flags. > - Moved "../slab.h" include in mm/kasan/report_tags.c in the right patch. > - Various comment fixes. > > Changes v1->v2: > - Rework API to stack_depot_save_flags(STACK_DEPOT_FLAG_GET) + > stack_depot_put. > - Add CONFIG_STACKDEPOT_MAX_FRAMES Kconfig option. > - Switch stack depot to using list_head's. > - Assorted minor changes, see the commit message for each path. > > Andrey Konovalov (19): > lib/stackdepot: check disabled flag when fetching > lib/stackdepot: simplify __stack_depot_save > lib/stackdepot: drop valid bit from handles > lib/stackdepot: add depot_fetch_stack helper > lib/stackdepot: use fixed-sized slots for stack records 1. I know fixed-sized slots are need for eviction to work, but have you evaluated if this causes some excessive memory waste now? Or is it negligible? If it turns out to be a problem, one way out would be to partition the freelist into stack size classes; e.g. one for each of stack traces of size 8, 16, 32, 64. > lib/stackdepot: fix and clean-up atomic annotations > lib/stackdepot: rework helpers for depot_alloc_stack > lib/stackdepot: rename next_pool_required to new_pool_required > lib/stackdepot: store next pool pointer in new_pool > lib/stackdepot: store free stack records in a freelist > lib/stackdepot: use read/write lock 2. I still think switching to the percpu_rwsem right away is the right thing, and not actually a downside. I mentioned this before, but you promised a follow-up patch, so I trust that this will happen. ;-) > lib/stackdepot: use list_head for stack record links > kmsan: use stack_depot_save instead of __stack_depot_save > lib/stackdepot, kasan: add flags to __stack_depot_save and rename > lib/stackdepot: add refcount for records > lib/stackdepot: allow users to evict stack traces > kasan: remove atomic accesses to stack ring entries > kasan: check object_size in kasan_complete_mode_report_info > kasan: use stack_depot_put for tag-based modes > > include/linux/stackdepot.h | 59 ++++-- > lib/Kconfig | 10 + > lib/stackdepot.c | 418 ++++++++++++++++++++++++------------- > mm/kasan/common.c | 7 +- > mm/kasan/generic.c | 9 +- > mm/kasan/kasan.h | 2 +- > mm/kasan/report_tags.c | 27 +-- > mm/kasan/tags.c | 24 ++- > mm/kmsan/core.c | 7 +- > 9 files changed, 365 insertions(+), 198 deletions(-) Acked-by: Marco Elver The series looks good in its current state. However, see my 2 higher-level comments above.