From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5EDEC433F5 for ; Tue, 22 Feb 2022 18:48:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13D388D0002; Tue, 22 Feb 2022 13:48:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EAA48D0001; Tue, 22 Feb 2022 13:48:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1D008D0002; Tue, 22 Feb 2022 13:48:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id E399D8D0001 for ; Tue, 22 Feb 2022 13:48:52 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A5E9018096C77 for ; Tue, 22 Feb 2022 18:48:52 +0000 (UTC) X-FDA: 79171302504.12.7975828 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf12.hostedemail.com (Postfix) with ESMTP id 0D73040006 for ; Tue, 22 Feb 2022 18:48:51 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id g6so21787729ybe.12 for ; Tue, 22 Feb 2022 10:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GEvSCVwL/A3X3tCkaLLRRca+X+c7l6RWUROLPaM/Tx8=; b=rXGJIwjZlw3ACce5I3PFgeBjPS4fxuCYFOC2yx/AzU0OAp27JOu69nttt75RbiM0Rq +EFdpKhNyDOttFvq/XDfKuL3YIMcHnKFAdnwkxKPdELzMw/Fb/RajpsO0Q0Gw2gHBFLw dkUQxjNbQ4LU/8W/DMJLa/aan6kw01C//FtMYXz6gxOZkUJBtH2ATHdDucOM2Xsb1s3O WC505All0OB8eiocoWY8OAWdS7ec05vcs+Fbv5FNmamEZ43iDLEBykTFUKBQYghe+LyQ UBlTpXwVtJL25BPaVuhObMxdLZpW6bfM+4qZd8OCHTO7K2RJKzSUPbENzcLxp0s4snyN YBvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GEvSCVwL/A3X3tCkaLLRRca+X+c7l6RWUROLPaM/Tx8=; b=zADIjPVOBcsUfcaUBdm2z03y2qj/ukQhiulUAhImJ5zPO9FFLhidaKpoTbTxkogM4p yYbIuWtMXrMFhSvVSSfQPcEW2LMYF1yW4bZhzxnRl3if27zT9Yqnr7cymDAdrUv7CJFz U0Hxpgo4vj/uho+8j+NvwnDvmHzANbp0qVNG5i3kzsEomz9SseXPXfXQM6wZI5O18ZPW 7jiJY1yiPhZql4CSgmVga0fywG5UspyFF4hePp4BR6gTNgY8GOg5uUk+03IcfkpZl8fG PsNCvGER6hxLcGK3aML1nVJnDtSdXCC4WcwMkJYGcqhimcVRwP4pcPye/3iGHVaDRTe7 biDQ== X-Gm-Message-State: AOAM532l0DV2FGCGshHh6Q389/1KsqJB8JoPpA5JWdZedrJdcZWNiSsH X2DovXMRx+Dqek1FVlm7HHSq/YDGltCKz24Kk3pOkQ== X-Google-Smtp-Source: ABdhPJxC870BtNHWuFMIKLAeUWoVPt9DVgjg6YJTPrNb7Bn3HlGLHMIuVlPY/D4jk4/S+sixqxL+tjs2qEaIgMtLxRo= X-Received: by 2002:a25:3542:0:b0:622:caf1:2c88 with SMTP id c63-20020a253542000000b00622caf12c88mr20154405yba.625.1645555731413; Tue, 22 Feb 2022 10:48:51 -0800 (PST) MIME-Version: 1.0 References: <019ac41602e0c4a7dfe96dc8158a95097c2b2ebd.1645554036.git.andreyknvl@google.com> In-Reply-To: <019ac41602e0c4a7dfe96dc8158a95097c2b2ebd.1645554036.git.andreyknvl@google.com> From: Marco Elver Date: Tue, 22 Feb 2022 19:48:40 +0100 Message-ID: Subject: Re: [PATCH mm v2] another fix for "kasan: improve vmalloc tests" To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0D73040006 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rXGJIwjZ; spf=pass (imf12.hostedemail.com: domain of elver@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: qo15j8xfmx3tbzws6gegm6fs81hszgyr X-HE-Tag: 1645555731-906028 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 22 Feb 2022 at 19:26, wrote: > > From: Andrey Konovalov > > set_memory_rw/ro() are not exported to be used in modules and thus > cannot be used in KUnit-compatible KASAN tests. > > Do the checks that rely on these functions only when the tests are > built-in. > > Reported-by: kernel test robot > Signed-off-by: Andrey Konovalov Looks reasonable, thanks. Reviewed-by: Marco Elver > --- > > Changes v1->v2: > - Hide checks under #if instead of dropping. > --- > lib/test_kasan.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index ef99d81fe8b3..c4b7eb2bad77 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -1083,11 +1083,13 @@ static void vmalloc_helpers_tags(struct kunit *test) > KUNIT_ASSERT_TRUE(test, is_vmalloc_addr(ptr)); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, vmalloc_to_page(ptr)); > > +#if !IS_MODULE(CONFIG_KASAN_KUNIT_TEST) > /* Make sure vmalloc'ed memory permissions can be changed. */ > rv = set_memory_ro((unsigned long)ptr, 1); > KUNIT_ASSERT_GE(test, rv, 0); > rv = set_memory_rw((unsigned long)ptr, 1); > KUNIT_ASSERT_GE(test, rv, 0); > +#endif > > vfree(ptr); > } > -- > 2.25.1 >