From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D62C636D3 for ; Wed, 1 Feb 2023 12:39:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CFE26B0071; Wed, 1 Feb 2023 07:39:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47FF86B0072; Wed, 1 Feb 2023 07:39:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3477D6B0074; Wed, 1 Feb 2023 07:39:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 228C86B0071 for ; Wed, 1 Feb 2023 07:39:21 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AF0C11402A5 for ; Wed, 1 Feb 2023 12:39:20 +0000 (UTC) X-FDA: 80418678480.19.31C341C Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf04.hostedemail.com (Postfix) with ESMTP id B670340028 for ; Wed, 1 Feb 2023 12:39:17 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Xm8IDE6x; spf=pass (imf04.hostedemail.com: domain of elver@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675255157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w9SOySbmS0Qu5aNxxomWwuDHN5fw98pINHsIoz0E65M=; b=otIveT8rffK1II+JSiz0f5uGvz0qb2ufHO0y78GKHNowrCigdqkmibG0A+oQ5SKULSa0iJ zH4cf8BJv40cm3HcD7pniC7djSkOIB107t5UHNF1s5k1hhpXsG3vM77cmpKqyepYN7Mg1i I/fQVQAI5pEP8V8tX2yujAefoLv1utU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Xm8IDE6x; spf=pass (imf04.hostedemail.com: domain of elver@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675255157; a=rsa-sha256; cv=none; b=LjwyflIxjjHIsmOnyoaI7RUHkwbBOk14blYD6JYxCgAhtDzWIZVC5TjRH8h8N1d5NgAsdj dClbQrpS3Z0MBcyLr9d9QKv5a4GUZ7cTGXX+c2/Xs7giIfb9ATVMMCSNw3Ry/6QU3rFd6J jNBVW3bqjazR4blSiqRyeSo5yep8158= Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-50660e2d2ffso244498447b3.1 for ; Wed, 01 Feb 2023 04:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=w9SOySbmS0Qu5aNxxomWwuDHN5fw98pINHsIoz0E65M=; b=Xm8IDE6xGlICK6pCDLTH1BYezg2m3vHDH3GWEtjzilEf4S8g6nW7e4KHnwrGzExYvk r0HWltfzMTrq7xrOKXlr2o2nqf1uyZFoYpNwkWoozAk/AmIa2qIxExmvuokPvCrdPP51 L31Qc7w7VKNt1+1cyeji2LyT6rHU7tsRHUgyXxiD9/aPZ0gcVPVEh4/fy8H5RmVH1iIE Bjs4EzADrdJ0YcHkUPy+6jfPA0+GdTem64kn5rMzLm7Wz40WCQMDy+L0T3YOzSki49qM Rsp4i3h7hidbebLppnLRWzCUMEiQfYddswZypm2eTf+iRzgC2m7iaBO0u+9i/GHv0UDo KXUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w9SOySbmS0Qu5aNxxomWwuDHN5fw98pINHsIoz0E65M=; b=nmrYvb+nP5IB9JlsmR8eYzfY5R5SVDbYYKYOqjnyBLdU4kkW1fb1hZiFgYsdNXwOuq oLp+GVDDVK6f0/7/U6LtnsMfXsbycHywmB6lNzaKDKjjz84JWTx2BOjqarI4oT9fCQ5N IF9sw4pAQ9HxiqbPUhqHlqluTmvPaaH/o+iVPvZxelVw4zn8NY2qazyl48ppQ8jKuT8U JMdJFXdvFBoRstcG7MyWbV/bZqqmlKxeE8zc1Vs2FeFSn3k7aKvEmRPYrQUszHwLX5gJ BVqyFFrTQoBbQcNUvnFbkQa5OZBqUtWZDq3MfZQlJghYZWcvSmk4YssRuCN5Zy7+d0cB c78A== X-Gm-Message-State: AO0yUKVtK07rRyFCRHOap1Aa5O/VQa8KhLCK+98Os1HHv+a2hArdJhoz E/xYRDDaE/SFCUXv/NwIBIfHGjZgfVDh2CdN2MgrnQ== X-Google-Smtp-Source: AK7set8zxc4D3iz25SvqBAE+y1UUbHjrFQJ7RyKAPdba3B+Svi09uuC7dLhYMHj1INUaPy8cHUXAH+rP13dUdko52zA= X-Received: by 2002:a81:fe02:0:b0:506:369c:69c1 with SMTP id j2-20020a81fe02000000b00506369c69c1mr283708ywn.192.1675255156688; Wed, 01 Feb 2023 04:39:16 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Wed, 1 Feb 2023 13:38:40 +0100 Message-ID: Subject: Re: [PATCH 11/18] lib/stackdepot: rename slab variables To: Andrey Konovalov Cc: Alexander Potapenko , andrey.konovalov@linux.dev, Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B670340028 X-Stat-Signature: 5jex4esaimbuxtkdxdyu7gsypoihhgex X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675255157-646888 X-HE-Meta: U2FsdGVkX19wj8+RcJlp3OAZ0JcKDKjQPgkb0Xy7tawEz5U3FypyN0w6+IMxBSDK4OL+emWbOQHh37hwT+ej+ewELQakrwvV5aVuQFxDVQvnqBEEe72J3V8640nuXjJqBRLQaUKQFdAUJX/bwj4TKriZiDmATYKHYA2YPZev+A/eQasTmXPTQhhmQdgryx8XkmUVI36JzdkACxIF3Y77RhV6yj9kvCiB6YQe37zDbbkxzCJRcwwAAKrAHwNBVg8ju5/B1ZS3GgMYfW3D87EDG/ilXy9hKxFY32np1aktMolwD5AjCaoxUn3rM0G2RxR8VpBmMFM+zH9xHsKc2eTfi+dD3sGSqHCcPTQEBuDpcWJJijnp8arV+n0BrzBZWVfEtnLrxmvZbWQB85kufkv55MFq86e5AJhmKAN/VX2d2mWHTt1j/Z7/Xe5UTV6uiXd2Cx4IT39siGYZQnzBOQsXVIyBCR9L6GydRLAVe7ABQrbUvO5T2jGHlkxFjtiCX3Ft0VEO4iE5Iy5Cb9SRsm0Bfp3FlCM8IdzwbNCWSufQCjZYNKOwthR5RRkA5G8sOxeeWDialvUgvrWiB05Y4ZP+hTOVledL3zkYLZRjRR/lQtkzm/UGA8dy8YIT59ltQ0TxLQl8feuQDlDMdwDaBcKvH14lucDTltoeoPgfAEj3lae5NZSBTM/64xs1tKsers0pACthGWJ+oP7ctx2Hw8Eu4AeLzXi9gstdQnqCd/aXIMem2vSYGVFLh9Y+utUAtWF0aLCq5ypMO9gLtI8MJt4vWslngbf7NY7PpGXOpXlZ8v3l5QSdUSGH+WetZRAWuHDJjqiNQpXUE0ZBBpGmAEeKwGRg27ARReoqj2ZtOFrbLPHLlMpcYlBAY7EblgteLFfipu6AlZkyuy6A59LARHyI4Mbh9XJeuGJvaUTI8m2gZ9Vhw+bM8oY6F8Q2wgunc3tdoAYpLuK633lmkg3NgEO R1PZbKF6 PL44OmBnayNh/jTSz86Wg3oqKSjocC7qnMOiSQfd81epSfGy9JWZCjkpNcF+i2SPNpzMTj1Az8oVB6awczo0kSBCQHCVFnA4ZJXyHr6M7F1hxRz8MccDX0eeb7pj5WvU5/B3kYcCqTG76AaGJzv1JS70jOAIRHCIz4zp/YbKn7/E+pX456lr4CiYWWUDs4Vx9HrGHinND0PLN7k/iCXO81R/IYNQ9EzWezv7nts4l4Gj6pDS5EyQ9mhB0gYz5/AjECLRmIqbDcE+bvusjPBpZGYUbQEVPCcDEdlm7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 31 Jan 2023 at 20:06, Andrey Konovalov wrote: > > On Tue, Jan 31, 2023 at 12:59 PM Alexander Potapenko wrote: > > > > On Mon, Jan 30, 2023 at 9:50 PM wrote: > > > > > > From: Andrey Konovalov > > > > > > Give better names to slab-related global variables: change "depot_" > > > prefix to "slab_" to point out that these variables are related to > > > stack depot slabs. > > > > I started asking myself if the word "slab" is applicable here at all. > > The concept of preallocating big chunks of memory to amortize the > > costs belongs to the original slab allocator, but "slab" has a special > > meaning in Linux, and we might be confusing people by using it in a > > different sense. > > What do you think? > > Yes, I agree that using this word is a bit confusing. > > Not sure what be a good alternative though. "Region", "block", > "collection", and "chunk" come to mind, but they don't reflect the > purpose/usage of these allocations as good as "slab". Although it's > possible that my perception as affected by overly frequently looking > at the slab allocator internals :) > > Do you have a suggestion of a better word? I'd vote for "pool" and "chunk(s)" (within that pool).