From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0376DC4332F for ; Mon, 14 Nov 2022 07:01:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 165116B0072; Mon, 14 Nov 2022 02:01:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 115DD6B0073; Mon, 14 Nov 2022 02:01:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1F846B0074; Mon, 14 Nov 2022 02:01:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E2B376B0072 for ; Mon, 14 Nov 2022 02:01:33 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B129E120A9A for ; Mon, 14 Nov 2022 07:01:33 +0000 (UTC) X-FDA: 80131152066.17.1ACE555 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf02.hostedemail.com (Postfix) with ESMTP id 69DCB80016 for ; Mon, 14 Nov 2022 07:01:33 +0000 (UTC) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-367b8adf788so97951137b3.2 for ; Sun, 13 Nov 2022 23:01:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=T8++jjvsG0oXPi9XkXPJNv66frIPVuEbhLDe6tRY0RU=; b=Mit4/wrbIr9xEAha0HHHyg2FaGR4UQVpWhD8bV88rdWQLdq8Db1QqDANasjWI4q01k GRlCEXpGigu1GxcBuBvX76gXqBqgJB59mC6dEbI1WVjdolbyykQDyO7t4cJhWhY/Cnkv vlVzr1FfXCP3c7dchMGAzG+2d/hPW4NIDUFDGqTF3VR69Frld5yLCdjb+uMB2t1YiZrK 4IJyqZTr0kB5DWIkqmo8R2gffOSL+SqaPwL1QczAtfC6t64YFNvO9B5Lo9uxnP9mn7QA wrBI+h3dMRCrt1zodWIRayhOiwZS54qos/Ncq6FqAhakOXiOQGjUmxYex4+L0fthTNDY gfIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T8++jjvsG0oXPi9XkXPJNv66frIPVuEbhLDe6tRY0RU=; b=JSTGDZuaBOzp4ruuOc7qLr3XyPmfnAcwDPt7W4QQ3Y8pom87skHjGFgZjTejCDqp/m OJwqM1Z/0AnVbBH88yrx+oUrszspcQmJjDZhWNXC8I+PKvmMg5w/JWudy5tmGo1ByZba Pu1CQXMSAlEPWbVqKCBE0KLYPNviNWKNbEdjpn6XLSJMlPclCC7KvqqwIKveOtmWiWQ3 VOsxgXV3/NgahE2oIk7svFCwlnCHk6gFm/J/X2ACJOXN9wE677RMZ85IHijQZltfSA0o NPwW7PbpwG72ISP+QgRf8rM6wFcvoCeC6YZ0MoqvOOqlRiEHoamBpry3ESEuEp6D8wXk mCZA== X-Gm-Message-State: ANoB5pm9g04V5/GrSBu2ME62owbg0NYR3ROTBnR9J6LXuyKxbcc0UqEd uG5ybJvUDvWBX2NXnWB2nX8qAMfQMMXlyi+5XcnXcQ== X-Google-Smtp-Source: AA0mqf7aaJuxLskBjfM+h8wmOFyBzzttsEbh4O1ZiJ/cHfJxEv3XIvoj1jdc+vUp0WOwBJSZLaTG4JS00+8SbZS3hx0= X-Received: by 2002:a81:13c1:0:b0:373:4460:e8bd with SMTP id 184-20020a8113c1000000b003734460e8bdmr11548114ywt.11.1668409292543; Sun, 13 Nov 2022 23:01:32 -0800 (PST) MIME-Version: 1.0 References: <1667986006-25420-1-git-send-email-quic_pkondeti@quicinc.com> In-Reply-To: <1667986006-25420-1-git-send-email-quic_pkondeti@quicinc.com> From: Marco Elver Date: Mon, 14 Nov 2022 08:00:00 +0100 Message-ID: Subject: Re: [PATCH] mm/kfence: remove hung_task cruft To: Pavankumar Kondeti Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Peter Zijlstra , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Mit4/wrb"; spf=pass (imf02.hostedemail.com: domain of elver@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668409293; a=rsa-sha256; cv=none; b=O0gbBmDk5v/k+GKA0bTK5KL91/l+cqGlwiNCk+FqlmGi4ZG5e/eKzBgKAluFgT/FHYe5QX kvt36ZILQl7Hg3447Ges616i2/DJ1Lqm9cSVmPGk9sysSgIfF/TWm+aONG7UevT4CIXtXH UHM2JrtrSpndxwZVrM5d2dhA2CbMhXs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668409293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T8++jjvsG0oXPi9XkXPJNv66frIPVuEbhLDe6tRY0RU=; b=kfJvfsigXdN0puggpLw8LIg8Dfw5lJ0BtlHAqNnX61kueDrqmDcrqeQuzA94ZmBx/EU5II gokabAd5NqJhIUhZeKN3OMGTiG2ylEdcvim236bwkQf3ocCAVqaLImN5o5vgvY1ZYTmTZU /Q9yr70XixWninAZc3KoN1QBLpPwatg= X-Stat-Signature: czg3tds7ispmb6keyuhtc6r5uncwabm3 X-Rspamd-Queue-Id: 69DCB80016 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Mit4/wrb"; spf=pass (imf02.hostedemail.com: domain of elver@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam11 X-HE-Tag: 1668409293-876620 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 9 Nov 2022 at 10:26, Pavankumar Kondeti wrote: > > commit fdf756f71271 ("sched: Fix more TASK_state comparisons") makes > hung_task not to monitor TASK_IDLE tasks. The special handling to > workaround hung_task warnings is not required anymore. > > Signed-off-by: Pavankumar Kondeti Good riddance, thanks. Reviewed-by: Marco Elver > --- > mm/kfence/core.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 1417888..08f5bd6 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -26,7 +26,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -799,16 +798,7 @@ static void toggle_allocation_gate(struct work_struct *work) > /* Enable static key, and await allocation to happen. */ > static_branch_enable(&kfence_allocation_key); > > - if (sysctl_hung_task_timeout_secs) { > - /* > - * During low activity with no allocations we might wait a > - * while; let's avoid the hung task warning. > - */ > - wait_event_idle_timeout(allocation_wait, atomic_read(&kfence_allocation_gate), > - sysctl_hung_task_timeout_secs * HZ / 2); > - } else { > - wait_event_idle(allocation_wait, atomic_read(&kfence_allocation_gate)); > - } > + wait_event_idle(allocation_wait, atomic_read(&kfence_allocation_gate)); > > /* Disable static key and reset timer. */ > static_branch_disable(&kfence_allocation_key); > -- > 2.7.4 >