From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 758A7C433EF for ; Mon, 24 Jan 2022 08:25:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 000276B0081; Mon, 24 Jan 2022 03:25:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF21D6B0083; Mon, 24 Jan 2022 03:25:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07C36B0085; Mon, 24 Jan 2022 03:25:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id D4D196B0081 for ; Mon, 24 Jan 2022 03:25:49 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8A45B8F174 for ; Mon, 24 Jan 2022 08:25:49 +0000 (UTC) X-FDA: 79064497218.25.272A6BB Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by imf07.hostedemail.com (Postfix) with ESMTP id 2CDCC40028 for ; Mon, 24 Jan 2022 08:25:49 +0000 (UTC) Received: by mail-oi1-f180.google.com with SMTP id s127so24383702oig.2 for ; Mon, 24 Jan 2022 00:25:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K5Kon1fyx96zs+S9bI+PC9J+wxhNv56hJEaz7FbSFSE=; b=eazm9+k5NrSkysNa4r0Etw/X4kuNIAgY2x0kj7nlI9lFPb6h4Xs6BwKJDPGQ+z3Y9P 2XjCpVQ99nUVkdVvIR+f7P6/KjIpbVESJnVrtlGzipUn5sYQJg5O2foAbtHA2EjbElPi 9Sj6z+OszOIDJT247jEQPO9zI+nSzuL79xivSwW1VtJSEA99a/QdKzN7Pamgsk7qOHk7 HmVcTzATtNIn2RIRXLLegt4OYVIJTQn9aQTaSJMta+mraS7Rv7MJM84g6Og7EQa+WqOl hriMvAi26Qz3zrY1+keHAYUowvfb2AJqsVj2ApjjqNycg8KtiK7q9CcyOzvTZ8AEbRg7 VlKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K5Kon1fyx96zs+S9bI+PC9J+wxhNv56hJEaz7FbSFSE=; b=YikZPKaHmtzxgq0weJqpxUrmFgrFk4YeUFVJx2yKBmuO0vRNPjlZvFvtc69x4holNq hQGm8lXamnqhtwlhOjOLxxHpUWZl5WieIEGf7/D+6+MCpZaok+GQaWiWmrSCs+OUz502 QEFaWM6xooIbmgXVVUZ6MM90Ph+lhJJmLcPDFCC8L5kHZUr4mf+OTSth3gaI1rbQ8Jvv 7brsHRA57fego/Y/v5VDfAwe7V+KJsglKxoYaQEzC+1E6oQh21/l6lFfaQcqPh2FFkPb BPbdsDpU3Pxtwh6QW31PStWJTYT0njt59uoUzTsx6eGFer3i4uXi63cOaP2L4sLEmkPc h2XQ== X-Gm-Message-State: AOAM532CDxWjEx4Qq4IxFEM5G3lKj4G/NbVLoVrs7VD1HmoZ24DauvI/ 4dwRPCXG4PgTW6Uvc5ea2u0xHcMlAoJyd6yNQWauIw== X-Google-Smtp-Source: ABdhPJy/mCoQ+yHuD/GHeBHQU6ztq1bT+RAtkGasd/wxL3uYVGLEuF1Vk0VGXgNWZnYdPvLrGxKFp1OI8pKW7eAq7Iw= X-Received: by 2002:a05:6808:a97:: with SMTP id q23mr606047oij.4.1643012748254; Mon, 24 Jan 2022 00:25:48 -0800 (PST) MIME-Version: 1.0 References: <20220124025205.329752-1-liupeng256@huawei.com> <20220124025205.329752-4-liupeng256@huawei.com> In-Reply-To: <20220124025205.329752-4-liupeng256@huawei.com> From: Marco Elver Date: Mon, 24 Jan 2022 09:25:36 +0100 Message-ID: Subject: Re: [PATCH RFC 3/3] kfence: Make test case compatible with run time set sample interval To: Peng Liu Cc: glider@google.com, dvyukov@google.com, corbet@lwn.net, sumit.semwal@linaro.org, christian.koenig@amd.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2CDCC40028 X-Stat-Signature: hbao1iqrf7iatg18ruao7qy1crbwqg67 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=eazm9+k5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of elver@google.com designates 209.85.167.180 as permitted sender) smtp.mailfrom=elver@google.com X-HE-Tag: 1643012749-672185 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Jan 2022 at 03:37, 'Peng Liu' via kasan-dev wrote: > > The parameter kfence_sample_interval can be set via boot parameter > and late shell command. However, KFENCE test case just use compile > time CONFIG_KFENCE_SAMPLE_INTERVAL, this will make KFENCE test case > not run as user desired. This patch will make KFENCE test case > compatible with run-time-set sample interval. > > Signed-off-by: Peng Liu > --- > include/linux/kfence.h | 2 ++ > mm/kfence/core.c | 3 ++- > mm/kfence/kfence_test.c | 8 ++++---- > 3 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/include/linux/kfence.h b/include/linux/kfence.h > index bf91b76b87ee..0fc913a7f017 100644 > --- a/include/linux/kfence.h > +++ b/include/linux/kfence.h > @@ -19,6 +19,8 @@ > > extern bool kfence_enabled; > extern unsigned long kfence_num_objects; > +extern unsigned long kfence_sample_interval; > + > /* > * We allocate an even number of pages, as it simplifies calculations to map > * address to metadata indices; effectively, the very first page serves as an > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 2301923182b8..e2fcae34cc84 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -50,7 +50,8 @@ > > bool kfence_enabled __read_mostly; > > -static unsigned long kfence_sample_interval __read_mostly = CONFIG_KFENCE_SAMPLE_INTERVAL; > +unsigned long kfence_sample_interval __read_mostly = CONFIG_KFENCE_SAMPLE_INTERVAL; > +EXPORT_SYMBOL(kfence_sample_interval); /* Export for test modules. */ While it would make some situations more convenient, I've wanted to avoid exporting a new symbol just for the test. And in most cases it only makes sense to run the test on a custom debug kernel. Why do you need this? Should you really need this, I suggest at least using EXPORT_SYMBOL_GPL. Should you want it, you can resend this patch standalone detached from the rest. Thanks, -- Marco