From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E2EC07E99 for ; Mon, 5 Jul 2021 11:18:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3DDC7613AB for ; Mon, 5 Jul 2021 11:18:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DDC7613AB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E6B9C6B0036; Mon, 5 Jul 2021 07:18:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF46E6B005D; Mon, 5 Jul 2021 07:18:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C46A06B006C; Mon, 5 Jul 2021 07:18:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 9B1216B0036 for ; Mon, 5 Jul 2021 07:18:19 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 220CF2125F for ; Mon, 5 Jul 2021 11:18:19 +0000 (UTC) X-FDA: 78328285518.37.75FA397 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by imf15.hostedemail.com (Postfix) with ESMTP id D4E7CD000081 for ; Mon, 5 Jul 2021 11:18:18 +0000 (UTC) Received: by mail-oi1-f172.google.com with SMTP id 11so20414417oid.3 for ; Mon, 05 Jul 2021 04:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vQCc966SXUWmxUzITD8j4jyP6srsgCllnc0jbweek7I=; b=cHNJERRyJ5VgZnacJnPR2MSdn7fGw163AVo+S8UOuAHCb3pTWYCdTRFFjXaaX8GkUb 3VfdXnRbb2gNfY1PFm+w169rVHlgjvTg4J/NZqi+D5KtNopaQpI62sgNlwhOKwkOjn3y aM+SXKcxWLnYQ+r1haUMgwW3xnEhGhMTsG+YAeJZyz1+/dc1nFWsBFgA1VXoqvVk++2Q 0kE8crVgqijSkqQPO0CHETGmpCmCd0ThqeaWg+kqtaSyiqhCH5KBYwsxiUIJ5ShGQqKO iurHsCrPJm3nkwLQlVSC07Vdwcb/5L/UBAoEfarVZbgjvJaIn/GOank5f2zy1cl0fsBU 6Gdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vQCc966SXUWmxUzITD8j4jyP6srsgCllnc0jbweek7I=; b=Dcw1ARKzyqZhi6xTLkOp/DAjm0gsSBHpl9M+mAQ1OywTw6rq6EPza6qiRQ5gOhwhSG noKFkUSGeAs/dCZrZw2UBz/B4XxnJQgaXposjhe+MTNRhkqKrHlhOAVoBF7BwPZBmrTE Diu7cbctBGEC+c6B9Nhby+3poMbrlcrdxKFQmW4wgKw69buLGz5rj31300L2cB72HtVG lXV6gL2XgX5VhKXhFxVgda63cpEi+HhgT8fvdpveSxg1xI//2j+y+ycQorrdYBdJqJKa BS1HKhyI0NRd6un1jMffLxpXRfTUgSqBGOi+GaPeo6ZlnMD4I8zGoHM3uIJu1WaJCTe4 QYxQ== X-Gm-Message-State: AOAM5321fHU64o2hXslRyRHpCeAD+9uAI+HrJTF/nQqvt8sI+YQNnI2P JWtPsNUI9/K23eprntf9K1pZiaVw3dxpOsobqZ7iPQ== X-Google-Smtp-Source: ABdhPJwzSMEuJSuh2QrLP5wculi4/MRed4/0p4GmnpoFWoc1/Fz8hjBkQyR9qR+/z38D9zBccESL4gX1oPMqqkjt4Qo= X-Received: by 2002:a05:6808:2d9:: with SMTP id a25mr9673299oid.70.1625483898064; Mon, 05 Jul 2021 04:18:18 -0700 (PDT) MIME-Version: 1.0 References: <20210705103229.8505-1-yee.lee@mediatek.com> <20210705103229.8505-3-yee.lee@mediatek.com> In-Reply-To: From: Marco Elver Date: Mon, 5 Jul 2021 13:18:06 +0200 Message-ID: Subject: Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG To: Andrey Konovalov Cc: yee.lee@mediatek.com, LKML , nicholas.tang@mediatek.com, Kuan-Ying Lee , chinwen.chang@mediatek.com, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Matthias Brugger , "open list:KASAN" , "open list:MEMORY MANAGEMENT" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=cHNJERRy; spf=pass (imf15.hostedemail.com: domain of elver@google.com designates 209.85.167.172 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D4E7CD000081 X-Stat-Signature: goia9y7p8ytg7wy6ufswzscrziwgkbes X-HE-Tag: 1625483898-252781 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 5 Jul 2021 at 13:12, Andrey Konovalov wrote: [...] > > + /* > > + * Explicitly initialize the memory with the precise object size to > > + * avoid overwriting the SLAB redzone. This disables initialization in > > + * the arch code and may thus lead to performance penalty. The penalty > > + * is accepted since SLAB redzones aren't enabled in production builds. > > + */ > > + if (__slub_debug_enabled() && > > What happened to slub_debug_enabled_unlikely()? Was it renamed? Why? I > didn't receive patch #1 of v6 (nor of v5). Somebody had the same idea with the helper: https://lkml.kernel.org/r/YOKsC75kJfCZwySD@elver.google.com and Matthew didn't like the _unlikely() prefix. Which meant we should just move the existing helper introduced in the merge window. Patch 1/2: https://lkml.kernel.org/r/20210705103229.8505-2-yee.lee@mediatek.com Thanks, -- Marco