From: Marco Elver <elver@google.com>
To: tangmeng <tangmeng@uniontech.com>
Cc: glider@google.com, dvyukov@google.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kasan-dev@googlegroups.com
Subject: Re: [PATCH] mm/kfence: remove unnecessary CONFIG_KFENCE option
Date: Mon, 21 Feb 2022 09:56:03 +0100 [thread overview]
Message-ID: <CANpmjNNTsj-+=BBbt2pcbrqwOmiixjc6fE=Q=JoT=2kQfR0y_Q@mail.gmail.com> (raw)
In-Reply-To: <20220221065525.21344-1-tangmeng@uniontech.com>
On Mon, 21 Feb 2022 at 07:55, tangmeng <tangmeng@uniontech.com> wrote:
>
> In mm/Makefile has:
> obj-$(CONFIG_KFENCE) += kfence/
>
> So that we don't need 'obj-$(CONFIG_KFENCE) :=' in mm/kfence/Makefile,
> delete it from mm/kfence/Makefile.
>
> Signed-off-by: tangmeng <tangmeng@uniontech.com>
Looks reasonable, thanks.
Reviewed-by: Marco Elver <elver@google.com>
> ---
> mm/kfence/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kfence/Makefile b/mm/kfence/Makefile
> index 6872cd5e5390..0bb95728a784 100644
> --- a/mm/kfence/Makefile
> +++ b/mm/kfence/Makefile
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0
>
> -obj-$(CONFIG_KFENCE) := core.o report.o
> +obj-y := core.o report.o
>
> CFLAGS_kfence_test.o := -g -fno-omit-frame-pointer -fno-optimize-sibling-calls
> obj-$(CONFIG_KFENCE_KUNIT_TEST) += kfence_test.o
> --
> 2.20.1
>
>
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20220221065525.21344-1-tangmeng%40uniontech.com.
parent reply other threads:[~2022-02-21 8:56 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220221065525.21344-1-tangmeng@uniontech.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANpmjNNTsj-+=BBbt2pcbrqwOmiixjc6fE=Q=JoT=2kQfR0y_Q@mail.gmail.com' \
--to=elver@google.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tangmeng@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox