From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47310C4332F for ; Tue, 12 Dec 2023 19:30:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C60716B033E; Tue, 12 Dec 2023 14:30:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C10866B033F; Tue, 12 Dec 2023 14:30:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD8A16B0341; Tue, 12 Dec 2023 14:30:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9F6686B033E for ; Tue, 12 Dec 2023 14:30:40 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 78F0180B22 for ; Tue, 12 Dec 2023 19:30:40 +0000 (UTC) X-FDA: 81559158240.09.ED8A5E2 Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by imf21.hostedemail.com (Postfix) with ESMTP id B849D1C001B for ; Tue, 12 Dec 2023 19:30:38 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1dD15iaQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of elver@google.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702409438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pcoi2NJ5WlkDrXij7nG/i+1L6bQHIDHmRGBrwHts7ds=; b=AEjcfn3yUpyJDc3lDsd68FUTeJVpyfjgRklB73z8oBDU6/TsSCcebxj6rrduTnx+N6gT0x yasKCgr8ioRBETdQx7PJKKd2ZuMwsiwMwJFUDIIQzfjm37tHZ3yUDaFvHfafsvRgQtG6Lo /dQ7Yi8LQ+/XTCSaD/fLBFv2p/bTfoM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1dD15iaQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of elver@google.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702409438; a=rsa-sha256; cv=none; b=hiVwV9C0bay/HpWMbW3t6wgxkPo0syZTblJpJDR9viObz77Qhoh74qh7lKoHf1rsnoPvcV xFyOs0RCjGVzuco7KV2TNyN+UPEkOwW/BTrXGsfVauGq4PXgV3JmgOjbL4nlNh7U3fClf8 KdqczOAtVcRnzNLVnROEHGwwc1m9Y5I= Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-7c5cb5eeab1so2037948241.3 for ; Tue, 12 Dec 2023 11:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702409438; x=1703014238; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Pcoi2NJ5WlkDrXij7nG/i+1L6bQHIDHmRGBrwHts7ds=; b=1dD15iaQTm8e9fko76f5l5DdKn6dvqJMziwCgufviEgURlnUiyM5QWMa4pm7rXs2wA 0DX6NbOyBctHO/Q7KLeFy11N0r9Eie4UehnSINxXAseVD/qpPLxt0omlKFPfF1IR1IgS Le2dUHqQVYupHQ9dXTpimp4xdnzIxsQLp8vamZDfPeNXHT/pkGbm5xH6pn5k59BZxdT2 T0HKG4L7FGKz05a/YVz+LoIbceOBP01pAjOpvkzkO+S8gk3Df5fG+kQR3LhgHub5lQeC dnU7AbgcOD+jyH5tP9CeZPPVhSzswVfDuJEyZdmFP9pcshM5hW9DF63cSuQwHHXg7TnP mq+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702409438; x=1703014238; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pcoi2NJ5WlkDrXij7nG/i+1L6bQHIDHmRGBrwHts7ds=; b=kOfq0Hr4a3M2YhLoVEJkUNBBOoMXjm8ff5ugiO7233xWCmbA1Naocz77KHAUo/hHBn aBsld+mIyZUb/qZTlswcYnF0VaVTg1uZBg24qDXsTx9uaFNmcAo9ZivCNt2eSOf5MyBx 9Llaiejmu0XMmSGSuEXX8YV1Q6c0EEyCXQZp+bvInn8pZm6/5U4UKY5mQx1EWaWwD2q4 FveAjNpSBD+Xp4Pd2+mtGThFkUa3TWbSj7TjMTbpSOLaWRzFeU16rBQuhK6EGi87DyQ1 XM2L5Mq1oQKPU/0DUg+j4bHjiwWmg1vdD9XmHgroY7x6uXwXezgp09Z4SVopIcFCxa4y 0Liw== X-Gm-Message-State: AOJu0YzhzEUdOvNaNJ0eXqwqEOYcIeUpGXKfHbtIDH/2gTMNEqUQ5VIa YNhWxMM9AEcGDiHB0WUSN2gO0QEXnTyQhm2cl+DwYf5dOMQ+xlAZJ3M= X-Google-Smtp-Source: AGHT+IFFYsOyN/3AYlxu0hMyGsXXOjsnSyeVU9PlVy7sfaaSLsLOBXbgAvu4WYOa2L4VQB9LFX7A9Ttrk9JV9h6+NMA= X-Received: by 2002:a05:6102:510a:b0:462:8ca2:1bb0 with SMTP id bm10-20020a056102510a00b004628ca21bb0mr4858842vsb.20.1702409437702; Tue, 12 Dec 2023 11:30:37 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Tue, 12 Dec 2023 20:30:01 +0100 Message-ID: Subject: Re: [PATCH mm 3/4] kasan: memset free track in qlink_free To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B849D1C001B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ebpt4k16srhtceupyosnes8ok7dui9fu X-HE-Tag: 1702409438-890144 X-HE-Meta: U2FsdGVkX19uwe7RP73CVGbbEaCVBKiM6UlqlKTd7gf4LtY1yIODqFiU2puhngx/rY4XsRFNdNUBzcD/G6BVqOYM8+9gOd82U8sckrLVl11Pk2TpYMgQJaILa513+An9ZDgvLxxBiY2vvKJQ4SRy/izwqkxk31sCXkxNlnseLYQO6YvDe2LHMY5R8n2PTK4jF2HWhVd9ay0gvIhV6+Nid82ittJtWUssV0Coj4znoERzRBKfeLl5dPrdiumKWcV+HnXD0rKFfGAtNzboennXqne/i7em/8eok6LE3Q+mHt3teAz/83MTbpMJMJ3RNLolYVCGfjxtHnl9vmbkk2JfXIQ7hsvKK5tmyG0rU1xPFDP6QjNkYmrsQzKkiYLr4LxxWOAYI7+tFnnZ1pSd8zed+VDPANEwp7yU95vtaZCeAotH08buGkiJeO6mXmdqE9gDdDC8bdEPF3sde9k+03URsy9mPznEhxGEOho0btKvArBYPGSHIGcyCneE3GuLVmnIihYKNta87a+rY3qFK51YAEXPPktd2sBonEkEeYjoLY4zfgrtC1gOOcIw9rRgYGRfa6+54/eyxm/lnk+bz+rroso7tA4+VHGRmIXeJycJVK1iHGyDngEblqBLc26egO7JCqWzcsXYGgBhbwoEVMZwEXv2pk4CzIZtoCdUFgMNv6BMh+XeNU51ysby4KXCe0Fznx6EVuqmNL9aUuUzjzLHSnWZxEB5Boznx37HsESyTdZ29CaAurIIRtuAqx0sABvIx1tj2SWpkp7aT4uQu3DO0TuQCWGtnKWdPGKyqALCxrY+dRdunMHmI3Og3/cMcP0DlN63jcyXaVurHAvKZNM7BDho3Af5EVJsuR3C3AaDjPgKyC+lzsBrDd1SmEQI25Nh3BcQEMDB/hKQMxCOeRNZwK7Hc5983yR6VLrSAgjsL2K6XS9y+OZJrtSLeZ5tcJ2QCDU6Ew/3lKNfKs+BfaU XcTjFfGV XW7JqH31abqje3ClYClx3ll7Ss/SeapP7GeP1FWegUnWd5Mrf0bH+mekvZ6uAI2U4UVhalOWfimtlVVcUzJom2GYbdKAKpiQYgg30EcYUt/eyHXtD/93JXNCgXS4fwf5LTEAl8822KqpwLRgR5JxDgJoycnc6GDeO93mKgzTD9On5BjRnkOo3NfMsomaiUmpadCx5BDd7fXLYGO2EBKRIifgVa4grDjy36XbpzLsoeAFEwlNwk8zFT/ktaG8uuj/PVCIO6hca2IOZ8FVRDiBd6m6o6DIba9ZexgE5x7PnKa/q9K7tbgrvuMk6FfK0FFraoF5RWxt6b4V+9nY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Dec 2023 at 01:14, wrote: > > From: Andrey Konovalov > > Instead of only zeroing out the stack depot handle when evicting the > free stack trace in qlink_free, zero out the whole track. > > Do this just to produce a similar effect for alloc and free meta. The > other fields of the free track besides the stack trace handle are > considered invalid at this point anyway, so no harm in zeroing them out. > > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > > This can be squashed into "kasan: use stack_depot_put for Generic mode" > or left standalone. > --- > mm/kasan/quarantine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c > index 265ca2bbe2dd..782e045da911 100644 > --- a/mm/kasan/quarantine.c > +++ b/mm/kasan/quarantine.c > @@ -157,7 +157,7 @@ static void qlink_free(struct qlist_node *qlink, struct kmem_cache *cache) > if (free_meta && > *(u8 *)kasan_mem_to_shadow(object) == KASAN_SLAB_FREETRACK) { > stack_depot_put(free_meta->free_track.stack); > - free_meta->free_track.stack = 0; > + __memset(&free_meta->free_track, 0, sizeof(free_meta->free_track)); > } > > /* > -- > 2.25.1 >