From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86FBC433F5 for ; Mon, 7 Mar 2022 14:08:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AAD88D0002; Mon, 7 Mar 2022 09:08:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0339B8D0001; Mon, 7 Mar 2022 09:08:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E16D28D0002; Mon, 7 Mar 2022 09:08:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id CDECA8D0001 for ; Mon, 7 Mar 2022 09:08:41 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7DFDA1818CC1D for ; Mon, 7 Mar 2022 14:08:41 +0000 (UTC) X-FDA: 79217770842.17.7EFAC11 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf05.hostedemail.com (Postfix) with ESMTP id 0CB66100003 for ; Mon, 7 Mar 2022 14:08:40 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id l2so11667844ybe.8 for ; Mon, 07 Mar 2022 06:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mfdVxCs2eXbpyZ6nxJcq9Zy4MImVpxL60Izt6BU+nxo=; b=SmeiVRFmQ8g7mSnedUz1LcG/NOWQj6Gt+IojkiZXTmkmrvv0y6aAlFY0bQO/Y/Axp7 AGgdTaDFjm9G4t+WmfSjT5YXjWkvZgNF7Mrc55Y76TQ3jyiyeKByVXQtiX7UrpvgOw/K u8TmLiQw25oUjFD4KCsaD9eF9eYkQDDINBAuAJsLb2RZJVhByasnu4eFWAQJw+0nk1U2 dOH7LXlBtQY5+mCaiSNtmOxYnWU6RDwLMfgieAE7jqfV17jRdDJJ5fiPNfaXjmnyTwDa XGXauRoPpOA9sxkfpvSavIN7wG2rkAubrwXldxomdxpuXIKuTpvoSxaHIRfXUf5SE3sR 1E1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mfdVxCs2eXbpyZ6nxJcq9Zy4MImVpxL60Izt6BU+nxo=; b=m2HSlmaHT4vGXmm+BVQdnTNulc8zPP4C/WwjT1189F6KuGja8fc2sqZtVQSYDOqE9W Rf8PUs5ex5ntfi+wG399uzyASQn1MzLldMgBFFYCkSHTO9DeEykNt2ZNQAL0IUwKdZFL /JNibV57VxQJ/Ms0sWYLGnb4r/4aKdb9ynUZWsNYoWHmt0cC37Tjl26Tyue2MC1fuG8l OrsaQ8hCSf9UZAqDXpLKD5x+gWVpKS/U3dqO6AiLGk9Kcjn0Gut4ZB1NFHuF/90+qrg7 2JO7IOxXu5KdfZ9cC3g+d9A5lJIz93d0B9aCBt6v6RGmuXmJMI72Y2JFaR/ucgWwORon sbow== X-Gm-Message-State: AOAM532sTmorqlTYsyaM+Ic8GjnvVrQStYVnMkqh1z4duXefoXoz1lQA Yj91n8b2ypgM5Fp+bkhdEq45JqL1pbQrllhrZSv00w== X-Google-Smtp-Source: ABdhPJx8r4SJMNl3A3gjJ+Oa5BbJgBlKte3tJgN1vRtLq3MCGTlNTu41PJNq1jmWd1EGf3FDC2heiu51uE6dpwP3Z4M= X-Received: by 2002:a25:d50c:0:b0:627:660c:1874 with SMTP id r12-20020a25d50c000000b00627660c1874mr7642377ybe.625.1646662120116; Mon, 07 Mar 2022 06:08:40 -0800 (PST) MIME-Version: 1.0 References: <20220307074516.6920-1-dtcccc@linux.alibaba.com> <20220307074516.6920-2-dtcccc@linux.alibaba.com> In-Reply-To: <20220307074516.6920-2-dtcccc@linux.alibaba.com> From: Marco Elver Date: Mon, 7 Mar 2022 15:08:03 +0100 Message-ID: Subject: Re: [PATCH v3 1/2] kfence: Allow re-enabling KFENCE after system startup To: Tianchen Ding Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0CB66100003 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SmeiVRFm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of elver@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=elver@google.com X-Stat-Signature: y3pamqtxzbc5pfikt7f898383js1z74h X-HE-Tag: 1646662120-908286 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 7 Mar 2022 at 08:45, Tianchen Ding wrote: > > If once KFENCE is disabled by: > echo 0 > /sys/module/kfence/parameters/sample_interval > KFENCE could never be re-enabled until next rebooting. > > Allow re-enabling it by writing a positive num to sample_interval. > > Signed-off-by: Tianchen Ding Reviewed-by: Marco Elver > --- > mm/kfence/core.c | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 13128fa13062..caa4e84c8b79 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -38,14 +38,17 @@ > #define KFENCE_WARN_ON(cond) \ > ({ \ > const bool __cond = WARN_ON(cond); \ > - if (unlikely(__cond)) \ > + if (unlikely(__cond)) { \ > WRITE_ONCE(kfence_enabled, false); \ > + disabled_by_warn = true; \ > + } \ > __cond; \ > }) > > /* === Data ================================================================= */ > > static bool kfence_enabled __read_mostly; > +static bool disabled_by_warn __read_mostly; > > unsigned long kfence_sample_interval __read_mostly = CONFIG_KFENCE_SAMPLE_INTERVAL; > EXPORT_SYMBOL_GPL(kfence_sample_interval); /* Export for test modules. */ > @@ -55,6 +58,7 @@ EXPORT_SYMBOL_GPL(kfence_sample_interval); /* Export for test modules. */ > #endif > #define MODULE_PARAM_PREFIX "kfence." > > +static int kfence_enable_late(void); > static int param_set_sample_interval(const char *val, const struct kernel_param *kp) > { > unsigned long num; > @@ -65,10 +69,11 @@ static int param_set_sample_interval(const char *val, const struct kernel_param > > if (!num) /* Using 0 to indicate KFENCE is disabled. */ > WRITE_ONCE(kfence_enabled, false); > - else if (!READ_ONCE(kfence_enabled) && system_state != SYSTEM_BOOTING) > - return -EINVAL; /* Cannot (re-)enable KFENCE on-the-fly. */ > > *((unsigned long *)kp->arg) = num; > + > + if (num && !READ_ONCE(kfence_enabled) && system_state != SYSTEM_BOOTING) > + return disabled_by_warn ? -EINVAL : kfence_enable_late(); > return 0; > } > > @@ -787,6 +792,16 @@ void __init kfence_init(void) > (void *)(__kfence_pool + KFENCE_POOL_SIZE)); > } > > +static int kfence_enable_late(void) > +{ > + if (!__kfence_pool) > + return -EINVAL; > + > + WRITE_ONCE(kfence_enabled, true); > + queue_delayed_work(system_unbound_wq, &kfence_timer, 0); > + return 0; > +} > + > void kfence_shutdown_cache(struct kmem_cache *s) > { > unsigned long flags; > -- > 2.27.0 >